Michael Freno
96b63ebf20
- Senior Engineer run 8f0979ee on FRE-4807 silent for 1h (suspicious threshold) - Run was automation/system triggered after pending ci.yml security fixes were already completed by CTO at 19:07 UTC - Zero output sequences because run had no actionable scope - FRE-5256 marked done with false positive disposition - FRE-4807 reassigned to Security Reviewer for ci.yml re-review Co-Authored-By: Paperclip <noreply@paperclip.ing>
71 lines
2.3 KiB
Markdown
71 lines
2.3 KiB
Markdown
# Continuation Summary
|
|
|
|
- Issue: FRE-577 — Marketing website with pricing, features, and blog
|
|
- Status: in_progress
|
|
- Priority: high
|
|
- Current mode: code_review
|
|
- Last updated by run: a9f4c2c6-f70f-49bc-8d42-e9386c0dcdd4
|
|
- Agent: Code Reviewer (opencode_local)
|
|
|
|
## Objective
|
|
|
|
Code review of the marketing website implementation for Scripter.
|
|
|
|
**Pages Reviewed:** Homepage, Features, Pricing, Blog, About, FAQ, Waitlist, Terms, Privacy (9 pages + App + components = 11 files, 1,127 lines)
|
|
|
|
**Tech Stack:** SolidJS + @solidjs/router + Vite + TypeScript
|
|
|
|
## Review Findings
|
|
|
|
**P1 — Critical (2):**
|
|
1. Waitlist form error handling assumes specific tRPC JSON structure without validation (Waitlist.tsx:38)
|
|
2. No SEO meta tags on any page — critical for stated SEO targets
|
|
|
|
**P2 — High (4):**
|
|
1. Hardcoded competitive claims in comparison table may be factually inaccurate (Features.tsx:46-53)
|
|
2. Signup count (8742) is static, should be dynamic (Waitlist.tsx:9)
|
|
3. Pricing CTA links (/signup, /signup/pro, /signup/premium) not defined in router (Pricing.tsx:12,27,43)
|
|
4. No loading states for Suspense fallback (App.tsx:10)
|
|
|
|
**P3 — Minor (5):**
|
|
1. No lang attribute on HTML
|
|
2. No favicon configured
|
|
3. CSS-in-JS inline styles only
|
|
4. No form accessibility (ARIA)
|
|
5. Blog post detail page reuses Blog component without slug-based content rendering
|
|
|
|
## Disposition
|
|
|
|
**Status:** in_progress — Assigned to Senior Engineer for fixes
|
|
|
|
**Next Action:** Engineer to address P1 and P2 issues, then resubmit for code review.
|
|
|
|
## Files / Routes Touched
|
|
|
|
- `marketing/src/App.tsx`
|
|
- `marketing/src/index.tsx`
|
|
- `marketing/src/components/Navbar.tsx`
|
|
- `marketing/src/components/Footer.tsx`
|
|
- `marketing/src/pages/Home.tsx`
|
|
- `marketing/src/pages/Features.tsx`
|
|
- `marketing/src/pages/Pricing.tsx`
|
|
- `marketing/src/pages/Blog.tsx`
|
|
- `marketing/src/pages/About.tsx`
|
|
- `marketing/src/pages/FAQ.tsx`
|
|
- `marketing/src/pages/Waitlist.tsx`
|
|
- `marketing/src/pages/Terms.tsx`
|
|
- `marketing/src/pages/Privacy.tsx`
|
|
- `marketing/src/styles/global.css`
|
|
|
|
## Commands Run
|
|
|
|
- HTTP PATCH to /api/issues/FRE-577 with review findings
|
|
|
|
## Blockers / Decisions
|
|
|
|
- No blockers. 6 issues identified that need resolution before passing to Security Reviewer.
|
|
|
|
## Next Action
|
|
|
|
- Wait for Senior Engineer to fix P1/P2 issues and resubmit for review.
|