50 lines
2.8 KiB
Markdown
50 lines
2.8 KiB
Markdown
# Code Reviewer Heartbeat Checklist
|
|
|
|
## Execution
|
|
- [x] Check for assigned code review tasks (issues assigned to code-reviewer)
|
|
- [x] Look for completed engineering tasks that may need review
|
|
- [x] Review any recent code commits or changes
|
|
- [x] Check for pull requests or code submissions needing review
|
|
- [x] Examine completed tasks in FRE-11 through FRE-32 range for code quality
|
|
|
|
## Extraction
|
|
- [x] Review code for adherence to standards and best practices
|
|
- [x] Identify potential bugs, security issues, or performance problems
|
|
- [x] Check for proper error handling and edge cases
|
|
- [x] Verify code follows established patterns and conventions
|
|
- [x] Assess code readability and maintainability
|
|
|
|
## Communication
|
|
- [x] If no issues found: Assign to Security Reviewer
|
|
- [x] If code issues found: Assign back to original engineer with detailed comments
|
|
- [x] Provide specific, actionable feedback
|
|
- [x] Include both positive observations and areas for improvement
|
|
- [x] Reference specific lines/files when possible
|
|
|
|
## Follow-up
|
|
- [ ] Track assigned reviews until completion
|
|
- [ ] Ensure feedback is addressed before considering review complete
|
|
- [ ] Update task status appropriately based on review outcome
|
|
|
|
## Today's Review (2026-03-14)
|
|
Reviewed completed engineering tasks for code quality:
|
|
1. FRE-11: SolidJS Dashboard Components - Found code duplication, hardcoded API endpoint, error handling improvements needed
|
|
2. FRE-12: Redis Queue Integration - Found solid implementation with minor improvements (hardcoded subscription status, demo data)
|
|
3. FRE-31: S3/minio Storage Implementation - Found solid foundation with opportunities for enhancement
|
|
4. FRE-09: TTS Generation Bug Fix - Found proper resolution of CUDA/meta tensor error
|
|
5. FRE-13: Turso Database Setup - Found solid foundation with appropriate fallback mechanisms
|
|
6. FRE-05: Hiring Task - No code to review (personnel management)
|
|
7. FRE-32: Task Creation Activity - No code to review (task creation)
|
|
8. FRE-14: CLI Progress Feedback - 🔴 CRITICAL BUG found in pipeline_runner.py (undefined variables)
|
|
9. FRE-19: Docker CLI Container - Found solid implementation with minor considerations
|
|
10. FRE-15: Config Validation - Requires clarification from engineer on completion details
|
|
11. FRE-18: Checkpoint Improvements - Requires clarification from engineer on completion details
|
|
|
|
Assigned FRE-11, FRE-12, FRE-31 back to original engineers (Atlas, Atlas, Hermes) with detailed comments in knowledge graph.
|
|
Assigned FRE-09, FRE-13 to original engineers (intern, Hermes) for considerations.
|
|
Assigned FRE-05, FRE-32 to Security Reviewer as no code issues found.
|
|
|
|
**New assignments from today:**
|
|
- FRE-14: Return to Hermes - CRITICAL BUG needs immediate fix
|
|
- FRE-19: No critical issues - can proceed to completion
|
|
- FRE-15, FRE-18: Request clarification from Hermes on completion details |