Mike/FrenoCorp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
251 Commits 2 Branches 0 Tags
2a01fd866ea6c22d82aaf3c8d8fdf3fdf537cf29
Commit Graph

10 Commits

Author SHA1 Message Date
Michael Freno
1b5fb6b635 Fix FRE-4690 third-pass review findings 
P1: Add distribution cert + provisioning profile import for TestFlight
P3: Remove --recursive from swift format lint (redundant, causes error)
P3: Revert vercel-action v25 → v30
 2026-05-10 09:10:05 -04:00
Michael Freno
7b50a53838 Complete productivity review FRE-4808, fix review pipeline assignments for 3 issues [FRE-5100] 2026-05-10 08:09:41 -04:00
Senior Engineer
b8c14ef8a7 Fix CI/CD pipeline issues from code review FRE-4690 
P1: Fix TestFlight deployment — add LendairApp executable target,
    use xcodebuild archive/export instead of swift build for IPA
P2: Fix swift-format — use built-in 'swift format lint' (Swift 5.6+)
    instead of external 'swift-format' binary
P3: Create missing index.html for Vite build entry point
P3: Update vercel-action from v30 to v25 (better maintained)
 2026-05-10 06:04:09 -04:00
Michael Freno
6b47ed4a06 Close FRE-5081: mark ghost run 14acabf9 evaluation as false positive 
The stale-run detector flagged the same Code Reviewer ghost run
(14acabf9, FRE-4695) for the ~11th time. Run has pid=unknown,
in-memory-handle=no, invocation=assignment/system — confirmed
opencode_local ghost run. Documented in Code Reviewer's AGENTS.md
as expected behavior. Root fixes tracked in FRE-4990 and FRE-5042.
 2026-05-10 04:58:28 -04:00
Michael Freno
e7b951ec07 Review silent active run for Code Reviewer FRE-4989 
- Closed FRE-4989 as false positive (same ghost run 14acabf9)
- Ghost run has pid unknown, no in-memory handle per FRE-4966 pattern
- FRE-4990 remains the root fix (server-side ghost-run dedup)
- Existing ghost run record keeps spawning new evaluation issues

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-10 02:47:31 -04:00
Michael Freno
90c79eb6d4 FRE-4955 Review silent active run for Code Reviewer 
- FRE-4955: 9th stale-run eval for Code Reviewer zombie run , marked false positive
- FRE-4954: Investigation of Code Reviewer adapter reliability closed as done. Root cause: no heartbeat/adapter config. Fix tracked in FRE-4956 (CEO)
- Broader CTO oversight: Senior Engineer bottleneck (19 in_review), Code Reviewer ghost runs awaiting FRE-4956

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-10 01:43:53 -04:00
Michael Freno
f0305134e8 Auto-commit 2026-05-03 22:45 2026-05-03 22:45:42 -04:00
Michael Freno
b898ae3763 FRE-4663: Complete code review for Nessa Phase 1 GPS tracking and activity feed 
- Reviewed RouteExecutionView.swift (341 lines) - GPS tracking UI
- Reviewed ActivityFeedView.swift (93 lines) - TabView composition
- Reviewed FollowViewModel.swift (163 lines) - @Observable pattern
- Reviewed test files (448 lines total, 34 test cases)
- All code quality checks passed
- Assigned to Security Reviewer for final approval
 2026-05-03 13:00:22 -04:00
Michael Freno
bb8b2e1c9e FRE-4706: Complete unblocking of FRE-4639 liveness incident 
Pushed FRE-4639 build warnings fix to gt/master. All iOS audit stabilization issues now live on main branch.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
 2026-05-03 01:13:09 -04:00
Michael Freno
3d6bf9d106 i think this is the one 2026-03-14 19:17:56 -04:00