Replacing errors with warns in non-critical areas

This commit is contained in:
Michael Freno
2025-11-17 01:56:02 -05:00
parent f4d514bf2e
commit e5e7b55709
25 changed files with 3596 additions and 313 deletions

View File

@@ -24,51 +24,67 @@ function TestImageScaler:testScaleNearestWithNilSource()
end
function TestImageScaler:testScaleNearestWithZeroSourceWidth()
luaunit.assertError(function()
ImageScaler.scaleNearest(self.mockImageData, 0, 0, 0, 10, 20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleNearest(self.mockImageData, 0, 0, 0, 10, 20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleNearestWithZeroSourceHeight()
luaunit.assertError(function()
ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 0, 20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 0, 20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleNearestWithNegativeSourceWidth()
luaunit.assertError(function()
ImageScaler.scaleNearest(self.mockImageData, 0, 0, -10, 10, 20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleNearest(self.mockImageData, 0, 0, -10, 10, 20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleNearestWithNegativeSourceHeight()
luaunit.assertError(function()
ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, -10, 20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, -10, 20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleNearestWithZeroDestWidth()
luaunit.assertError(function()
ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 10, 0, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 10, 0, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleNearestWithZeroDestHeight()
luaunit.assertError(function()
ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 10, 20, 0)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 10, 20, 0)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleNearestWithNegativeDestWidth()
luaunit.assertError(function()
ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 10, -20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 10, -20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleNearestWithNegativeDestHeight()
luaunit.assertError(function()
ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 10, 20, -20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleNearest(self.mockImageData, 0, 0, 10, 10, 20, -20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
-- Unhappy path tests for scaleBilinear
@@ -80,51 +96,67 @@ function TestImageScaler:testScaleBilinearWithNilSource()
end
function TestImageScaler:testScaleBilinearWithZeroSourceWidth()
luaunit.assertError(function()
ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 0, 10, 20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 0, 10, 20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleBilinearWithZeroSourceHeight()
luaunit.assertError(function()
ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 0, 20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 0, 20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleBilinearWithNegativeSourceWidth()
luaunit.assertError(function()
ImageScaler.scaleBilinear(self.mockImageData, 0, 0, -10, 10, 20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleBilinear(self.mockImageData, 0, 0, -10, 10, 20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleBilinearWithNegativeSourceHeight()
luaunit.assertError(function()
ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, -10, 20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, -10, 20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleBilinearWithZeroDestWidth()
luaunit.assertError(function()
ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 10, 0, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 10, 0, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleBilinearWithZeroDestHeight()
luaunit.assertError(function()
ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 10, 20, 0)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 10, 20, 0)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleBilinearWithNegativeDestWidth()
luaunit.assertError(function()
ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 10, -20, 20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 10, -20, 20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
function TestImageScaler:testScaleBilinearWithNegativeDestHeight()
luaunit.assertError(function()
ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 10, 20, -20)
end)
-- Now returns 1x1 transparent fallback with warning instead of error
local result = ImageScaler.scaleBilinear(self.mockImageData, 0, 0, 10, 10, 20, -20)
luaunit.assertNotNil(result)
luaunit.assertEquals(result:getWidth(), 1)
luaunit.assertEquals(result:getHeight(), 1)
end
-- Edge case tests