more tests, fixed theme validation

2025-11-14 21:54:01 -05:00
parent 1dab1a197e
commit 48d44a1a11
12 changed files with 2380 additions and 169 deletions
--- a/testing/tests/texteditor_sanitization_test.lua
+++ b/testing/tests/texteditor_sanitization_test.lua
@@ -12,12 +12,14 @@ local Color = require("modules.Color")
 -- Mock dependencies
 local mockContext = {
  _immediateMode = false,
-  _focusedElement = nil
+  _focusedElement = nil,
 }

 local mockStateManager = {
-  getState = function() return nil end,
-  setState = function() end
+  getState = function()
+    return nil
+  end,
+  setState = function() end,
 }

 -- Test Suite for TextEditor Sanitization
@@ -31,7 +33,7 @@ function TestTextEditorSanitization:_createEditor(config)
    Context = mockContext,
    StateManager = mockStateManager,
    Color = Color,
-    utils = utils
+    utils = utils,
  }
  return TextEditor.new(config, deps)
 end
@@ -39,41 +41,41 @@ end
 -- === Sanitization Enabled Tests ===

 function TestTextEditorSanitization:test_sanitization_enabled_by_default()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  luaunit.assertTrue(editor.sanitize)
 end

 function TestTextEditorSanitization:test_sanitization_can_be_disabled()
-  local editor = self:_createEditor({editable = true, sanitize = false})
+  local editor = self:_createEditor({ editable = true, sanitize = false })
  luaunit.assertFalse(editor.sanitize)
 end

 function TestTextEditorSanitization:test_setText_removes_control_characters()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Hello\x00World\x01Test")
  luaunit.assertEquals(editor:getText(), "HelloWorldTest")
 end

 function TestTextEditorSanitization:test_setText_preserves_valid_text()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Hello World! 123")
  luaunit.assertEquals(editor:getText(), "Hello World! 123")
 end

 function TestTextEditorSanitization:test_setText_removes_multiple_control_chars()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Test\x00\x01\x02\x03\x04Data")
  luaunit.assertEquals(editor:getText(), "TestData")
 end

 function TestTextEditorSanitization:test_setText_with_sanitization_disabled()
-  local editor = self:_createEditor({editable = true, sanitize = false})
+  local editor = self:_createEditor({ editable = true, sanitize = false })
  editor:setText("Hello\x00World")
  luaunit.assertEquals(editor:getText(), "Hello\x00World")
 end

 function TestTextEditorSanitization:test_setText_skip_sanitization_parameter()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Hello\x00World", true) -- skipSanitization = true
  luaunit.assertEquals(editor:getText(), "Hello\x00World")
 end
@@ -83,7 +85,7 @@ end
 function TestTextEditorSanitization:test_initial_text_is_sanitized()
  local editor = self:_createEditor({
    editable = true,
-    text = "Initial\x00Text\x01"
+    text = "Initial\x00Text\x01",
  })
  luaunit.assertEquals(editor:getText(), "InitialText")
 end
@@ -92,7 +94,7 @@ function TestTextEditorSanitization:test_initial_text_preserved_when_disabled()
  local editor = self:_createEditor({
    editable = true,
    sanitize = false,
-    text = "Initial\x00Text"
+    text = "Initial\x00Text",
  })
  luaunit.assertEquals(editor:getText(), "Initial\x00Text")
 end
@@ -100,19 +102,19 @@ end
 -- === insertText Sanitization ===

 function TestTextEditorSanitization:test_insertText_sanitizes_input()
-  local editor = self:_createEditor({editable = true, text = "Hello"})
+  local editor = self:_createEditor({ editable = true, text = "Hello" })
  editor:insertText("\x00World", 5)
  luaunit.assertEquals(editor:getText(), "HelloWorld")
 end

 function TestTextEditorSanitization:test_insertText_with_valid_text()
-  local editor = self:_createEditor({editable = true, text = "Hello"})
+  local editor = self:_createEditor({ editable = true, text = "Hello" })
  editor:insertText(" World", 5)
  luaunit.assertEquals(editor:getText(), "Hello World")
 end

 function TestTextEditorSanitization:test_insertText_empty_after_sanitization()
-  local editor = self:_createEditor({editable = true, text = "Hello"})
+  local editor = self:_createEditor({ editable = true, text = "Hello" })
  editor:insertText("\x00\x01\x02", 5) -- Only control chars
  luaunit.assertEquals(editor:getText(), "Hello") -- Should remain unchanged
 end
@@ -120,25 +122,25 @@ end
 -- === Length Limiting ===

 function TestTextEditorSanitization:test_maxLength_enforced_on_setText()
-  local editor = self:_createEditor({editable = true, maxLength = 10})
+  local editor = self:_createEditor({ editable = true, maxLength = 10 })
  editor:setText("This is a very long text")
  luaunit.assertEquals(#editor:getText(), 10)
 end

 function TestTextEditorSanitization:test_maxLength_enforced_on_insertText()
-  local editor = self:_createEditor({editable = true, text = "12345", maxLength = 10})
+  local editor = self:_createEditor({ editable = true, text = "12345", maxLength = 10 })
  editor:insertText("67890", 5) -- This would make it exactly 10
  luaunit.assertEquals(editor:getText(), "1234567890")
 end

 function TestTextEditorSanitization:test_maxLength_truncates_excess()
-  local editor = self:_createEditor({editable = true, text = "12345", maxLength = 10})
+  local editor = self:_createEditor({ editable = true, text = "12345", maxLength = 10 })
  editor:insertText("67890EXTRA", 5) -- Would exceed limit
  luaunit.assertEquals(editor:getText(), "1234567890")
 end

 function TestTextEditorSanitization:test_maxLength_prevents_insert_when_full()
-  local editor = self:_createEditor({editable = true, text = "1234567890", maxLength = 10})
+  local editor = self:_createEditor({ editable = true, text = "1234567890", maxLength = 10 })
  editor:insertText("X", 10)
  luaunit.assertEquals(editor:getText(), "1234567890") -- Should not change
 end
@@ -146,13 +148,13 @@ end
 -- === Newline Handling ===

 function TestTextEditorSanitization:test_newlines_allowed_in_multiline()
-  local editor = self:_createEditor({editable = true, multiline = true})
+  local editor = self:_createEditor({ editable = true, multiline = true })
  editor:setText("Line1\nLine2")
  luaunit.assertEquals(editor:getText(), "Line1\nLine2")
 end

 function TestTextEditorSanitization:test_newlines_removed_in_singleline()
-  local editor = self:_createEditor({editable = true, multiline = false})
+  local editor = self:_createEditor({ editable = true, multiline = false })
  editor:setText("Line1\nLine2")
  luaunit.assertEquals(editor:getText(), "Line1Line2")
 end
@@ -161,7 +163,7 @@ function TestTextEditorSanitization:test_allowNewlines_explicit_false()
  local editor = self:_createEditor({
    editable = true,
    multiline = true,
-    allowNewlines = false
+    allowNewlines = false,
  })
  editor:setText("Line1\nLine2")
  luaunit.assertEquals(editor:getText(), "Line1Line2")
@@ -170,7 +172,7 @@ end
 -- === Tab Handling ===

 function TestTextEditorSanitization:test_tabs_allowed_by_default()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Hello\tWorld")
  luaunit.assertEquals(editor:getText(), "Hello\tWorld")
 end
@@ -178,7 +180,7 @@ end
 function TestTextEditorSanitization:test_tabs_removed_when_disabled()
  local editor = self:_createEditor({
    editable = true,
-    allowTabs = false
+    allowTabs = false,
  })
  editor:setText("Hello\tWorld")
  luaunit.assertEquals(editor:getText(), "HelloWorld")
@@ -190,10 +192,10 @@ function TestTextEditorSanitization:test_custom_sanitizer_used()
  local customSanitizer = function(text)
    return text:upper()
  end
-  
+
  local editor = self:_createEditor({
    editable = true,
-    customSanitizer = customSanitizer
+    customSanitizer = customSanitizer,
  })
  editor:setText("hello world")
  luaunit.assertEquals(editor:getText(), "HELLO WORLD")
@@ -204,10 +206,10 @@ function TestTextEditorSanitization:test_custom_sanitizer_with_control_chars()
    -- Custom sanitizer that replaces control chars with *
    return text:gsub("[\x00-\x1F]", "*")
  end
-  
+
  local editor = self:_createEditor({
    editable = true,
-    customSanitizer = customSanitizer
+    customSanitizer = customSanitizer,
  })
  editor:setText("Hello\x00World\x01")
  luaunit.assertEquals(editor:getText(), "Hello*World*")
@@ -216,19 +218,19 @@ end
 -- === Unicode and Special Characters ===

 function TestTextEditorSanitization:test_unicode_preserved()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Hello 世界 🌍")
  luaunit.assertEquals(editor:getText(), "Hello 世界 🌍")
 end

 function TestTextEditorSanitization:test_emoji_preserved()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("😀😃😄😁")
  luaunit.assertEquals(editor:getText(), "😀😃😄😁")
 end

 function TestTextEditorSanitization:test_special_chars_preserved()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("!@#$%^&*()_+-=[]{}|;':\",./<>?")
  luaunit.assertEquals(editor:getText(), "!@#$%^&*()_+-=[]{}|;':\",./<>?")
 end
@@ -236,25 +238,25 @@ end
 -- === Edge Cases ===

 function TestTextEditorSanitization:test_empty_string()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("")
  luaunit.assertEquals(editor:getText(), "")
 end

 function TestTextEditorSanitization:test_only_control_characters()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("\x00\x01\x02\x03")
  luaunit.assertEquals(editor:getText(), "")
 end

 function TestTextEditorSanitization:test_nil_text()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText(nil)
  luaunit.assertEquals(editor:getText(), "")
 end

 function TestTextEditorSanitization:test_very_long_text_with_control_chars()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  local longText = string.rep("Hello\x00World", 100)
  editor:setText(longText)
  luaunit.assertStrContains(editor:getText(), "Hello")
@@ -263,7 +265,7 @@ function TestTextEditorSanitization:test_very_long_text_with_control_chars()
 end

 function TestTextEditorSanitization:test_mixed_valid_and_invalid()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Valid\x00Text\x01With\x02Control\x03Chars")
  luaunit.assertEquals(editor:getText(), "ValidTextWithControlChars")
 end
@@ -271,13 +273,13 @@ end
 -- === Whitespace Handling ===

 function TestTextEditorSanitization:test_spaces_preserved()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Hello   World")
  luaunit.assertEquals(editor:getText(), "Hello   World")
 end

 function TestTextEditorSanitization:test_leading_trailing_spaces_preserved()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("  Hello World  ")
  luaunit.assertEquals(editor:getText(), "  Hello World  ")
 end
@@ -285,7 +287,7 @@ end
 -- === Integration Tests ===

 function TestTextEditorSanitization:test_cursor_position_after_sanitization()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Hello")
  editor:insertText("\x00World", 5)
  -- Cursor should be at end of "HelloWorld" = position 10
@@ -293,7 +295,7 @@ function TestTextEditorSanitization:test_cursor_position_after_sanitization()
 end

 function TestTextEditorSanitization:test_multiple_operations()
-  local editor = self:_createEditor({editable = true})
+  local editor = self:_createEditor({ editable = true })
  editor:setText("Hello")
  editor:insertText(" ", 5)
  editor:insertText("World\x00", 6)