Commit Graph

3 Commits

Author SHA1 Message Date
bf26cd3ed6 feat: implement Milestone 3 integration points
Add comprehensive integration capabilities to Pop CLI:

- Multi-account support with named profiles
- Webhook management with signature verification
- External PGP key management (import/export/encrypt/decrypt/sign/verify)
- CLI plugin system for extensibility
- Complete documentation in README.md

All compilation errors fixed and build verified CLEAN.

Security review delegated to FRE-5202.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-14 00:40:24 -04:00
Senior Engineer
5dc4a1b742 Fix FRE-4693 code review findings: 2-arg constructor, 403 error test, error content check
Some checks failed
CI / build (1.21.x) (push) Has been cancelled
CI / build (1.22.x) (push) Has been cancelled
CI / security-scan (push) Has been cancelled
- Pass nil refresher to NewProtonMailClient at all 5 call sites
- Change TestListMessages_APIError from 401 to 403 (avoids refresh interception)
- Add error content assertion to TestGetMessage_NotFound
2026-05-10 09:38:21 -04:00
Senior Engineer
90bee9119e FRE-4693: Add integration tests for mail client
46 new integration tests covering all mail client operations:
- ListMessages: success, folder/starred/read/since filters, combined filters, API errors, bad JSON
- GetMessage: success, URL escaping, not found, decrypt body with PGP
- Send: success, PGP encryption, CC/BCC, HTTP errors, 201 status
- MoveToTrash: success, error handling
- PermanentlyDelete: success, error, URL escaping
- SaveDraft: success, CC/BCC, API error, bad JSON
- UpdateDraft: success, CC, conflict error
- SendDraft: success, error
- ListDrafts: success via ListMessages delegation
- SearchMessages: success, empty results, API error, bad JSON
- Auth header propagation, content-type headers
- Concurrent access safety, timeout handling
- Helper types: Folder.Name, Recipient.DisplayName, Message.Folder

Uses httptest.Server with configurable route handlers to mock ProtonMail API.
All 46 tests pass. 3 pre-existing pgp_test.go failures unchanged.
2026-05-03 17:34:27 -04:00