Michael Freno
31e0b39794
P1: Load dd-trace before other modules via datadog-init.ts entry point P1: Batch all CloudWatch metrics into single PutMetricDataCommand per request P2: Deduplicate warning logs with else-if for high latency vs error P3: Add response.ok check to Datadog log forwarding fetch P3: Update getSentryHub() to use getCurrentScope() for Sentry SDK 8.x Co-Authored-By: Paperclip <noreply@paperclip.ing>
2.7 KiB
2.7 KiB
ShieldAI Code Review Workflow
Current State (as of May 2, 2026)
PR Backlog Status
- Open PRs: 0 (pending commits pushed to master)
- Pending commits: 1 commit pushed (FRE-4604) — remaining 6 were previously pushed
- Last review cycle: FRE-4500, FRE-4499, FRE-4612 (security findings — all done)
- Branch protection: Configured (see
branch-protection-rules.yaml) - PR template: Configured (
.gitea/pull_request_templates/default.md)
Resolved Bottlenecks
- ✅ PR-based workflow established with PR template
- ✅ Branch protection rules documented and configured
- ✅ Code review checklist integrated into PR template
- ✅ Security review findings integrated (FRE-4499, FRE-4500, FRE-4612 all done)
PR Process
- Feature branch creation from
gt/master - Development commits with conventional commit format (include issue ID:
FRE-XXXX: description) - PR creation against
gt/master - Required reviews:
- Code Reviewer — all PRs
- Security Reviewer — for security-sensitive changes
- CI checks pass (lint, typecheck, test)
- Merge via squash or rebase
Code Review Checklist
- Security impact assessment
- Test coverage verification
- Type checking (TypeScript)
- Linting compliance
- Documentation updates
- Breaking changes documented
- Backward compatibility verified
Branch Protection Rules
See branch-protection-rules.yaml for the full configuration. Summary:
- Protected branch:
gt/master - Required reviews: 1 approved review before merge
- Required status checks: lint, typecheck, test
- Enforce admins: false (admins can bypass during emergencies)
- Allow force pushes: true (for recovery scenarios)
Review Assignment Policy
| Change Type | Required Reviewers |
|---|---|
| General code | Code Reviewer |
| Security-critical | Code Reviewer + Security Reviewer |
| API contracts | Code Reviewer + CTO |
| Database schema | Code Reviewer + Senior Engineer |
Review Pipeline
Engineer implements → marks in_review → Security Reviewer reviews → Code Reviewer reviews → Done
Metrics to Track
- PR cycle time (creation to merge)
- Review turnaround time
- PR size (lines changed)
- Review comments per PR
- Merge conflict frequency
Contribution Guidelines
- Always create a feature branch from
gt/master - Use conventional commit format:
type(scope): description (FRE-XXXX) - Include tests for new functionality
- Update documentation for API changes
- Run lint and typecheck before pushing
- Create PR with filled template before requesting review
- Address all review comments before merge
Updated from FRE-4556 audit, implemented in FRE-4661