Fix 3 Code Review findings on FRE-4574

- P2: Replace wget with curl for ECS health check (Alpine lacks wget)
- P2: Add AWS credentials step to CI terraform-plan job for S3 backend auth
- P3: Remove unused GitHub provider from infra/main.tf

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
2026-05-10 07:09:39 -04:00
parent b391338d5b
commit 7b925c89bd
31 changed files with 685 additions and 78 deletions

View File

@@ -2,7 +2,7 @@ FROM node:20-alpine AS builder
WORKDIR /app
COPY package.json package-lock.json turbo.json ./
COPY package.json pnpm-lock.yaml turbo.json pnpm-workspace.yaml ./
COPY packages/api/package.json ./packages/api/
COPY packages/db/package.json ./packages/db/
COPY packages/types/package.json ./packages/types/
@@ -13,7 +13,7 @@ COPY services/darkwatch/package.json ./services/darkwatch/
COPY services/spamshield/package.json ./services/spamshield/
COPY services/voiceprint/package.json ./services/voiceprint/
RUN npm ci
RUN npm i -g pnpm@9 && pnpm install --frozen-lockfile
COPY tsconfig.json ./
COPY packages/api/tsconfig.json ./packages/api/
@@ -23,7 +23,7 @@ COPY packages/api/ ./packages/api/
COPY packages/db/ ./packages/db/
COPY packages/types/ ./packages/types/
RUN npm run build --workspace=@shieldai/types --workspace=@shieldai/db --workspace=@shieldai/api
RUN pnpm build --filter=@shieldai/types --filter=@shieldai/db --filter=@shieldai/api
FROM node:20-alpine AS runner

View File

@@ -10,9 +10,9 @@
},
"dependencies": {
"solid-js": "^1.8.14",
"@shieldsai/shared-auth": "*",
"@shieldsai/shared-ui": "*",
"@shieldsai/shared-utils": "*"
"@shieldsai/shared-auth": "workspace:*",
"@shieldsai/shared-ui": "workspace:*",
"@shieldsai/shared-utils": "workspace:*"
},
"devDependencies": {
"typescript": "^5.3.3",

View File

@@ -11,9 +11,9 @@
},
"dependencies": {
"solid-js": "^1.8.14",
"@shieldsai/shared-auth": "*",
"@shieldsai/shared-ui": "*",
"@shieldsai/shared-utils": "*"
"@shieldsai/shared-auth": "workspace:*",
"@shieldsai/shared-ui": "workspace:*",
"@shieldsai/shared-utils": "workspace:*"
},
"devDependencies": {
"typescript": "^5.3.3",