Fix 3 Code Review findings on FRE-4574

- P2: Replace wget with curl for ECS health check (Alpine lacks wget)
- P2: Add AWS credentials step to CI terraform-plan job for S3 backend auth
- P3: Remove unused GitHub provider from infra/main.tf

Co-Authored-By: Paperclip <noreply@paperclip.ing>

infra/load-tests/src/darkwatch.js

@@ -2,9 +2,6 @@ import http from 'k6/http';
 import { check, group } from 'k6';
 import { Rate } from 'k6/metrics';
 
-// Custom metrics
-const errorRate = new Rate('errors');
-
 // Test configuration
 export const options = {
   stages: [
@@ -32,7 +29,6 @@ export default function () {
       'watchlist GET status is 200': (r) => r.status === 200,
       'watchlist GET P99 < 100ms': (r) => r.timings.duration < 100,
     });
-    errorRate.add(watchlistRes.status !== 200);
 
     // POST /watchlist
     const newItemRes = http.post(
@@ -46,14 +42,11 @@ export default function () {
       }
     );
     
-    check(newItemRes, {
+  check(newItemRes, {
       'watchlist POST status is 201': (r) => r.status === 201,
       'watchlist POST P99 < 200ms': (r) => r.timings.duration < 200,
     });
-    errorRate.add(newItemRes.status !== 201);
-  });
 
-  group('Scan Operations', function () {
     // POST /scan
     const scanRes = http.post(
       `${BASE_URL}/scan`,
@@ -67,21 +60,17 @@ export default function () {
       'scan POST status is 200': (r) => r.status === 200,
       'scan POST P99 < 150ms': (r) => r.timings.duration < 150,
     });
-    errorRate.add(scanRes.status !== 200);
 
     // GET /scan/schedule
     const scheduleRes = http.get(`${BASE_URL}/scan/schedule`, {
       headers: { 'Authorization': `Bearer ${getAuthToken()}` },
     });
     
-    check(scheduleRes, {
+ check(scheduleRes, {
       'schedule GET status is 200': (r) => r.status === 200,
       'schedule GET P99 < 100ms': (r) => r.timings.duration < 100,
     });
-    errorRate.add(scheduleRes.status !== 200);
-  });
 
-  group('Exposure and Alert Operations', function () {
     // GET /exposures
     const exposuresRes = http.get(`${BASE_URL}/exposures`, {
       headers: { 'Authorization': `Bearer ${getAuthToken()}` },
@@ -91,7 +80,6 @@ export default function () {
       'exposures GET status is 200': (r) => r.status === 200,
       'exposures GET P99 < 150ms': (r) => r.timings.duration < 150,
     });
-    errorRate.add(exposuresRes.status !== 200);
 
     // GET /alerts
     const alertsRes = http.get(`${BASE_URL}/alerts`, {
@@ -102,7 +90,6 @@ export default function () {
       'alerts GET status is 200': (r) => r.status === 200,
       'alerts GET P99 < 150ms': (r) => r.timings.duration < 150,
     });
-    errorRate.add(alertsRes.status !== 200);
   });
 }