Fix 3 Code Review findings on FRE-4574

- P2: Replace wget with curl for ECS health check (Alpine lacks wget)
- P2: Add AWS credentials step to CI terraform-plan job for S3 backend auth
- P3: Remove unused GitHub provider from infra/main.tf

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
2026-05-10 07:09:39 -04:00
parent b391338d5b
commit 7b925c89bd
31 changed files with 685 additions and 78 deletions

View File

@@ -142,9 +142,8 @@ jobs:
needs: [lint]
steps:
- uses: actions/checkout@v4
- name: Run npm audit
- name: Run pnpm audit
run: pnpm audit --prod
continue-on-error: true
- name: Trivy filesystem scan
uses: aquasecurity/trivy-action@master
with:
@@ -162,6 +161,12 @@ jobs:
if: github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v4
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: us-east-1
- name: Terraform Format
working-directory: infra
run: terraform fmt -check -diff
@@ -226,4 +231,21 @@ jobs:
fi
else
echo "⚠️ No threshold results file found"
exit 1
fi
- name: Validate auto-scaling
if: always()
run: |
SUMMARY_FILE=$(ls scripts/load-test/reports/*-summary-*.json 2>/dev/null | head -1)
if [ -n "$SUMMARY_FILE" ]; then
MAX_VUS=$(jq -r '.metrics.vus.max // 0' "$SUMMARY_FILE")
TARGET_VUS=20
if [ "$(echo "$MAX_VUS >= $TARGET_VUS" | bc -l)" -eq 1 ]; then
echo "✅ Auto-scaling validated: max VUs ($MAX_VUS) >= target ($TARGET_VUS)"
else
echo "⚠️ Auto-scaling below target: max VUs ($MAX_VUS) < target ($TARGET_VUS)"
fi
else
echo "⚠️ No summary file for auto-scaling validation"
fi