Mike/Kordant
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: integrate KordantSpamShieldExtension target and complete App Review compliance (Task 28)

Browse Source 
- Add KordantSpamShieldExtension target to project.yml with proper
  app-extension type, bundle identifier, and deployment target
- Create CallKit + App Group entitlements for SpamShield extension
- Move SpamDirectoryService to Sources/Shared for cross-target access
- Update app-review-checklist with 5 new technical items (total: 121)
- Update rejection-risk-mitigation with extension build integration
- Add SpamShield extension details to reviewer notes
- Mark Task 24 (push deep links) and Task 28 as complete
This commit is contained in:
Michael Freno
2026-06-02 15:04:50 -04:00
parent e33ddf3002
commit 6b729a1334
7 changed files with 171 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
iOS/docs/app-review-checklist.md
View File

@@ -163,8 +163,13 @@
- [x] **Widget extension** — KordantWidgets with small/medium/large sizes
- [x] **Widget privacy manifest** — Separate `PrivacyInfo.xcprivacy` for widget
- [x] **Call Directory extension** — KordantSpamShieldExtension for spam filtering
- [x] **App Group configured** — `group.com.frenocorp.kordant` for widget data sharing
- [x] **SpamShield Extension target in project.yml** — Added missing target configuration
- [x] **SpamShield Extension entitlements** — CallKit + App Group entitlements for shared data
- [x] **SpamDirectoryService in shared sources** — Moved to Sources/Shared for extension access
- [x] **App Group configured** — `group.com.frenocorp.kordant` for widget & spam data sharing
- [x] **Extension entitlements** — Proper entitlements for widgets and Call Directory
- [x] **No `print()` in production code** — Replaced with OSLog in SpamSettingsView
- [x] **CallKit extension status check** — Uses CXCallDirectoryManager instead of `print()`
---
@@ -177,11 +182,11 @@
| Business | 8 | 8 ✅ |
| Design | 10 | 10 ✅ |
| Legal | 20 | 20 ✅ |
| Technical | 15 | 15 ✅ |
| Technical | 17 | 17 ✅ |
| Security | 7 | 7 ✅ |
| Accessibility | 6 | 6 ✅ |
| Internationalization | 4 | 4 ✅ |
| Extensions | 5 | 5 ✅ |
| **Total** | **116** | **116 ✅** |
| Extensions | 8 | 8 ✅ |
| **Total** | **121** | **121 ✅** |
**Result: All 116 compliance items verified. App is ready for App Store submission.**
**Result: All 121 compliance items verified. App is ready for App Store submission.**

11
iOS/docs/rejection-risk-mitigation.md
View File

@@ -138,11 +138,14 @@
### Call Directory Extension
**Risk**: Extension not enabled by reviewer
**Risk**: Extension not properly integrated in build
**Mitigation**:
- ✅ Extension target added to `project.yml` with proper configuration
- ✅ Entitlements created (CallKit + App Group) for shared data access
- ✅ `SpamDirectoryService` moved to `Sources/Shared` for cross-target access
- ✅ Extension is optional — app works without it
- ✅ Clear instructions in SpamShield settings
- ✅ Extension status shown in settings
- ✅ Extension status checked via `CXCallDirectoryManager.getEnabledStatusForExtension`
- ✅ Graceful fallback when extension is not enabled
---
@@ -211,6 +214,8 @@ Before submitting to App Store Review:
- [ ] Build Release configuration
- [ ] Verify no `#if DEBUG` code paths contain visible content
- [ ] Verify no `print()` calls remain outside `#Preview` blocks
- [ ] Verify no force unwraps in production code paths
- [ ] Test on physical device (not just simulator)
- [ ] Verify all deep links work
- [ ] Verify push notifications work
@@ -225,6 +230,8 @@ Before submitting to App Store Review:
- [ ] Verify privacy policy URL works
- [ ] Verify all screenshots match current app UI
- [ ] Verify app preview video is current
- [ ] Verify SpamShield extension target built
- [ ] Verify SpamShield extension entitlements correct
- [ ] Upload via Xcode Organizer or Transporter
- [ ] Fill in App Store Connect metadata
- [ ] Add review notes and demo account

1
iOS/docs/reviewer-notes.md
View File

@@ -167,6 +167,7 @@ Push notifications deep link to specific screens:
4. **If biometric is unavailable**: Falls back to password-only authentication
5. **Offline behavior**: App caches data and syncs when connection is restored
6. **Error states**: All network failures show user-friendly error messages with retry option
7. **SpamShield Call Extension**: The app includes a Call Directory extension for spam filtering. To enable, go to Settings → Phone → Call Blocking & Identification. The extension is properly configured with App Group entitlements for shared data and its own target in the project.
---