2.8 KiB
2.8 KiB
Code Reviewer Heartbeat Checklist
Execution
- Check for assigned code review tasks (issues assigned to code-reviewer)
- Look for completed engineering tasks that may need review
- Review any recent code commits or changes
- Check for pull requests or code submissions needing review
- Examine completed tasks in FRE-11 through FRE-32 range for code quality
Extraction
- Review code for adherence to standards and best practices
- Identify potential bugs, security issues, or performance problems
- Check for proper error handling and edge cases
- Verify code follows established patterns and conventions
- Assess code readability and maintainability
Communication
- If no issues found: Assign to Security Reviewer
- If code issues found: Assign back to original engineer with detailed comments
- Provide specific, actionable feedback
- Include both positive observations and areas for improvement
- Reference specific lines/files when possible
Follow-up
- Track assigned reviews until completion
- Ensure feedback is addressed before considering review complete
- Update task status appropriately based on review outcome
Today's Review (2026-03-14)
Reviewed completed engineering tasks for code quality:
- FRE-11: SolidJS Dashboard Components - Found code duplication, hardcoded API endpoint, error handling improvements needed
- FRE-12: Redis Queue Integration - Found solid implementation with minor improvements (hardcoded subscription status, demo data)
- FRE-31: S3/minio Storage Implementation - Found solid foundation with opportunities for enhancement
- FRE-09: TTS Generation Bug Fix - Found proper resolution of CUDA/meta tensor error
- FRE-13: Turso Database Setup - Found solid foundation with appropriate fallback mechanisms
- FRE-05: Hiring Task - No code to review (personnel management)
- FRE-32: Task Creation Activity - No code to review (task creation)
- FRE-14: CLI Progress Feedback - 🔴 CRITICAL BUG found in pipeline_runner.py (undefined variables)
- FRE-19: Docker CLI Container - Found solid implementation with minor considerations
- FRE-15: Config Validation - Requires clarification from engineer on completion details
- FRE-18: Checkpoint Improvements - Requires clarification from engineer on completion details
Assigned FRE-11, FRE-12, FRE-31 back to original engineers (Atlas, Atlas, Hermes) with detailed comments in knowledge graph. Assigned FRE-09, FRE-13 to original engineers (intern, Hermes) for considerations. Assigned FRE-05, FRE-32 to Security Reviewer as no code issues found.
New assignments from today:
- FRE-14: Return to Hermes - CRITICAL BUG needs immediate fix
- FRE-19: No critical issues - can proceed to completion
- FRE-15, FRE-18: Request clarification from Hermes on completion details