- Consolidated duplicate UndoManagers to single instance - Fixed connection promise to only resolve on 'connected' status - Fixed WebSocketProvider import (WebsocketProvider) - Added proper doc.destroy() cleanup - Renamed isPresenceInitialized property to avoid conflict Co-Authored-By: Paperclip <noreply@paperclip.ing>
138 lines
5.6 KiB
TypeScript
138 lines
5.6 KiB
TypeScript
/**
|
|
* FIXME: remove this comments and import when below issue is fixed.
|
|
* This import is necessary for type generation due to a bug in the TypeScript compiler.
|
|
* See: https://github.com/microsoft/TypeScript/issues/42873
|
|
*/
|
|
// eslint-disable-next-line @typescript-eslint/no-unused-vars
|
|
import type { TSESLint } from "@typescript-eslint/utils";
|
|
|
|
import { TSESTree as T, ESLintUtils, ASTUtils } from "@typescript-eslint/utils";
|
|
import kebabCase from "kebab-case";
|
|
import { all as allCssProperties } from "known-css-properties";
|
|
import parse from "style-to-object";
|
|
import { jsxPropName } from "../utils";
|
|
|
|
const createRule = ESLintUtils.RuleCreator.withoutDocs;
|
|
const { getPropertyName, getStaticValue } = ASTUtils;
|
|
|
|
const lengthPercentageRegex = /\b(?:width|height|margin|padding|border-width|font-size)\b/i;
|
|
|
|
type MessageIds = "kebabStyleProp" | "invalidStyleProp" | "numericStyleValue" | "stringStyle";
|
|
type Options = [{ styleProps?: Array<string>; allowString?: boolean }?];
|
|
|
|
export default createRule<Options, MessageIds>({
|
|
meta: {
|
|
type: "problem",
|
|
docs: {
|
|
description:
|
|
"Require CSS properties in the `style` prop to be valid and kebab-cased (ex. 'font-size'), not camel-cased (ex. 'fontSize') like in React, " +
|
|
"and that property values with dimensions are strings, not numbers with implicit 'px' units.",
|
|
url: "https://github.com/solidjs-community/eslint-plugin-solid/blob/main/docs/style-prop.md",
|
|
},
|
|
fixable: "code",
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
styleProps: {
|
|
description: "an array of prop names to treat as a CSS style object",
|
|
default: ["style"],
|
|
type: "array",
|
|
items: {
|
|
type: "string",
|
|
},
|
|
minItems: 1,
|
|
uniqueItems: true,
|
|
},
|
|
allowString: {
|
|
description:
|
|
"if allowString is set to true, this rule will not convert a style string literal into a style object (not recommended for performance)",
|
|
type: "boolean",
|
|
default: false,
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
messages: {
|
|
kebabStyleProp: "Use {{ kebabName }} instead of {{ name }}.",
|
|
invalidStyleProp: "{{ name }} is not a valid CSS property.",
|
|
numericStyleValue:
|
|
'This CSS property value should be a string with a unit; Solid does not automatically append a "px" unit.',
|
|
stringStyle: "Use an object for the style prop instead of a string.",
|
|
},
|
|
},
|
|
defaultOptions: [],
|
|
create(context) {
|
|
const allCssPropertiesSet: Set<string> = new Set(allCssProperties);
|
|
const allowString = Boolean(context.options[0]?.allowString);
|
|
const styleProps = context.options[0]?.styleProps || ["style"];
|
|
|
|
return {
|
|
JSXAttribute(node) {
|
|
if (styleProps.indexOf(jsxPropName(node)) === -1) {
|
|
return;
|
|
}
|
|
const style =
|
|
node.value?.type === "JSXExpressionContainer" ? node.value.expression : node.value;
|
|
|
|
if (!style) {
|
|
return;
|
|
} else if (style.type === "Literal" && typeof style.value === "string" && !allowString) {
|
|
// Convert style="font-size: 10px" to style={{ "font-size": "10px" }}
|
|
let objectStyles: Record<string, string> | undefined;
|
|
try {
|
|
objectStyles = parse(style.value) ?? undefined;
|
|
} catch (e) {} // eslint-disable-line no-empty
|
|
|
|
context.report({
|
|
node: style,
|
|
messageId: "stringStyle",
|
|
// replace full prop value, wrap in JSXExpressionContainer, more fixes may be applied below
|
|
fix:
|
|
objectStyles &&
|
|
((fixer) => fixer.replaceText(node.value!, `{${JSON.stringify(objectStyles)}}`)),
|
|
});
|
|
} else if (style.type === "TemplateLiteral" && !allowString) {
|
|
context.report({
|
|
node: style,
|
|
messageId: "stringStyle",
|
|
});
|
|
} else if (style.type === "ObjectExpression") {
|
|
const properties = style.properties.filter(
|
|
(prop) => prop.type === "Property"
|
|
) as Array<T.Property>;
|
|
properties.forEach((prop) => {
|
|
const name: string | null = getPropertyName(prop, context.getScope());
|
|
if (name && !name.startsWith("--") && !allCssPropertiesSet.has(name)) {
|
|
const kebabName: string = kebabCase(name);
|
|
if (allCssPropertiesSet.has(kebabName)) {
|
|
// if it's not valid simply because it's camelCased instead of kebab-cased, provide a fix
|
|
context.report({
|
|
node: prop.key,
|
|
messageId: "kebabStyleProp",
|
|
data: { name, kebabName },
|
|
fix: (fixer) => fixer.replaceText(prop.key, `"${kebabName}"`), // wrap kebab name in quotes to be a valid object key
|
|
});
|
|
} else {
|
|
context.report({
|
|
node: prop.key,
|
|
messageId: "invalidStyleProp",
|
|
data: { name },
|
|
});
|
|
}
|
|
} else if (!name || (!name.startsWith("--") && lengthPercentageRegex.test(name))) {
|
|
// catches numeric values (ex. { "font-size": 12 }) for common <length-percentage> peroperties
|
|
// and suggests quoting or appending 'px'
|
|
const value: unknown = getStaticValue(prop.value)?.value;
|
|
if (typeof value === "number" && value !== 0) {
|
|
context.report({ node: prop.value, messageId: "numericStyleValue" });
|
|
}
|
|
}
|
|
});
|
|
}
|
|
},
|
|
};
|
|
},
|
|
});
|