Files
FrenoCorp/Lendair/Services/ClubService.swift
Michael Freno bc7bf124f5 Fix P0-P3 code review issues for clubs and challenges (FRE-4664)
P0: Fix variable shadowing in ClubService.createClub/updateClub and
    ChallengeService.createChallenge/updateChallenge — renamed local
    'var request' to 'var urlRequest' so JSONEncoder encodes the
    typed parameter, not the URLRequest.

P1: Wire CreateClubSheet and CreateChallengeSheet to parent ViewModel —
    sheets now receive viewModel and call createClub/createChallenge
    before dismissing.

P2: Extract HTTPMethod enum to shared Utils/HTTPMethod.swift (was
    defined in NotificationService). Remove dead 'body' parameter from
    buildRequest in all three services. Add error alert UI to
    ClubsView and ChallengesView.

P3: Replace forced URL unwrap with static let defaultBaseURL in all
    three services. Fix MockChallengeService.updateChallenge to track
    updateCalled instead of always throwing notFound.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-05-10 06:42:00 -04:00

178 lines
6.9 KiB
Swift

import Foundation
// MARK: - Service Protocol
protocol ClubServiceProtocol: Sendable {
func listClubs(filter: ClubFilter) async throws -> [Club]
func getClub(id: String) async throws -> (club: Club, members: [ClubMember])
func createClub(request: CreateClubRequest) async throws -> Club
func updateClub(id: String, request: UpdateClubRequest) async throws -> Club
func joinClub(id: String) async throws
func leaveClub(id: String) async throws
func inviteMember(clubId: String, email: String) async throws
func removeMember(clubId: String, memberId: String) async throws
}
// MARK: - Default Service
class ClubService: ClubServiceProtocol {
private let baseURL: URL
private let session: URLSession
private let authToken: String?
static let defaultBaseURL: URL = URL(string: "http://localhost:3000")!
init(
baseURL: URL = defaultBaseURL,
session: URLSession = .shared,
authToken: String? = nil
) {
self.baseURL = baseURL
self.session = session
self.authToken = authToken
}
func listClubs(filter: ClubFilter = ClubFilter()) async throws -> [Club] {
var components = URLComponents(url: baseURL.appendingPathComponent("/api/clubs"), resolvingAgainstBaseURL: true)!
var queryItems: [URLQueryItem] = [
URLQueryItem(name: "limit", value: String(filter.limit)),
URLQueryItem(name: "offset", value: String(filter.offset))
]
if let type = filter.clubType { queryItems.append(URLQueryItem(name: "type", value: type.rawValue)) }
if let privacy = filter.privacy { queryItems.append(URLQueryItem(name: "privacy", value: privacy.rawValue)) }
if let status = filter.membershipStatus { queryItems.append(URLQueryItem(name: "status", value: status.rawValue)) }
if let location = filter.location { queryItems.append(URLQueryItem(name: "location", value: location)) }
if let radius = filter.radiusKm { queryItems.append(URLQueryItem(name: "radius", value: String(radius))) }
components.queryItems = queryItems
let request = try buildRequest(url: components.url!)
let (data, response) = try await session.data(for: request)
try validateResponse(response)
let decoded = try JSONDecoder().decode(ClubListResponse.self, from: data)
return decoded.clubs
}
func getClub(id: String) async throws -> (club: Club, members: [ClubMember]) {
let url = baseURL.appendingPathComponent("/api/clubs/\(id)")
let request = try buildRequest(url: url)
let (data, response) = try await session.data(for: request)
try validateResponse(response)
let decoded = try JSONDecoder().decode(ClubDetailResponse.self, from: data)
return (decoded.club, decoded.members)
}
func createClub(request: CreateClubRequest) async throws -> Club {
let url = baseURL.appendingPathComponent("/api/clubs")
var urlRequest = try buildRequest(url: url, method: .post)
urlRequest.httpBody = try JSONEncoder().encode(request)
let (data, response) = try await session.data(for: urlRequest)
try validateResponse(response)
let decoded = try JSONDecoder().decode(CreateClubResponse.self, from: data)
return decoded.club
}
func updateClub(id: String, request: UpdateClubRequest) async throws -> Club {
let url = baseURL.appendingPathComponent("/api/clubs/\(id)")
var urlRequest = try buildRequest(url: url, method: .patch)
urlRequest.httpBody = try JSONEncoder().encode(request)
let (data, response) = try await session.data(for: urlRequest)
try validateResponse(response)
let decoded = try JSONDecoder().decode(UpdateClubResponse.self, from: data)
return decoded.club
}
func joinClub(id: String) async throws {
let url = baseURL.appendingPathComponent("/api/clubs/\(id)/join")
let request = try buildRequest(url: url, method: .post)
let (_, response) = try await session.data(for: request)
try validateResponse(response)
}
func leaveClub(id: String) async throws {
let url = baseURL.appendingPathComponent("/api/clubs/\(id)/leave")
let request = try buildRequest(url: url, method: .post)
let (_, response) = try await session.data(for: request)
try validateResponse(response)
}
func inviteMember(clubId: String, email: String) async throws {
let url = baseURL.appendingPathComponent("/api/clubs/\(clubId)/invite")
var request = try buildRequest(url: url, method: .post)
request.httpBody = try JSONEncoder().encode(["email": email])
let (_, response) = try await session.data(for: request)
try validateResponse(response)
}
func removeMember(clubId: String, memberId: String) async throws {
let url = baseURL.appendingPathComponent("/api/clubs/\(clubId)/members/\(memberId)")
let request = try buildRequest(url: url, method: .delete)
let (_, response) = try await session.data(for: request)
try validateResponse(response)
}
// MARK: - Helpers
private func buildRequest(url: URL, method: HTTPMethod = .get) throws -> URLRequest {
var request = URLRequest(url: url)
request.httpMethod = method.rawValue
request.setValue("application/json", forHTTPHeaderField: "Content-Type")
if let token = authToken {
request.setValue("Bearer \(token)", forHTTPHeaderField: "Authorization")
}
return request
}
private func validateResponse(_ response: URLResponse) throws {
guard let httpResponse = response as? HTTPURLResponse else {
throw ClubError.invalidResponse
}
guard (200...299).contains(httpResponse.statusCode) else {
switch httpResponse.statusCode {
case 401: throw ClubError.unauthorized
case 403: throw ClubError.forbidden
case 404: throw ClubError.notFound
case 429: throw ClubError.rateLimited
case 500...599: throw ClubError.serverError(httpResponse.statusCode)
default: throw ClubError.httpError(httpResponse.statusCode)
}
}
}
}
// MARK: - Error Types
enum ClubError: LocalizedError {
case invalidResponse
case unauthorized
case forbidden
case notFound
case rateLimited
case serverError(Int)
case httpError(Int)
var errorDescription: String {
switch self {
case .invalidResponse: return "Invalid server response"
case .unauthorized: return "Unauthorized — please log in again"
case .forbidden: return "Forbidden — check permissions"
case .notFound: return "Club not found"
case .rateLimited: return "Too many requests — try again shortly"
case .serverError(let code): return "Server error (\(code))"
case .httpError(let code): return "HTTP error (\(code))"
}
}
}