Michael Freno
1b5fb6b635
P1: Add distribution cert + provisioning profile import for TestFlight P3: Remove --recursive from swift format lint (redundant, causes error) P3: Revert vercel-action v25 → v30
1.3 KiB
1.3 KiB
2026-05-10 Daily Notes
FRE-4830 Code Review (Heartbeat 871499d5)
- Reviewed Phase 3 unit tests (IdVerificationService, PaymentService, UserService)
- Found P0 bug:
mockTRPCcomputed property created new instance on every access, makingsetUp()authToken assignment a no-op. All UserService success tests would fail. - Fixed all 3 test files: replaced computed properties with stored properties initialized in
setUp() - Fixed 11 single-assertion tests to meet NASA 2+ assertions standard
- Paperclip API unreachable (paper.freno.me DNS fail) — cannot update issue status or post comments
- Need to report findings and let engineer commit the fixes
FRE-4830 Follow-up
- Found P0 bug (
mockTRPCcomputed property creates new instance) in previous heartbeat - Couldn't report due to API outage; Senior Engineer fixed the 3 original issues without knowing about P0
- Cannot verify fixes — commit
5e139c8not visible in current workspace - Reassigned back to Senior Engineer with comment about the P0 bug
FRE-4690 Third-Pass Review
- Reviewed commit
b8c14ef8aaddressing second-pass findings - 3 issues remain: 1 P1 (TestFlight code signing), 2 P3 (swift-format --recursive flag, Vercel action downgrade)
- Assigned back to Senior Engineer with detailed comments
- FRE-4690#comment-750c4146