Commit Graph

8 Commits

Author SHA1 Message Date
Senior Engineer
ed83f29fe6 FRE-622: Senior Engineer code review - alerts and reporting automation verified
Review findings:
- All 4 features (Slack alerts, reports, cohorts, NPS) fully implemented
- 30+ tRPC endpoints with proper Zod validation
- Clean service layer separation (services → router → endpoints)
- Proper auth guards (protectedProcedure vs publicProcedure)
- Database schemas properly defined with foreign keys and type inference
- No new TypeScript errors introduced
- Alert cooldown logic, severity mapping, and Slack block formatting verified
- Cohort retention analysis and NPS calculation logic correct

Assigning to Security Reviewer for final review.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-04-28 23:43:37 -04:00
0cdb2e96b1 FRE-588: Complete tRPC/Clerk integration with database schema updates
- Updated router.ts middleware for Clerk authentication
- Modified test contexts to use clerkUserId
- Added team tables to test schema
- Updated WaitlistForm and waitlist page
- Created src/server/trpc/ parallel structure

All 258 tests pass. Ready for Security Reviewer.
2026-04-28 16:13:55 -04:00
55552fd79b FRE-4414: Unblock and update ShieldAI status
- Cleared cancelled blocker FRE-4428
- Updated to in_progress
- Added status comment documenting delegated work to CTO/CMO

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-04-28 14:25:30 -04:00
bc897f8845 Auto-commit 2026-04-27 19:13 2026-04-27 19:13:03 -04:00
0ff6c74871 FRE-709: Document duplicate recovery wake - FRE-635 already recovered via FRE-708 2026-04-26 20:23:14 -04:00
5f4eb60a98 FRE-651: CEO coordination notes for founder bio/headshot assets 2026-04-26 07:41:45 -04:00
ee7fb7ed12 FRE-603: Fix code review blockers (memory leak + auth security)
Blocker 1 - Memory Leak in Event Handlers:
- Store event handlers as class properties (arrow functions)
- Ensure initialize() and shutdown() use same references
- Prevents handler accumulation on reconnect cycles

Blocker 2 - Auth Token Security:
- Remove token from URL query parameters
- Send auth token via Yjs awareness state after connection
- Token no longer exposed in server/proxy logs or browser history

Files Modified:
- src/lib/collaboration/presence-manager.ts
- src/lib/collaboration/websocket-connection.ts

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-04-25 02:20:06 -04:00
7c684a42cc FRE-600: Fix code review blockers
- Consolidated duplicate UndoManagers to single instance
- Fixed connection promise to only resolve on 'connected' status
- Fixed WebSocketProvider import (WebsocketProvider)
- Added proper doc.destroy() cleanup
- Renamed isPresenceInitialized property to avoid conflict

Co-Authored-By: Paperclip <noreply@paperclip.ing>
2026-04-25 00:08:01 -04:00