3 Commits

Author	SHA1	Message	Date
Michael Freno	ad6b4c9c1c	fix: Address code review findings for NotificationsView (FRE-4737) ... - P0: Add default param to protocol list(params:) for compile fix - P1: Fix onDelete async closure, implement deletion logic - P2: Remove redundant objectWillChange.send() (Published handles it) - P2: Make RelativeDateTimeFormatter static singleton (per-row perf) - P3: Replace deprecated NavigationView with NavigationStack	2026-05-10 04:38:12 -04:00
Michael Freno	cb55ad95e2	Add notification badge count and MainTabView with notification tab FRE-4740 FRE-4739 ... - Add getUnreadCount() endpoint to NotificationsServiceProtocol - Add NotificationUnreadCountResponse model - Add badgeCount and fetchUnreadCount() to NotificationsViewModel - Update markAsRead/markAllAsRead to decrement badge count - Create MainTabView with Home, Challenges, Clubs, Notifications tabs - Add unread badge on notification tab using .badge() modifier - Support injected ViewModel in NotificationsView for shared state - Add badge count tests to NotificationServiceTests - Fetch unread count on app launch and tab switch Co-Authored-By: Paperclip <noreply@paperclip.ing>	2026-05-03 20:16:05 -04:00
Senior Engineer	57eb01f5af	FRE-4738: Implement mark-as-read and mark-all-read actions ... - Extract NotificationItem/NotificationType to Models/Notification.swift - Create NotificationsServiceProtocol with testable service layer - Implement markAsRead(id:) and markAllAsRead() with HTTP calls - Add NotificationError enum with localized descriptions - Update NotificationsViewModel to use protocol-based service - Add 18 unit tests (12 ViewModel + 6 Model) with mock service - Update README with architecture documentation	2026-05-03 12:17:15 -04:00