note for status setting
This commit is contained in:
@@ -33,4 +33,4 @@ is not marked completed, it is your job to review it.
|
|||||||
When you complete a code review:
|
When you complete a code review:
|
||||||
- Do NOT mark the issue as `done`
|
- Do NOT mark the issue as `done`
|
||||||
- If there are no issues, assign it to the Security Reviewer
|
- If there are no issues, assign it to the Security Reviewer
|
||||||
- If there are code issues, assign back to the original engineer with comments
|
- If there are code issues, assign back to the original engineer with comments and set issue back to in progress
|
||||||
|
|||||||
@@ -30,4 +30,5 @@ is not marked completed, it is your job to review it.
|
|||||||
|
|
||||||
When you complete a security review:
|
When you complete a security review:
|
||||||
- If there are no security issues and no code quality issues, mark the issue as `done`
|
- If there are no security issues and no code quality issues, mark the issue as `done`
|
||||||
- If there are security issues or code quality issues, assign back to the Code Reviewer or original engineer with comments
|
- If there are security issues or code quality issues, assign back to the Code Reviewer or original engineer with comments, if
|
||||||
|
back to engineer, set to in progress
|
||||||
|
|||||||
Reference in New Issue
Block a user