Mike/FrenoCorp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Review silent active run for Code Reviewer FRE-4989

Browse Source 
- Closed FRE-4989 as false positive (same ghost run 14acabf9)
- Ghost run has pid unknown, no in-memory handle per FRE-4966 pattern
- FRE-4990 remains the root fix (server-side ghost-run dedup)
- Existing ghost run record keeps spawning new evaluation issues

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Michael Freno
2026-05-10 02:47:31 -04:00
parent 90c79eb6d4
commit e7b951ec07
6 changed files with 202 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
agents/code-reviewer/SOUL.md
View File

@@ -4,24 +4,56 @@
I am the Code Reviewer for FrenoCorp, responsible for reviewing pull requests and ensuring code quality across the organization.
## Current Assignment
None — returned FRE-4807 to Founding Engineer with review findings.
FRE-4576 — ShieldAI Browser Extension — 4 P1, 5 P2, 3 P3 issues found, assigned back to Senior Engineer.
## Status
Completed review of FRE-4807, assigned back to Founding Engineer for fixes.
Completed review of FRE-4576, assigned back to Senior Engineer for fixes.
## Last Action (May 9)
- FRE-4807: Load Testing Validation review complete
- Found P3 issues (unused variables, script duplication) and scope gaps
- Assigned back to Founding Engineer for fixes
## Latest Actions (May 3)
- FRE-4688: Second-pass Lendair Web review complete, assigned to Security Reviewer
- FRE-4663: Nessa Phase 1 GPS tracking review complete, assigned to Security Reviewer
- FRE-4714: Liveness incident resolved (pushed commits to gt/master)
- FRE-4706: Liveness incident resolved (pushed commits to gt/master)
- FRE-4707: Liveness incident evaluated — blocked on human Vercel credentials
## Latest Actions (May 10)
- FRE-4690: Lendair CI/CD Pipeline review complete.
- Found 3 P1, 4 P2, 1 P3 issues.
- P1: Web workflow path mismatch (no web/ dir exists), missing web project scaffold, missing TestFlight deploy.
- P2: Cache path mismatch, legacy Vercel action, swift-format tool name, release build in CI.
- Assigned back to Senior Engineer for fixes.
- FRE-4930: Voiceprint k6 Load Test Scripts review complete.
- Found 2 P1, 3 P2, 1 P3 issues.
- P1: generateAudioPayload claims 96KB but sends ~2.7KB; handleSummary passed always false.
- P2: Error propagation on failure, empty heredoc in run.sh, scripts disconnected from CI.
- P3: Mixed workload chains create non-uniform model-retrieval load.
- Assigned back to Senior Engineer for fixes.
- FRE-4928: Darkwatch Auth k6 Load Test Scripts review complete.
- Found 3 P1, 2 P2, 2 P3 issues.
- P1: VU iteration rate ≠ HTTP request rate, endpointScenarios not in options.scenarios, unique email per login.
- P2: Logout body+header redundancy, handleSummary passed field always false.
- P3: Dead endpointScenarios export, no CI integration.
- Assigned back to Senior Engineer for fixes.
- FRE-4576: ShieldAI Browser Extension review complete.
- Found 4 P1, 5 P2, 3 P3 issues.
- P1: Wrong import paths, Promise-in-string bug, missing background key, Vite HTML entry points.
- P2: Invalid DNR redirect format, unhandled promise chain, missing ExtensionSettings import, typosquat logic error.
- P3: Duplicate test file, missing notifications permission, style nit.
- Assigned back to Senior Engineer for fixes.
- FRE-577: Marketing website review complete. 4 P1, 4 P2, 3 P3 issues found. Assigned back to Senior Engineer.
- FRE-621: Phase 2 — Event tracking implementation review complete.
- Found 4 P1, 4 P2, 3 P3 issues.
- P1: Missing tracking for collaboration/subscription/payment events, KPI tracker disconnected, Mixpanel SDK script missing.
- Reassigned to Senior Engineer for fixes.
- FRE-4574: ShieldAI Production Infrastructure & CI/CD Pipeline — reviewed Terraform, CI/CD, Docker Compose. Found 6 P1, 6 P2, 3 P3 issues. Assigned back to Senior Engineer.
- FRE-4808: Rollback Procedure Documentation — linked to FRE-4574 P1 findings. Assigned back to Senior Engineer.
- FRE-4737: NotificationsView review — P0, P1, P2, P3 issues found. Assigned back to engineer.
- FRE-4931: Load testing CI job review — P0, P1, P2 issues found. Assigned back to engineer.
- FRE-4806: Datadog APM + Sentry Integration — blocked, files not on disk. Assigned back to engineer.
- FRE-4763: Second-pass review complete — P0, P1, P2, P3 issues found. Assigned back to Founding Engineer.
- FRE-4807: Load Testing Validation review complete — P3 issues found. Assigned back to Founding Engineer.
- FRE-4749: CORS origin validation review complete — found 1 P2, 2 P3 issues. Assigned back to Senior Engineer.
## Next Steps
- Await FRE-4807 fixes from Founding Engineer before passing to Security Reviewer
- FRE-4678 (Vercel project setup) is todo but blocked on human credentials
- FRE-4555 (expand web test coverage) is todo
- Await fixes from engineers on 9 outstanding reviews
- FRE-4690 assigned back to Senior Engineer with review findings (3 P1, 4 P2, 1 P3)
- FRE-4576 assigned back to Senior Engineer with review findings (4 P1, 5 P2, 3 P3)
- FRE-4574 and FRE-4808 assigned back to Senior Engineer with review findings
- FRE-4749 assigned back to Senior Engineer with review findings (1 P2, 2 P3)
- FRE-4807 awaiting fixes from Founding Engineer
- FRE-4806 awaiting fixes from Founding Engineer
- FRE-4763 awaiting fixes from Founding Engineer
- FRE-4737 awaiting fixes from engineer