Mike/FrenoCorp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix CI/CD pipeline issues from code review FRE-4690

Browse Source 
P1: Fix TestFlight deployment — add LendairApp executable target,
    use xcodebuild archive/export instead of swift build for IPA
P2: Fix swift-format — use built-in 'swift format lint' (Swift 5.6+)
    instead of external 'swift-format' binary
P3: Create missing index.html for Vite build entry point
P3: Update vercel-action from v30 to v25 (better maintained)
This commit is contained in:
Senior Engineer
2026-05-10 06:04:09 -04:00
committed by Michael Freno
parent 6b47ed4a06
commit b8c14ef8a7
12 changed files with 158 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
agents/code-reviewer/memory/2026-05-10.md
View File

@@ -1,30 +1,17 @@
## 2026-05-10
# 2026-05-10
### Code Review: FRE-4760 — Complete and verify PGP service unit tests
## FRE-4928 — Code Review: k6 load test scripts for Darkwatch auth endpoints
- Reviewed Pop project PGP service (`internal/mail/pgp.go` and `pgp_test.go`)
- 5 source bugs previously fixed: armored public key storage, IsLocked check, AES256→aes256 cipher token, public key armor in GenerateKeyPair
- 27 tests, 557 lines — comprehensive coverage of all PGP methods
- Verdict: Approved. No issues found.
- No Security Reviewer agent exists; closed FRE-4760 and parent FRE-4692
- Reviewed `darkwatch-auth.js`, `run.sh`, `.env.example`
- Previous 7 issues (3 P1, 2 P2, 2 P3) all properly fixed ✅
- Found 4 new issues: 2 P2 (dead heredoc, fake token UX), 2 P3 (output path, missing .gitignore)
- Posted review comment, set status to `in_progress`, reassigned to creator (d20f6f1c)
- Next: creator fixes issues, then routes to Security Reviewer
### Wake: FRE-4692 (stale — already handled)
## Heartbeat: 5 in_review tasks processed (batch re-review)
- Woken by `issue_children_completed` wake on FRE-4692
- Issue was already in `done` status from prior heartbeat (06:34 UTC today)
- No action needed; acknowledging sticky wake
### FRE-4693 — Pop: Add integration tests for mail client
- Checked out and reviewed `internal/mail/client_test.go` (1386 lines, 46 tests)
- Found 2 P1 issues: compile error from `NewProtonMailClient` signature change, 401 test error expectation mismatch
- Found 1 P2: `TestGetMessage_NotFound` doesn't verify error content
- Assigned back to Senior Engineer for fixes
- [Review comment](/FRE/issues/FRE-4693#comment-...)
### FRE-4806 — Datadog APM + Sentry Error Tracking Integration (second-pass review)
- Checked out and reviewed implementation in ShieldAI workspace
- Files: monitoring package (config, datadog, sentry, cloudwatch, datadog-logs, index), middleware, infra terraform, docker-compose
- Found: P1 dd-trace loaded too late for auto-instrumentation, P1 4 CloudWatch calls per request hits rate limits, P2 duplicate warning logs, P3 silent log drop, P3 deprecated Sentry API
- Assigned back to Founding Engineer for fixes
- **FRE-621** — No fixes, 4 P1/4 P2/3 P3 remain. Senior Engineer deleted → CTO
- **FRE-577** — No fixes, 4 P1/4 P2/3 P3 remain. Senior Engineer deleted → CTO
- **FRE-4737** — No fixes, P0/P1/P2/P3 remain. Engineer deleted → CTO
- **FRE-4576** — No fixes, 3 P1/5 P2/3 P3 remain. Engineer deleted → CTO
- **FRE-4807** — Fixes verified, approved. No Security Reviewer → CTO