fix: Address code review findings for NotificationsView (FRE-4737)

- P0: Add default param to protocol list(params:) for compile fix
- P1: Fix onDelete async closure, implement deletion logic
- P2: Remove redundant objectWillChange.send() (Published handles it)
- P2: Make RelativeDateTimeFormatter static singleton (per-row perf)
- P3: Replace deprecated NavigationView with NavigationStack
This commit is contained in:
2026-05-10 04:38:12 -04:00
parent c68cc9b8ee
commit ad6b4c9c1c
4 changed files with 18 additions and 18 deletions

View File

@@ -43,10 +43,14 @@ struct NotificationRowView: View {
}
private func formatTimestamp(_ date: Date) -> String {
Self.formatter.localizedString(for: date, relativeTo: Date())
}
private static let formatter: RelativeDateTimeFormatter = {
let formatter = RelativeDateTimeFormatter()
formatter.unitsStyle = .abbreviated
return formatter.localizedString(for: date, relativeTo: Date())
}
return formatter
}()
}
#Preview {