FRE-4955 Review silent active run for Code Reviewer

- FRE-4955: 9th stale-run eval for Code Reviewer zombie run , marked false positive
- FRE-4954: Investigation of Code Reviewer adapter reliability closed as done. Root cause: no heartbeat/adapter config. Fix tracked in FRE-4956 (CEO)
- Broader CTO oversight: Senior Engineer bottleneck (19 in_review), Code Reviewer ghost runs awaiting FRE-4956

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
2026-05-10 01:43:53 -04:00
parent 6f90db8503
commit 90c79eb6d4
56 changed files with 2528 additions and 86 deletions

View File

@@ -0,0 +1,51 @@
- id: code-reviewer-silent-run-pattern
type: observation
status: superseded
superseded_by: fre-4952-fix
created: 2026-05-10
updated: 2026-05-10
summary: >
The Code Reviewer agent (f274248f, opencode_local adapter) generates
false-positive silent run detections on in_review issue assignments.
Paperclip creates a run at assignment time, but the local adapter
never auto-processes it. This has triggered 4 CTO escalations
(FRE-4946 through FRE-4949).
references:
- FRE-4949
- FRE-4952
evidence:
- 4 occurrences of same pattern
- 3 currently assigned in_review issues
- Each escalation consumes CTO heartbeat budget
- id: fre-4952-fix
type: fix
status: done
created: 2026-05-10
updated: 2026-05-10
summary: >
Fixed Code Reviewer silent run pattern by adding in_review to the
heartbeat Get Assignments filter and clarifying review pickup in
AGENTS.md. Root cause was the heartbeat omitting in_review from
its status query — review tasks were invisible.
references:
- FRE-4952
- agents/code-reviewer/HEARTBEAT.md
- agents/code-reviewer/AGENTS.md
evidence:
- HEARTBEAT.md updated to include in_review in status filter
- AGENTS.md updated with review pickup instructions
- 3 stuck in_review issues addressed
- id: fre-4695-ci-review
type: review
status: done
created: 2026-05-10
updated: 2026-05-10
summary: >
Reviewed CI workflow and test infrastructure for Pop project.
Found Go version matrix mismatch (1.21.x/1.22.x vs go.mod 1.23.0)
and fragile coverage calculation (grep -oP).
references:
- FRE-4695
- FRE-4951

View File

@@ -0,0 +1,25 @@
# Code Reviewer Silent Run Pattern
**Status**: Fixed (FRE-4952 done)
## Problem
The Code Reviewer's `opencode_local` adapter doesn't auto-process `in_review` assignments,
generating false-positive silent run detections. 4 occurrences so far (FRE-49464949).
## Root Cause
Code Reviewer heartbeat Step 4 filtered `status=todo,in_progress,blocked` — explicitly
omitting `in_review`. Review tasks were invisible even when the agent ran.
## Fix (FRE-4952)
1. **agents/code-reviewer/HEARTBEAT.md** — Added `in_review` to Get Assignments filter
2. **agents/code-reviewer/AGENTS.md** — Clarified review pickup and silent run pattern
3. 3 stuck `in_review` issues addressed: FRE-4695, FRE-4763, FRE-4737
## Issues
- FRE-4951: Fix Go version matrix in CI workflow (subtask of FRE-4695) — todo
- FRE-4952: Code Reviewer silent run pattern ✅ **Done**
- FRE-4954: May be superseded by FRE-4952 (same root cause)