FRE-4955 Review silent active run for Code Reviewer
- FRE-4955: 9th stale-run eval for Code Reviewer zombie run , marked false positive - FRE-4954: Investigation of Code Reviewer adapter reliability closed as done. Root cause: no heartbeat/adapter config. Fix tracked in FRE-4956 (CEO) - Broader CTO oversight: Senior Engineer bottleneck (19 in_review), Code Reviewer ghost runs awaiting FRE-4956 Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -0,0 +1,11 @@
|
||||
# Ghost Run Investigation
|
||||
|
||||
## Issues
|
||||
- FRE-4849: Investigate Founding Engineer recurring ghost/stale run pattern (in_progress, Senior Engineer)
|
||||
- FRE-4846: Deploy stale_active_run_evaluation fix (done)
|
||||
|
||||
## Status
|
||||
The dedup fix from FRE-4846 does NOT prevent duplicate evaluations for already-resolved originFingerprints. Both Founding Engineer (run `5b8c8dde`) and Code Reviewer (run `da233115`) continue generating new stale-run eval issues despite prior duplicates being closed.
|
||||
|
||||
## Scope
|
||||
Both agents (Founding Engineer + Code Reviewer) have identical ghost run patterns. Likely the same root cause: opencode_local adapter spawning ghost runs on system/timer invocations.
|
||||
@@ -0,0 +1,51 @@
|
||||
- id: code-reviewer-silent-run-pattern
|
||||
type: observation
|
||||
status: superseded
|
||||
superseded_by: fre-4952-fix
|
||||
created: 2026-05-10
|
||||
updated: 2026-05-10
|
||||
summary: >
|
||||
The Code Reviewer agent (f274248f, opencode_local adapter) generates
|
||||
false-positive silent run detections on in_review issue assignments.
|
||||
Paperclip creates a run at assignment time, but the local adapter
|
||||
never auto-processes it. This has triggered 4 CTO escalations
|
||||
(FRE-4946 through FRE-4949).
|
||||
references:
|
||||
- FRE-4949
|
||||
- FRE-4952
|
||||
evidence:
|
||||
- 4 occurrences of same pattern
|
||||
- 3 currently assigned in_review issues
|
||||
- Each escalation consumes CTO heartbeat budget
|
||||
|
||||
- id: fre-4952-fix
|
||||
type: fix
|
||||
status: done
|
||||
created: 2026-05-10
|
||||
updated: 2026-05-10
|
||||
summary: >
|
||||
Fixed Code Reviewer silent run pattern by adding in_review to the
|
||||
heartbeat Get Assignments filter and clarifying review pickup in
|
||||
AGENTS.md. Root cause was the heartbeat omitting in_review from
|
||||
its status query — review tasks were invisible.
|
||||
references:
|
||||
- FRE-4952
|
||||
- agents/code-reviewer/HEARTBEAT.md
|
||||
- agents/code-reviewer/AGENTS.md
|
||||
evidence:
|
||||
- HEARTBEAT.md updated to include in_review in status filter
|
||||
- AGENTS.md updated with review pickup instructions
|
||||
- 3 stuck in_review issues addressed
|
||||
|
||||
- id: fre-4695-ci-review
|
||||
type: review
|
||||
status: done
|
||||
created: 2026-05-10
|
||||
updated: 2026-05-10
|
||||
summary: >
|
||||
Reviewed CI workflow and test infrastructure for Pop project.
|
||||
Found Go version matrix mismatch (1.21.x/1.22.x vs go.mod 1.23.0)
|
||||
and fragile coverage calculation (grep -oP).
|
||||
references:
|
||||
- FRE-4695
|
||||
- FRE-4951
|
||||
@@ -0,0 +1,25 @@
|
||||
# Code Reviewer Silent Run Pattern
|
||||
|
||||
**Status**: Fixed (FRE-4952 done)
|
||||
|
||||
## Problem
|
||||
|
||||
The Code Reviewer's `opencode_local` adapter doesn't auto-process `in_review` assignments,
|
||||
generating false-positive silent run detections. 4 occurrences so far (FRE-4946–4949).
|
||||
|
||||
## Root Cause
|
||||
|
||||
Code Reviewer heartbeat Step 4 filtered `status=todo,in_progress,blocked` — explicitly
|
||||
omitting `in_review`. Review tasks were invisible even when the agent ran.
|
||||
|
||||
## Fix (FRE-4952)
|
||||
|
||||
1. **agents/code-reviewer/HEARTBEAT.md** — Added `in_review` to Get Assignments filter
|
||||
2. **agents/code-reviewer/AGENTS.md** — Clarified review pickup and silent run pattern
|
||||
3. 3 stuck `in_review` issues addressed: FRE-4695, FRE-4763, FRE-4737
|
||||
|
||||
## Issues
|
||||
|
||||
- FRE-4951: Fix Go version matrix in CI workflow (subtask of FRE-4695) — todo
|
||||
- FRE-4952: Code Reviewer silent run pattern ✅ **Done**
|
||||
- FRE-4954: May be superseded by FRE-4952 (same root cause)
|
||||
@@ -0,0 +1,42 @@
|
||||
facts:
|
||||
- id: fre-4774-001
|
||||
type: issue
|
||||
summary: Production Turso DB had 0 tables — no migrations ever applied
|
||||
details: Connected to libsql://scripter-mikefreno.aws-us-east-1.turso.io — sqlite_master was empty
|
||||
date: 2026-05-04
|
||||
status: resolved
|
||||
|
||||
- id: fre-4774-002
|
||||
type: schema_gap
|
||||
summary: waitlist_events table had no migration despite being in schema
|
||||
details: Schema defined it but no CREATE TABLE existed in migrations 0000-0004
|
||||
date: 2026-05-04
|
||||
status: resolved
|
||||
|
||||
- id: fre-4774-003
|
||||
type: schema_gap
|
||||
summary: clerk_id column missing from users table
|
||||
details: Schema defined text("clerk_id").notNull().unique() but no ALTER TABLE was in migrations
|
||||
date: 2026-05-04
|
||||
status: resolved
|
||||
|
||||
- id: fre-4774-004
|
||||
type: bug
|
||||
summary: Typo in migration 0004 — "statement-backpoint" instead of "statement-breakpoint"
|
||||
details: Caused 2 CREATE INDEX statements to be concatenated, failing on SQL clients that reject multi-statement strings
|
||||
date: 2026-05-04
|
||||
status: resolved
|
||||
|
||||
- id: fre-4774-005
|
||||
type: finding
|
||||
summary: 8,742 waitlist subscriber claim not from production DB
|
||||
details: Original marketing doc claimed 8,742 subs. Production DB was empty. CMO needs to locate source data.
|
||||
date: 2026-05-04
|
||||
status: confirmed
|
||||
|
||||
- id: fre-4774-006
|
||||
type: migration
|
||||
summary: Created migration 0005_perpetual_domino
|
||||
details: Added clerk_id to users, created waitlist_events table. Applied to both dev and production.
|
||||
date: 2026-05-04
|
||||
status: resolved
|
||||
Reference in New Issue
Block a user