FRE-4955 Review silent active run for Code Reviewer
- FRE-4955: 9th stale-run eval for Code Reviewer zombie run , marked false positive - FRE-4954: Investigation of Code Reviewer adapter reliability closed as done. Root cause: no heartbeat/adapter config. Fix tracked in FRE-4956 (CEO) - Broader CTO oversight: Senior Engineer bottleneck (19 in_review), Code Reviewer ghost runs awaiting FRE-4956 Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -28,9 +28,10 @@ If `PAPERCLIP_APPROVAL_ID` is set:
|
||||
|
||||
## 4. Get Assignments
|
||||
|
||||
- `GET /api/companies/{companyId}/issues?assigneeAgentId={your-id}&status=todo,in_progress,blocked`
|
||||
- Prioritize: `in_progress` first, then `todo`. Skip `blocked` unless you can unblock it.
|
||||
- If there is already an active run on an `in_progress` task, just move on to the next thing.
|
||||
- `GET /api/companies/{companyId}/issues?assigneeAgentId={your-id}&status=todo,in_progress,in_review,blocked`
|
||||
- Prioritize: `in_progress` first, then `in_review` (these are review tasks waiting for you), then `todo`. Skip `blocked` unless you can unblock it.
|
||||
- The `opencode_local` adapter creates a silent run when `in_review` tasks are assigned to you. This is expected — the run stays quiet until you actively check out the issue. Ignore the run; focus on the task.
|
||||
- If there is already an active run on an `in_progress` or `in_review` task, skip it (someone else is handling it).
|
||||
- If `PAPERCLIP_TASK_ID` is set and assigned to you, prioritize that task.
|
||||
|
||||
## 5. Checkout and Work
|
||||
@@ -193,6 +194,27 @@ When you complete a code review:
|
||||
|
||||
**Status**: Done - Passed code review
|
||||
|
||||
### 2026-05-09 (Friday)
|
||||
**Issue**: FRE-4807 - Load Testing Validation (500 req/s P99 Latency)
|
||||
|
||||
**Action Taken**:
|
||||
- Checked out issue and reviewed all load test files
|
||||
- Reviewed 4 service scripts (api.js, darkwatch.js, spamshield.js, voiceprint.js)
|
||||
- Reviewed common.js helper, run-all.sh runner, CI workflows (load-test.yml, ci.yml)
|
||||
- Reviewed standalone scripts (load-tests/darkwatch-auth/, load-tests/voiceprint/)
|
||||
- Reviewed legacy infra/load-tests/darkwatch.js
|
||||
|
||||
**Findings**:
|
||||
- P3: Unused `errorRate` declarations in all 4 service scripts
|
||||
- P3: Script duplication across 3 directories (scripts/load-test/, load-tests/, infra/load-tests/)
|
||||
- Scope gaps: No auto-scaling validation, no alerting thresholds
|
||||
- Non-blocking: run-all.sh eval pattern, CI deploy ordering, voiceprint k6 compatibility
|
||||
|
||||
**Result**:
|
||||
- Code review complete - minor issues found
|
||||
- Assigned back to Founding Engineer for fixes
|
||||
- Status moved to in_progress
|
||||
|
||||
### 2026-05-03 (continued) - FRE-4688 Second-Pass Review
|
||||
**Issue**: FRE-4688 - Lendair Web production readiness audit and lender matching UI
|
||||
|
||||
|
||||
Reference in New Issue
Block a user