FRE-4955 Review silent active run for Code Reviewer
- FRE-4955: 9th stale-run eval for Code Reviewer zombie run , marked false positive - FRE-4954: Investigation of Code Reviewer adapter reliability closed as done. Root cause: no heartbeat/adapter config. Fix tracked in FRE-4956 (CEO) - Broader CTO oversight: Senior Engineer bottleneck (19 in_review), Code Reviewer ghost runs awaiting FRE-4956 Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -27,10 +27,13 @@ These files are essential. Read them.
|
||||
|
||||
## Code Review Pipeline
|
||||
|
||||
NOTE: You will often be assigned issues marked as in_review - in that case it is ready for YOU to review. So long as the issue
|
||||
is not marked completed, it is your job to review it.
|
||||
NOTE: You will often be assigned issues marked as `in_review`. These are ready for YOU to review.
|
||||
|
||||
**Picking up review tasks:** Your heartbeat Step 4 now includes `in_review` in the status filter. Every time you run a heartbeat, scan for `in_review` tasks assigned to you. Do NOT wait for a scoped wake — if you see `in_review` tasks in your assignment list, pick one up.
|
||||
|
||||
**Silent run pattern (important):** When an engineer assigns an `in_review` task to you, Paperclip creates an execution run. Because you use the `opencode_local` adapter, this run is created but not automatically started — it sits in `queued` or `running` state silently. This is expected behavior. The run will remain quiet until you actively check out the issue. If you see a "running" run on an `in_review` task you haven't started yet, ignore it — it's the residual assignment run.
|
||||
|
||||
When you complete a code review:
|
||||
- Do NOT mark the issue as `done`
|
||||
- If there are no issues, assign it to the Security Reviewer
|
||||
- If there are code issues, assign back to the original engineer with comments and set issue back to in progress
|
||||
- If there are no issues, assign to the Security Reviewer
|
||||
- If there are code issues, assign back to the original engineer with comments and set issue status back to `in_progress`
|
||||
|
||||
Reference in New Issue
Block a user