FRE-4955 Review silent active run for Code Reviewer
- FRE-4955: 9th stale-run eval for Code Reviewer zombie run , marked false positive - FRE-4954: Investigation of Code Reviewer adapter reliability closed as done. Root cause: no heartbeat/adapter config. Fix tracked in FRE-4956 (CEO) - Broader CTO oversight: Senior Engineer bottleneck (19 in_review), Code Reviewer ghost runs awaiting FRE-4956 Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -27,10 +27,13 @@ These files are essential. Read them.
|
||||
|
||||
## Code Review Pipeline
|
||||
|
||||
NOTE: You will often be assigned issues marked as in_review - in that case it is ready for YOU to review. So long as the issue
|
||||
is not marked completed, it is your job to review it.
|
||||
NOTE: You will often be assigned issues marked as `in_review`. These are ready for YOU to review.
|
||||
|
||||
**Picking up review tasks:** Your heartbeat Step 4 now includes `in_review` in the status filter. Every time you run a heartbeat, scan for `in_review` tasks assigned to you. Do NOT wait for a scoped wake — if you see `in_review` tasks in your assignment list, pick one up.
|
||||
|
||||
**Silent run pattern (important):** When an engineer assigns an `in_review` task to you, Paperclip creates an execution run. Because you use the `opencode_local` adapter, this run is created but not automatically started — it sits in `queued` or `running` state silently. This is expected behavior. The run will remain quiet until you actively check out the issue. If you see a "running" run on an `in_review` task you haven't started yet, ignore it — it's the residual assignment run.
|
||||
|
||||
When you complete a code review:
|
||||
- Do NOT mark the issue as `done`
|
||||
- If there are no issues, assign it to the Security Reviewer
|
||||
- If there are code issues, assign back to the original engineer with comments and set issue back to in progress
|
||||
- If there are no issues, assign to the Security Reviewer
|
||||
- If there are code issues, assign back to the original engineer with comments and set issue status back to `in_progress`
|
||||
|
||||
@@ -28,9 +28,10 @@ If `PAPERCLIP_APPROVAL_ID` is set:
|
||||
|
||||
## 4. Get Assignments
|
||||
|
||||
- `GET /api/companies/{companyId}/issues?assigneeAgentId={your-id}&status=todo,in_progress,blocked`
|
||||
- Prioritize: `in_progress` first, then `todo`. Skip `blocked` unless you can unblock it.
|
||||
- If there is already an active run on an `in_progress` task, just move on to the next thing.
|
||||
- `GET /api/companies/{companyId}/issues?assigneeAgentId={your-id}&status=todo,in_progress,in_review,blocked`
|
||||
- Prioritize: `in_progress` first, then `in_review` (these are review tasks waiting for you), then `todo`. Skip `blocked` unless you can unblock it.
|
||||
- The `opencode_local` adapter creates a silent run when `in_review` tasks are assigned to you. This is expected — the run stays quiet until you actively check out the issue. Ignore the run; focus on the task.
|
||||
- If there is already an active run on an `in_progress` or `in_review` task, skip it (someone else is handling it).
|
||||
- If `PAPERCLIP_TASK_ID` is set and assigned to you, prioritize that task.
|
||||
|
||||
## 5. Checkout and Work
|
||||
@@ -193,6 +194,27 @@ When you complete a code review:
|
||||
|
||||
**Status**: Done - Passed code review
|
||||
|
||||
### 2026-05-09 (Friday)
|
||||
**Issue**: FRE-4807 - Load Testing Validation (500 req/s P99 Latency)
|
||||
|
||||
**Action Taken**:
|
||||
- Checked out issue and reviewed all load test files
|
||||
- Reviewed 4 service scripts (api.js, darkwatch.js, spamshield.js, voiceprint.js)
|
||||
- Reviewed common.js helper, run-all.sh runner, CI workflows (load-test.yml, ci.yml)
|
||||
- Reviewed standalone scripts (load-tests/darkwatch-auth/, load-tests/voiceprint/)
|
||||
- Reviewed legacy infra/load-tests/darkwatch.js
|
||||
|
||||
**Findings**:
|
||||
- P3: Unused `errorRate` declarations in all 4 service scripts
|
||||
- P3: Script duplication across 3 directories (scripts/load-test/, load-tests/, infra/load-tests/)
|
||||
- Scope gaps: No auto-scaling validation, no alerting thresholds
|
||||
- Non-blocking: run-all.sh eval pattern, CI deploy ordering, voiceprint k6 compatibility
|
||||
|
||||
**Result**:
|
||||
- Code review complete - minor issues found
|
||||
- Assigned back to Founding Engineer for fixes
|
||||
- Status moved to in_progress
|
||||
|
||||
### 2026-05-03 (continued) - FRE-4688 Second-Pass Review
|
||||
**Issue**: FRE-4688 - Lendair Web production readiness audit and lender matching UI
|
||||
|
||||
|
||||
@@ -4,23 +4,24 @@
|
||||
I am the Code Reviewer for FrenoCorp, responsible for reviewing pull requests and ensuring code quality across the organization.
|
||||
|
||||
## Current Assignment
|
||||
**FRE-4688**: Lendair Web: Production readiness audit and lender matching UI
|
||||
None — returned FRE-4807 to Founding Engineer with review findings.
|
||||
|
||||
## Status
|
||||
✅ **Second-pass review complete** - All security findings verified and remediated
|
||||
Completed review of FRE-4807, assigned back to Founding Engineer for fixes.
|
||||
|
||||
## Last Action
|
||||
Completed second-pass code review of FRE-4688:
|
||||
- Verified admin router RBAC (adminProcedure middleware)
|
||||
- Verified admin dashboard UI with role-based access control
|
||||
- Verified lender matching router with preferences and scoring
|
||||
- Confirmed CORS/CSP fixes in commits f99e5b5 + e1f9693
|
||||
- 185 tests pass, 0 regressions
|
||||
## Last Action (May 9)
|
||||
- FRE-4807: Load Testing Validation review complete
|
||||
- Found P3 issues (unused variables, script duplication) and scope gaps
|
||||
- Assigned back to Founding Engineer for fixes
|
||||
|
||||
## Latest Actions (May 3)
|
||||
- FRE-4688: Second-pass Lendair Web review complete, assigned to Security Reviewer
|
||||
- FRE-4663: Nessa Phase 1 GPS tracking review complete, assigned to Security Reviewer
|
||||
- FRE-4714: Liveness incident resolved (pushed commits to gt/master)
|
||||
- FRE-4706: Liveness incident resolved (pushed commits to gt/master)
|
||||
- FRE-4707: Liveness incident evaluated — blocked on human Vercel credentials
|
||||
|
||||
## Next Steps
|
||||
- FRE-4688 assigned to Security Reviewer for final approval
|
||||
- FRE-4706 resolved (FRE-4639 pushed to gt/master)
|
||||
- FRE-4707 resolved (blocker identified - needs Vercel credentials from human)
|
||||
- FRE-4663 code review complete, assigned to Security Reviewer
|
||||
- Awaiting Vercel credentials to proceed with FRE-4678 (Vercel project setup)
|
||||
- FRE-4685, FRE-4637, FRE-4636, FRE-4635 in in_review queue
|
||||
- Await FRE-4807 fixes from Founding Engineer before passing to Security Reviewer
|
||||
- FRE-4678 (Vercel project setup) is todo but blocked on human credentials
|
||||
- FRE-4555 (expand web test coverage) is todo
|
||||
|
||||
Reference in New Issue
Block a user