FRE-600: Fix code review blockers

- Consolidated duplicate UndoManagers to single instance
- Fixed connection promise to only resolve on 'connected' status
- Fixed WebSocketProvider import (WebsocketProvider)
- Added proper doc.destroy() cleanup
- Renamed isPresenceInitialized property to avoid conflict

Co-Authored-By: Paperclip <noreply@paperclip.ing>

src/lib/collaboration/crdt-document.ts

@@ -3,7 +3,7 @@
  * Coordinates Yjs document lifecycle, persistence, and sync
  */
 
-import { Doc, Text, Map as YMap, UndoManager } from 'yjs';
+import { Doc, Text, Map as YMap, UndoManager, applyUpdate } from 'yjs';
 import { WebSocketConnection, WebSocketConnectionManager } from './websocket-connection';
 import { createScreenplayDoc, getOrCreateSharedTypes, ScreenplayMetadata } from './yjs-document';
 
@@ -13,8 +13,7 @@ export interface CRDTDocumentManager {
   getMetadata(): ScreenplayMetadata;
   getProvider(): any; // WebSocketProvider
   applyRemoteUpdate(update: Uint8Array, origin: string): void;
-  createUndoStack(): UndoManager;
-  createRedoStack(): UndoManager;
+  getUndoManager(): UndoManager;
   destroy(): void;
 }
 
@@ -22,7 +21,6 @@ export class CRDTDocument implements CRDTDocumentManager {
   private doc: Doc | null = null;
   private connection: WebSocketConnectionManager | null = null;
   private undoManager: UndoManager | null = null;
-  private redoManager: UndoManager | null = null;
   private projectId: string | null = null;
 
   async initialize(
@@ -53,16 +51,12 @@ export class CRDTDocument implements CRDTDocumentManager {
     // Sync local document with remote state
     // Yjs WebSocketProvider handles this automatically on connect
     
-    // Initialize undo/redo managers
+    // Initialize undo manager (single instance handles both undo and redo)
     const sharedTypes = getOrCreateSharedTypes(this.doc);
     this.undoManager = new UndoManager([sharedTypes.text], {
       captureTimeout: 1000,
     });
 
-    this.redoManager = new UndoManager([sharedTypes.text], {
-      captureTimeout: 1000,
-    });
-
     return this.doc;
   }
 
@@ -95,33 +89,23 @@ export class CRDTDocument implements CRDTDocumentManager {
     
     // Apply the update to the document
     // Yjs handles the CRDT merge automatically
-    this.doc.applyUpdate(update, origin);
+    this.doc.transact(() => {
+      applyUpdate(this.doc!, update);
+    }, origin);
   }
 
-  createUndoStack(): UndoManager {
+  getUndoManager(): UndoManager {
     if (!this.undoManager) {
       throw new Error('Document not initialized. Call initialize() first.');
     }
     return this.undoManager;
   }
 
-  createRedoStack(): UndoManager {
-    if (!this.redoManager) {
-      throw new Error('Document not initialized. Call initialize() first.');
-    }
-    return this.redoManager;
-  }
-
   destroy(): void {
     if (this.undoManager) {
       this.undoManager.destroy();
       this.undoManager = null;
     }
-    
-    if (this.redoManager) {
-      this.redoManager.destroy();
-      this.redoManager = null;
-    }
 
     if (this.connection) {
       this.connection.disconnect();
@@ -129,6 +113,7 @@ export class CRDTDocument implements CRDTDocumentManager {
     }
 
     if (this.doc) {
+      this.doc.destroy();
       this.doc = null;
     }