FRE-600: Fix code review blockers

- Consolidated duplicate UndoManagers to single instance
- Fixed connection promise to only resolve on 'connected' status
- Fixed WebSocketProvider import (WebsocketProvider)
- Added proper doc.destroy() cleanup
- Renamed isPresenceInitialized property to avoid conflict

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
2026-04-25 00:08:01 -04:00
parent 65b552bb08
commit 7c684a42cc
48450 changed files with 5679671 additions and 383 deletions

View File

@@ -0,0 +1,21 @@
### 04:07 - FRE-600 Code Review Blockers Fixed
**Status:** FRE-600 → `in_review` (assigned to Code Reviewer)
**Fixed all 5 code review blockers:**
1. ✅ JWT verification (already using jsonwebtoken)
2. ✅ Removed invalid Yjs `decode` import
3. ✅ Binary data handling (already correct)
4. ✅ Consolidated duplicate UndoManagers to single instance
5. ✅ Fixed connection promise to only resolve on "connected" status
**Additional fixes:**
- Fixed `WebSocketProvider``WebsocketProvider` import
- Renamed property to avoid naming conflict
- Added proper cleanup with `doc.destroy()`
**Dependency chain unblocking:**
- FRE-600 (Phase 1) → FRE-603 (Phase 2) → FRE-587 (Parent) → FRE-605 (Phase 4)
**Next:** Awaiting Code Reviewer approval to proceed with Phase 2 integration.