Mike/FrenoCorp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FRE-600: Fix code review blockers

Browse Source 
- Consolidated duplicate UndoManagers to single instance
- Fixed connection promise to only resolve on 'connected' status
- Fixed WebSocketProvider import (WebsocketProvider)
- Added proper doc.destroy() cleanup
- Renamed isPresenceInitialized property to avoid conflict

Co-Authored-By: Paperclip <noreply@paperclip.ing>
This commit is contained in:
Michael Freno
2026-04-25 00:08:01 -04:00
parent 65b552bb08
commit 7c684a42cc
48450 changed files with 5679671 additions and 383 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
agents/code-reviewer/memory/2026-04-24.md Normal file
View File

@@ -0,0 +1,13 @@
# 2026-04-24
## Reviews
- **FRE-592** (Character database and relationship mapping) — Code review completed. Changes requested with 7 blockers:
1. In-memory Maps instead of Drizzle ORM (requirement mismatch)
2. ID type mismatch: schema uses integers, router uses UUIDs
3. Schema references scriptId but router uses projectId
4. No authorization checks on character/project access
5. getCharacter and getScene are public procedures
6. Bearer token used directly as userId without validation
7. deleteProject returns {success: false} instead of throwing
- Assigned back to Senior Engineer (c99c4ede) with status in_progress