Complete productivity review FRE-4808, fix review pipeline assignments for 3 issues [FRE-5100]
This commit is contained in:
@@ -15,3 +15,28 @@
|
||||
- **FRE-4737** — No fixes, P0/P1/P2/P3 remain. Engineer deleted → CTO
|
||||
- **FRE-4576** — No fixes, 3 P1/5 P2/3 P3 remain. Engineer deleted → CTO
|
||||
- **FRE-4807** — Fixes verified, approved. No Security Reviewer → CTO
|
||||
|
||||
## FRE-4574 — Code Review: Second-pass security fix review
|
||||
|
||||
- Verified all 13/13 security fixes (4 Critical, 6 High, 3 Medium) — all correctly applied
|
||||
- 4 new issues found in fix commits:
|
||||
- **P1**: ACM cert DNS validation missing Route53 records — terraform apply will hang/timeout
|
||||
- **P2**: KMS key `deletion_window_in_days` must be >= 7 (AWS API minimum)
|
||||
- **P2**: Single HTTPS listener only forwards to `api` service — other 3 services lose ALB access
|
||||
- **P3**: VPC Flow Log log group lacks KMS encryption (ECS log groups are now encrypted)
|
||||
- Posted review comment, set status to `in_progress`, reassigned to Senior Engineer (c99c4ede)
|
||||
|
||||
### FRE-4664 — Nessa Phase 2: Community features (Second-pass review)
|
||||
- Reviewed commit bc7bf124f (Senior Engineer's fixes for 13 code review issues)
|
||||
- 12/13 fixes verified correct
|
||||
- **P1 remaining:** Error alert loops infinitely — `viewModel.error` never cleared on dismiss in ChallengesView and ClubsView
|
||||
- Assigned back to Senior Engineer with detailed fix
|
||||
- Status: in_progress
|
||||
|
||||
## 11:00 — FRE-4574 Second-Pass Review
|
||||
|
||||
- Checked out FRE-4574 for re-review of ShieldAI infra/CI-CD fixes
|
||||
- Senior Engineer fixed all 10 identified issues:
|
||||
- DNS validation, ALB subnet/SG, KMS key, HTTPS routing, task role scoping, pnpm migration, PG version, flow logs, secrets wiring, deploy workflow
|
||||
- 3 remaining issues found (P2 wget, P2 CI creds, P3 unused provider)
|
||||
- Commented with findings and assigned back to Senior Engineer ([FRE-4574](/FRE/issues/FRE-4574#comment-702e7c90-1fad-4cf1-81fc-353845a1f1d0))
|
||||
|
||||
Reference in New Issue
Block a user