FRE-5186: CTO Recovery - FRE-5134 pipeline reassignment to Security Reviewer
FRE-5134 was approved by Code Reviewer but reassignment to Security Reviewer was never completed via API. FRE-5186 (recovery issue) resolved and FRE-5134 reassigned to Security Reviewer for security audit. - FRE-5186 marked DONE with recovery plan - FRE-5134 reassigned from Code Reviewer to Security Reviewer (036d6925-3aac-4939-a0f0-22dc44e618bc) - FRE-5134 status set to in_progress for security audit
This commit is contained in:
@@ -180,3 +180,60 @@ From 2026-05-10:
|
||||
- All child issues assigned and ready
|
||||
- CMO executing FRE-664 (Discord server)
|
||||
- CTO and CMO have remaining tasks
|
||||
|
||||
---
|
||||
|
||||
## FRE-4762: API Endpoint Path and HTTP Method Updates
|
||||
|
||||
### Work Completed
|
||||
|
||||
**Issue**: FRE-4762 (Fix API endpoint paths and HTTP methods to match ProtonMail contract)
|
||||
|
||||
**Context**: The pop CLI was using outdated API paths (`/api/messages`) and incorrect HTTP methods (POST for all operations). The official go-proton-api reference uses versioned paths (`/mail/v4/messages`) with proper REST methods.
|
||||
|
||||
### Changes Applied
|
||||
|
||||
**Files Modified:**
|
||||
- `/home/mike/code/pop/internal/mail/client.go`
|
||||
|
||||
**Endpoint Path Updates:**
|
||||
- `/api/messages` → `/mail/v4/messages`
|
||||
- `/api/messages/{id}` → `/mail/v4/messages/{id}`
|
||||
- `/api/messages/{id}/movetotrash` → `/mail/v4/messages/{id}/trash`
|
||||
- `/api/messages/{id}/delete` → `/mail/v4/messages/{id}` (DELETE method)
|
||||
- `/api/messages/{id}/send` → `/mail/v4/messages/{id}` (POST method)
|
||||
- `/api/messages/search` → `/mail/v4/messages/search`
|
||||
|
||||
**HTTP Method Updates:**
|
||||
- `ListMessages`: POST with `X-HTTP-Method-Override: GET` header
|
||||
- `GetMessage`: GET (was POST)
|
||||
- `MoveToTrash`: PUT (was POST)
|
||||
- `PermanentlyDelete`: DELETE (was POST)
|
||||
- `UpdateDraft`: PUT (was POST)
|
||||
- `Send`, `SaveDraft`, `SendDraft`, `SearchMessages`: POST (unchanged)
|
||||
|
||||
**Response Structure Updates:**
|
||||
- `GetMessage`: `{Data: {...}}` → `{Message: {...}}`
|
||||
- `SaveDraft`: `{Data: {MessageID: ...}}` → `{Message: {MessageID: ...}}`
|
||||
|
||||
### Git Commit
|
||||
|
||||
- Commit: `88c0587` - "FRE-4762: Update API endpoints to match ProtonMail v4 contract"
|
||||
|
||||
### Status Update
|
||||
|
||||
- **FRE-4762**: Moved to `in_review`
|
||||
- Assigned to: Code Reviewer ([@Code Reviewer](agent://f274248f-c47e-4f79-98ad-45919d951aa0))
|
||||
- Created request_confirmation interaction: `e275994a`
|
||||
- Next: Code Reviewer review → Security Reviewer → Done
|
||||
|
||||
### Reference
|
||||
|
||||
Based on [ProtonMail/go-proton-api](https://github.com/ProtonMail/go-proton-api) v4 contract cloned to `/tmp/opencode/go-proton-api`.
|
||||
|
||||
### Heartbeat Complete
|
||||
|
||||
**Final Status**: ✅ **FRE-4762** - **in_review** with Code Reviewer
|
||||
- Implementation complete
|
||||
- Git committed
|
||||
- Pending Code Reviewer approval
|
||||
|
||||
30
agents/founding-engineer/memory/2026-05-12.md
Normal file
30
agents/founding-engineer/memory/2026-05-12.md
Normal file
@@ -0,0 +1,30 @@
|
||||
|
||||
## Heartbeat: FRE-5134 Bug Fixes (Continuation)
|
||||
|
||||
### Context
|
||||
FRE-5134 was in `in_review` after previous implementation. Child issue FRE-5185 identified 2 compilation bugs that needed fixing.
|
||||
|
||||
### Bug Fixes Applied
|
||||
|
||||
**RaceDiscoveryService.swift** (318 → 306 lines):
|
||||
|
||||
1. **Removed unused `getUserCurrentLocation()` method** (lines 166-172)
|
||||
- Referenced non-existent `locationService` property
|
||||
- Method was never called but would cause compilation error
|
||||
|
||||
2. **Removed unused `LocationServiceProtocol`** (lines 311-313)
|
||||
- Protocol definition was orphaned after service simplification
|
||||
- No implementation exists in codebase
|
||||
|
||||
### Verification
|
||||
- All property mismatches with Race model were already fixed in previous heartbeat
|
||||
- Service is simplified and ready for Code Reviewer
|
||||
|
||||
### Status
|
||||
- **FRE-5134**: Still in `in_review`
|
||||
- Comment added: [12883efd](/FRE/comments/12883efd-76f6-426a-b1c8-f5fc51e9b7c2)
|
||||
- Pending confirmation interaction: e6ef5f47 (from previous heartbeat)
|
||||
|
||||
### Next Heartbeat
|
||||
- Wait for board/user confirmation on pending interaction
|
||||
- On approval, issue transitions to Code Reviewer
|
||||
Reference in New Issue
Block a user