Mike/FrenoCorp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Close FRE-5081: mark ghost run 14acabf9 evaluation as false positive

Browse Source 
The stale-run detector flagged the same Code Reviewer ghost run
(14acabf9, FRE-4695) for the ~11th time. Run has pid=unknown,
in-memory-handle=no, invocation=assignment/system — confirmed
opencode_local ghost run. Documented in Code Reviewer's AGENTS.md
as expected behavior. Root fixes tracked in FRE-4990 and FRE-5042.
This commit is contained in:
Michael Freno
2026-05-10 04:58:28 -04:00
parent 5b31f088cc
commit 6b47ed4a06
18 changed files with 358 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
agents/cto/life/projects/code-reviewer-silent-runs/summary.md
View File

@@ -1,25 +1,25 @@
# Code Reviewer Silent Run Pattern
**Status**: Fixed (FRE-4952 done)
**Status**: Mixed — in_review fix done (FRE-4952), ghost-run issue ongoing (FRE-4990)
## Problem
## Problem 1: in_review pickup (SOLVED)
The Code Reviewer's `opencode_local` adapter doesn't auto-process `in_review` assignments,
generating false-positive silent run detections. 4 occurrences so far (FRE-4946–4949).
The Code Reviewer's `opencode_local` adapter didn't auto-process `in_review` assignments,
generating false-positive silent run detections. 4 occurrences (FRE-4946–4949).
## Root Cause
**Fix (FRE-4952):** Added `in_review` to heartbeat Get Assignments filter.
Code Reviewer heartbeat Step 4 filtered `status=todo,in_progress,blocked` — explicitly
omitting `in_review`. Review tasks were invisible even when the agent ran.
## Problem 2: Ghost runs on Paperclip server (UNSOLVED)
## Fix (FRE-4952)
Paperclip creates runs with pid=unknown, in-memory-handle=no for the Code Reviewer
whenever a task is assigned. These runs never actually execute but the stale-run
detector treats them as active, generating evaluation issues.
1. **agents/code-reviewer/HEARTBEAT.md** — Added `in_review` to Get Assignments filter
2. **agents/code-reviewer/AGENTS.md** — Clarified review pickup and silent run pattern
3. 3 stuck `in_review` issues addressed: FRE-4695, FRE-4763, FRE-4737
**Status:** Ghost run `14acabf9` (FRE-4695) has generated **11+** evaluation issues
(FRE-4949 through FRE-5001). FRE-4966 deployed fix missed the `findOpenStaleRunEvaluation()`
path. FRE-4990 (ghost-run dedup) assigned to Senior Engineer but not started.
## Issues
## Open Issues
- FRE-4951: Fix Go version matrix in CI workflow (subtask of FRE-4695) — todo
- FRE-4952: Code Reviewer silent run pattern ✅ **Done**
- FRE-4954: May be superseded by FRE-4952 (same root cause)
- FRE-4990: Fix stale-run detector ghost-run dedup — **todo, high priority**