Close FRE-5081: mark ghost run 14acabf9 evaluation as false positive
The stale-run detector flagged the same Code Reviewer ghost run (14acabf9, FRE-4695) for the ~11th time. Run has pid=unknown, in-memory-handle=no, invocation=assignment/system — confirmed opencode_local ghost run. Documented in Code Reviewer's AGENTS.md as expected behavior. Root fixes tracked in FRE-4990 and FRE-5042.
This commit is contained in:
@@ -49,3 +49,55 @@
|
||||
references:
|
||||
- FRE-4695
|
||||
- FRE-4951
|
||||
|
||||
- id: ghost-run-14acabf9
|
||||
type: observation
|
||||
status: active
|
||||
created: 2026-05-10
|
||||
updated: 2026-05-10
|
||||
summary: >
|
||||
Ghost run 14acabf9 for Code Reviewer on FRE-4695 (Pop CI). Paperclip server
|
||||
created a run record but no process ever executed (pid=unknown, in-memory-handle=no).
|
||||
The stale-run detector has regenerated 11+ evaluation issues for this run,
|
||||
even after FRE-4966 was deployed to skip these exact metadata patterns.
|
||||
FRE-4990 tracks the root fix: cooldown mechanism and originFingerprint dedup.
|
||||
references:
|
||||
- FRE-4990
|
||||
- FRE-4966
|
||||
- FRE-5000
|
||||
- FRE-5001
|
||||
- server/src/services/recovery/service.ts
|
||||
evidence:
|
||||
- Same run 14acabf9 across 11+ evaluation issues
|
||||
- Created 2s after dismissal (FRE-5001 after FRE-5000)
|
||||
- FRE-4966 fix deployed but missed findOpenStaleRunEvaluation() path
|
||||
- Senior Engineer overloaded, FRE-4990 not started
|
||||
|
||||
- id: "ghost-run-14acabf9-closure-2026-05-10-hb3"
|
||||
created: "2026-05-10T07:25:00Z"
|
||||
status: superseded
|
||||
superseded_by: "ghost-run-14acabf9-closure-2026-05-10-hb4"
|
||||
type: observation
|
||||
summary: "FRE-5013 closed as false positive — 21st evaluation for same ghost run 14acabf9"
|
||||
detail: "Code Reviewer run on FRE-4695 (Pop CI test stage). Run started 2026-05-10T01:21:56, produced 1 output line at +11s, then went silent. Process metadata: pid unknown, in-memory handle no — confirmed ghost run. ~21 evaluations created by stale-run detector today, all closed as false positive."
|
||||
related_issues: ["FRE-5013", "FRE-5012", "FRE-5011", "FRE-4990", "FRE-4695"]
|
||||
next_action: "FRE-4990 (server-side dedup fix) is assigned to Junior Engineer, still todo. Nudged."
|
||||
|
||||
- id: "ghost-run-14acabf9-closure-2026-05-10-hb4"
|
||||
created: "2026-05-10T08:56:00Z"
|
||||
status: active
|
||||
type: observation
|
||||
summary: "FRE-5081 closed as false positive — ~30th evaluation for same ghost run 14acabf9"
|
||||
detail: "Same ghost run 14acabf9 (Code Reviewer on FRE-4695). Closed FRE-5081 as false positive. Run has pid=unknown, in-memory-handle=no, invocation=assignment/system — confirmed ghost run pattern for opencode_local adapter. This is approximately the 30th evaluation for this run. All previous (~10+) closed as false positive (FRE-5074 through FRE-5080)."
|
||||
related_issues: ["FRE-5081", "FRE-5080", "FRE-5079", "FRE-5078", "FRE-5077", "FRE-5076", "FRE-5075", "FRE-5074", "FRE-4990", "FRE-5042", "FRE-4695"]
|
||||
next_action: "Root fixes in progress: FRE-4990 (Junior Engineer, in_progress, server-side dedup), FRE-5042 (Founding Engineer, todo, exclusion logic). Both escalated to CEO. No further nudge this heartbeat."
|
||||
|
||||
- id: "fre-4990-nudge-2026-05-10"
|
||||
created: "2026-05-10T07:25:00Z"
|
||||
status: active
|
||||
type: action
|
||||
summary: "Nudged Junior Engineer on FRE-4990 (stale-run detector ghost-run dedup)"
|
||||
detail: "Posted comment asking for status on the server-side fix. Code at server/src/services/recovery/service.ts. Previous fix FRE-4966 was deployed but didn't prevent recurrence."
|
||||
actor: "CTO (f4390417)"
|
||||
target: "Junior Engineer (c302c2fc)"
|
||||
related_issues: ["FRE-4990", "FRE-4966"]
|
||||
|
||||
@@ -1,25 +1,25 @@
|
||||
# Code Reviewer Silent Run Pattern
|
||||
|
||||
**Status**: Fixed (FRE-4952 done)
|
||||
**Status**: Mixed — in_review fix done (FRE-4952), ghost-run issue ongoing (FRE-4990)
|
||||
|
||||
## Problem
|
||||
## Problem 1: in_review pickup (SOLVED)
|
||||
|
||||
The Code Reviewer's `opencode_local` adapter doesn't auto-process `in_review` assignments,
|
||||
generating false-positive silent run detections. 4 occurrences so far (FRE-4946–4949).
|
||||
The Code Reviewer's `opencode_local` adapter didn't auto-process `in_review` assignments,
|
||||
generating false-positive silent run detections. 4 occurrences (FRE-4946–4949).
|
||||
|
||||
## Root Cause
|
||||
**Fix (FRE-4952):** Added `in_review` to heartbeat Get Assignments filter.
|
||||
|
||||
Code Reviewer heartbeat Step 4 filtered `status=todo,in_progress,blocked` — explicitly
|
||||
omitting `in_review`. Review tasks were invisible even when the agent ran.
|
||||
## Problem 2: Ghost runs on Paperclip server (UNSOLVED)
|
||||
|
||||
## Fix (FRE-4952)
|
||||
Paperclip creates runs with pid=unknown, in-memory-handle=no for the Code Reviewer
|
||||
whenever a task is assigned. These runs never actually execute but the stale-run
|
||||
detector treats them as active, generating evaluation issues.
|
||||
|
||||
1. **agents/code-reviewer/HEARTBEAT.md** — Added `in_review` to Get Assignments filter
|
||||
2. **agents/code-reviewer/AGENTS.md** — Clarified review pickup and silent run pattern
|
||||
3. 3 stuck `in_review` issues addressed: FRE-4695, FRE-4763, FRE-4737
|
||||
**Status:** Ghost run `14acabf9` (FRE-4695) has generated **11+** evaluation issues
|
||||
(FRE-4949 through FRE-5001). FRE-4966 deployed fix missed the `findOpenStaleRunEvaluation()`
|
||||
path. FRE-4990 (ghost-run dedup) assigned to Senior Engineer but not started.
|
||||
|
||||
## Issues
|
||||
## Open Issues
|
||||
|
||||
- FRE-4951: Fix Go version matrix in CI workflow (subtask of FRE-4695) — todo
|
||||
- FRE-4952: Code Reviewer silent run pattern ✅ **Done**
|
||||
- FRE-4954: May be superseded by FRE-4952 (same root cause)
|
||||
- FRE-4990: Fix stale-run detector ghost-run dedup — **todo, high priority**
|
||||
|
||||
Reference in New Issue
Block a user