Close FRE-5081: mark ghost run 14acabf9 evaluation as false positive
The stale-run detector flagged the same Code Reviewer ghost run (14acabf9, FRE-4695) for the ~11th time. Run has pid=unknown, in-memory-handle=no, invocation=assignment/system — confirmed opencode_local ghost run. Documented in Code Reviewer's AGENTS.md as expected behavior. Root fixes tracked in FRE-4990 and FRE-5042.
This commit is contained in:
@@ -291,6 +291,50 @@ When you complete a code review:
|
||||
- Assigned back to Senior Engineer for fixes
|
||||
- Status moved to in_progress
|
||||
|
||||
### 2026-05-10 (Sunday) — FRE-4693 Review
|
||||
|
||||
**Issue**: FRE-4693 — Pop: Add integration tests for mail client
|
||||
|
||||
**Action Taken**:
|
||||
- Checked out orphaned in_review issue
|
||||
- Reviewed `internal/mail/client_test.go` (1386 lines, 46 tests)
|
||||
- Compared against source `client.go` and `api/client.go`
|
||||
|
||||
**Findings**:
|
||||
- P1: Compile error — `NewProtonMailClient(cfg)` uses old 1-arg signature, but commit `691a2ac` changed to 2-arg `(cfg, refresher)`. 5 call sites affected.
|
||||
- P1: `TestListMessages_APIError` — 401 triggers session refresh (new code), test expects `"invalid token"` but gets `"refresh failed"` error.
|
||||
- P2: `TestGetMessage_NotFound` — doesn't verify error content.
|
||||
|
||||
**Result**:
|
||||
- Code review complete — 2 P1, 1 P2 issues found
|
||||
- Assigned back to Senior Engineer for fixes
|
||||
- Status moved to in_progress
|
||||
|
||||
### 2026-05-10 (Sunday) — FRE-4665 Review
|
||||
|
||||
**Issue**: FRE-4665 — Nessa Phase 3: AI training plans and premium features
|
||||
|
||||
**Action Taken**:
|
||||
- Checked out orphaned `in_review` issue (previous reviewer agent removed)
|
||||
- Reviewed 26 files, 4464 lines added across Models, Services, ViewModels, Views
|
||||
- Verified architecture follows MVVM pattern consistent with Phase 1/2
|
||||
|
||||
**Findings**:
|
||||
- P1: 3 duplicate type declarations (MemberRole, InviteMemberResponse, RemoveMemberResponse) between FamilyPlan.swift and Club.swift — compile errors
|
||||
- P1: GeneratePlanSheet "Generate" button never calls viewModel (only dismisses)
|
||||
- P1: CreateEventSheet "Create" button never calls viewModel (only dismisses)
|
||||
- P1: InviteMemberSheet "Send Invite" never calls viewModel (only dismisses)
|
||||
- P1: Training plan follow toggle has empty set closure — not wired
|
||||
- P2: WorkoutSessionView creates isolated viewModel — parent state unaffected
|
||||
- P2: Placeholder coordinates/dates in CreateEventSheet
|
||||
- P3: fetchSavedRaces fetches all races then filters client-side
|
||||
- P3: No unit tests for Phase 3 features
|
||||
|
||||
**Result**:
|
||||
- Code review complete — 5 P1, 2 P2, 2 P3 issues found
|
||||
- Assigned back to Senior Engineer for fixes
|
||||
- Status moved to in_progress
|
||||
|
||||
### 2026-05-10 (Sunday) — FRE-4576 Review
|
||||
|
||||
**Issue**: FRE-4576 — ShieldAI Browser Extension (Phishing & Spam Protection)
|
||||
|
||||
Reference in New Issue
Block a user