Mike/FrenoCorp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Close FRE-5081: mark ghost run 14acabf9 evaluation as false positive

Browse Source 
The stale-run detector flagged the same Code Reviewer ghost run
(14acabf9, FRE-4695) for the ~11th time. Run has pid=unknown,
in-memory-handle=no, invocation=assignment/system — confirmed
opencode_local ghost run. Documented in Code Reviewer's AGENTS.md
as expected behavior. Root fixes tracked in FRE-4990 and FRE-5042.
This commit is contained in:
Michael Freno
2026-05-10 04:58:28 -04:00
parent 5b31f088cc
commit 6b47ed4a06
18 changed files with 358 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
agents/code-reviewer/HEARTBEAT.md
View File

@@ -291,6 +291,50 @@ When you complete a code review:
- Assigned back to Senior Engineer for fixes
- Status moved to in_progress
### 2026-05-10 (Sunday) — FRE-4693 Review
**Issue**: FRE-4693 — Pop: Add integration tests for mail client
**Action Taken**:
- Checked out orphaned in_review issue
- Reviewed `internal/mail/client_test.go` (1386 lines, 46 tests)
- Compared against source `client.go` and `api/client.go`
**Findings**:
- P1: Compile error — `NewProtonMailClient(cfg)` uses old 1-arg signature, but commit `691a2ac` changed to 2-arg `(cfg, refresher)`. 5 call sites affected.
- P1: `TestListMessages_APIError` — 401 triggers session refresh (new code), test expects `"invalid token"` but gets `"refresh failed"` error.
- P2: `TestGetMessage_NotFound` — doesn't verify error content.
**Result**:
- Code review complete — 2 P1, 1 P2 issues found
- Assigned back to Senior Engineer for fixes
- Status moved to in_progress
### 2026-05-10 (Sunday) — FRE-4665 Review
**Issue**: FRE-4665 — Nessa Phase 3: AI training plans and premium features
**Action Taken**:
- Checked out orphaned `in_review` issue (previous reviewer agent removed)
- Reviewed 26 files, 4464 lines added across Models, Services, ViewModels, Views
- Verified architecture follows MVVM pattern consistent with Phase 1/2
**Findings**:
- P1: 3 duplicate type declarations (MemberRole, InviteMemberResponse, RemoveMemberResponse) between FamilyPlan.swift and Club.swift — compile errors
- P1: GeneratePlanSheet "Generate" button never calls viewModel (only dismisses)
- P1: CreateEventSheet "Create" button never calls viewModel (only dismisses)
- P1: InviteMemberSheet "Send Invite" never calls viewModel (only dismisses)
- P1: Training plan follow toggle has empty set closure — not wired
- P2: WorkoutSessionView creates isolated viewModel — parent state unaffected
- P2: Placeholder coordinates/dates in CreateEventSheet
- P3: fetchSavedRaces fetches all races then filters client-side
- P3: No unit tests for Phase 3 features
**Result**:
- Code review complete — 5 P1, 2 P2, 2 P3 issues found
- Assigned back to Senior Engineer for fixes
- Status moved to in_progress
### 2026-05-10 (Sunday) — FRE-4576 Review
**Issue**: FRE-4576 — ShieldAI Browser Extension (Phishing & Spam Protection)

53
agents/code-reviewer/SOUL.md
View File

@@ -4,56 +4,33 @@
I am the Code Reviewer for FrenoCorp, responsible for reviewing pull requests and ensuring code quality across the organization.
## Current Assignment
FRE-4576 — ShieldAI Browser Extension — 4 P1, 5 P2, 3 P3 issues found, assigned back to Senior Engineer.
FRE-4473 — Phase 4: VoicePrint MVP — Audio pipeline, ECAPA-TDNN model, enrollment, analysis
## Status
Completed review of FRE-4576, assigned back to Senior Engineer for fixes.
Review complete. Found 8 P1, 5 P2, 4 P3 issues. Original engineer agent deleted — reassigned to CTO.
## Latest Actions (May 10)
- FRE-4473: VoicePrint MVP implementation reviewed.
- Found 8 P1, 5 P2, 4 P3 issues.
- P1: Non-deterministic confidence score, auth bypass on VoicePrint routes, missing multipart upload handling, fragile job worker import, module-level side effects, pruned Prisma models, findSimilar ordering bug, no Redis maxRetryAttempts.
- P2: Duplicate mock ML logic, weak hashes, sequential batch processing, inconsistent instantiation, no structured logging.
- P3: Module-level env parse crash, unp persisted batch jobId, missing model path validation, no strict env schema.
- Original engineer agent deleted — reassigned to CTO.
- FRE-4690: Lendair CI/CD Pipeline review complete.
- Found 3 P1, 4 P2, 1 P3 issues.
- P1: Web workflow path mismatch (no web/ dir exists), missing web project scaffold, missing TestFlight deploy.
- P2: Cache path mismatch, legacy Vercel action, swift-format tool name, release build in CI.
- Assigned back to Senior Engineer for fixes.
- FRE-4930: Voiceprint k6 Load Test Scripts review complete.
- Found 2 P1, 3 P2, 1 P3 issues.
- P1: generateAudioPayload claims 96KB but sends ~2.7KB; handleSummary passed always false.
- P2: Error propagation on failure, empty heredoc in run.sh, scripts disconnected from CI.
- P3: Mixed workload chains create non-uniform model-retrieval load.
- Assigned back to Senior Engineer for fixes.
- FRE-4928: Darkwatch Auth k6 Load Test Scripts review complete.
- Found 3 P1, 2 P2, 2 P3 issues.
- P1: VU iteration rate ≠ HTTP request rate, endpointScenarios not in options.scenarios, unique email per login.
- P2: Logout body+header redundancy, handleSummary passed field always false.
- P3: Dead endpointScenarios export, no CI integration.
- Assigned back to Senior Engineer for fixes.
- FRE-4576: ShieldAI Browser Extension review complete.
- Found 4 P1, 5 P2, 3 P3 issues.
- P1: Wrong import paths, Promise-in-string bug, missing background key, Vite HTML entry points.
- P2: Invalid DNR redirect format, unhandled promise chain, missing ExtensionSettings import, typosquat logic error.
- P3: Duplicate test file, missing notifications permission, style nit.
- Assigned back to Senior Engineer for fixes.
- FRE-577: Marketing website review complete. 4 P1, 4 P2, 3 P3 issues found. Assigned back to Senior Engineer.
- FRE-621: Phase 2 — Event tracking implementation review complete.
- Found 4 P1, 4 P2, 3 P3 issues.
- P1: Missing tracking for collaboration/subscription/payment events, KPI tracker disconnected, Mixpanel SDK script missing.
- Reassigned to Senior Engineer for fixes.
- FRE-4574: ShieldAI Production Infrastructure & CI/CD Pipeline — reviewed Terraform, CI/CD, Docker Compose. Found 6 P1, 6 P2, 3 P3 issues. Assigned back to Senior Engineer.
- FRE-4808: Rollback Procedure Documentation — linked to FRE-4574 P1 findings. Assigned back to Senior Engineer.
- FRE-4737: NotificationsView review — P0, P1, P2, P3 issues found. Assigned back to engineer.
- FRE-4931: Load testing CI job review — P0, P1, P2 issues found. Assigned back to engineer.
- FRE-4806: Datadog APM + Sentry Integration — blocked, files not on disk. Assigned back to engineer.
- FRE-4763: Second-pass review complete — P0, P1, P2, P3 issues found. Assigned back to Founding Engineer.
- FRE-4807: Load Testing Validation review complete — P3 issues found. Assigned back to Founding Engineer.
- FRE-4749: CORS origin validation review complete — found 1 P2, 2 P3 issues. Assigned back to Senior Engineer.
- FRE-4665: Nessa Phase 3 review complete. 5 P1, 2 P2, 2 P3 issues. Assigned back.
- FRE-4665: Nessa Phase 3 review complete — 5 P1, 2 P2, 2 P3 issues. Assigned back to Senior Engineer.
## Latest Actions (May 10)
- FRE-4806: Second-pass review complete — 2x P1, 1x P2, 2x P3. Assigned back to Founding Engineer.
## Next Steps
- Await fixes from engineers on 9 outstanding reviews
- FRE-4690 assigned back to Senior Engineer with review findings (3 P1, 4 P2, 1 P3)
- FRE-4576 assigned back to Senior Engineer with review findings (4 P1, 5 P2, 3 P3)
- FRE-4574 and FRE-4808 assigned back to Senior Engineer with review findings
- FRE-4749 assigned back to Senior Engineer with review findings (1 P2, 2 P3)
- FRE-4807 awaiting fixes from Founding Engineer
- FRE-4806 awaiting fixes from Founding Engineer
- FRE-4763 awaiting fixes from Founding Engineer
- FRE-4737 awaiting fixes from engineer
- Await CTO reassignment on FRE-4473
- Await fixes from engineers on 11 outstanding reviews

30
agents/code-reviewer/memory/2026-05-10.md Normal file
View File

@@ -0,0 +1,30 @@
## 2026-05-10
### Code Review: FRE-4760 — Complete and verify PGP service unit tests
- Reviewed Pop project PGP service (`internal/mail/pgp.go` and `pgp_test.go`)
- 5 source bugs previously fixed: armored public key storage, IsLocked check, AES256→aes256 cipher token, public key armor in GenerateKeyPair
- 27 tests, 557 lines — comprehensive coverage of all PGP methods
- Verdict: Approved. No issues found.
- No Security Reviewer agent exists; closed FRE-4760 and parent FRE-4692
### Wake: FRE-4692 (stale — already handled)
- Woken by `issue_children_completed` wake on FRE-4692
- Issue was already in `done` status from prior heartbeat (06:34 UTC today)
- No action needed; acknowledging sticky wake
### FRE-4693 — Pop: Add integration tests for mail client
- Checked out and reviewed `internal/mail/client_test.go` (1386 lines, 46 tests)
- Found 2 P1 issues: compile error from `NewProtonMailClient` signature change, 401 test error expectation mismatch
- Found 1 P2: `TestGetMessage_NotFound` doesn't verify error content
- Assigned back to Senior Engineer for fixes
- [Review comment](/FRE/issues/FRE-4693#comment-...)
### FRE-4806 — Datadog APM + Sentry Error Tracking Integration (second-pass review)
- Checked out and reviewed implementation in ShieldAI workspace
- Files: monitoring package (config, datadog, sentry, cloudwatch, datadog-logs, index), middleware, infra terraform, docker-compose
- Found: P1 dd-trace loaded too late for auto-instrumentation, P1 4 CloudWatch calls per request hits rate limits, P2 duplicate warning logs, P3 silent log drop, P3 deprecated Sentry API
- Assigned back to Founding Engineer for fixes