better unit check error

This commit is contained in:
Michael Freno
2025-11-14 22:49:08 -05:00
parent f35bb11770
commit 2504ae506e
3 changed files with 30 additions and 27 deletions

View File

@@ -348,19 +348,25 @@ function Element.new(props, deps)
------ add non-hereditary ------
--- self drawing---
self.border = props.border
and {
top = props.border.top or false,
right = props.border.right or false,
bottom = props.border.bottom or false,
left = props.border.left or false,
}
or {
-- Handle border (can be number or table)
if type(props.border) == "table" then
self.border = {
top = props.border.top or false,
right = props.border.right or false,
bottom = props.border.bottom or false,
left = props.border.left or false,
}
elseif props.border then
-- If border is a number or truthy value, keep it as-is
self.border = props.border
else
self.border = {
top = false,
right = false,
bottom = false,
left = false,
}
end
self.borderColor = props.borderColor or self._deps.Color.new(0, 0, 0, 1)
self.backgroundColor = props.backgroundColor or self._deps.Color.new(0, 0, 0, 0)

View File

@@ -29,6 +29,15 @@ function Units.parse(value)
return 0, "px"
end
-- Check for unit-only input (e.g., "px", "%", "vw" without a number)
local validUnits = { px = true, ["%"] = true, vw = true, vh = true, ew = true, eh = true }
if validUnits[value] then
if ErrorHandler then
ErrorHandler.error("Units", string.format("Missing numeric value before unit '%s'. Use format like '50%s' (e.g., '50px', '10%%', '2vw')", value, value))
end
return 0, "px"
end
-- Check for invalid format (space between number and unit)
if value:match("%d%s+%a") then
if ErrorHandler then
@@ -59,7 +68,7 @@ function Units.parse(value)
unit = "px"
end
local validUnits = { px = true, ["%"] = true, vw = true, vh = true, ew = true, eh = true }
-- validUnits is already defined at the top of the function
if not validUnits[unit] then
if ErrorHandler then
ErrorHandler.error("Units", string.format("Unknown unit '%s' in '%s'. Valid units: px, %%, vw, vh, ew, eh", unit, value))