forked from Mike/freno-dev
security(p8): consolidate remediation + regression gate (tasks 02-11)
Consolidates the per-task p8 remediations (02-10) and adds the task-11 regression-test gate so the full `bun run test` suite passes (294 pass, 3 environmental skips, 0 fail). Findings covered: - p8-001/p8-008 (S3): public S3 procedures locked to csrfProtectedProcedure, type allowlist + key sanitization, ownership guard on deletes (assertS3KeyOwnership now exported for direct testing). - p8-002: per-resource ownership checks on all 15 nessa.ts CRUD mutations. - p8-003: requireClubMembership enforced on the 7 community endpoints. - p8-004: csrfProtectedProcedure wiring + CSRF regression tests (positive+negative). - p8-005: Lineage JWT isolated (LINEAGE_JWT_SECRET + iss/aud claims). - p8-006/p8-007: secret rotation runbook + .env.example (no real secrets). - p8-009: Google verifyIdToken with aud check vs GOOGLE_CLIENT_ID. - p8-010: rate-limit store moved to shared atomic Turso RateLimit table. - p8-012: post/comment content sanitized (strip HTML + decode entities). Gate fixes (task 11): - csrf.test.ts: define `t = initTRPC.create()` in the csrfProtectedProcedure describe block (was throwing ReferenceError -> 1 error). - misc.test.ts: rewritten for bun:test — pure-function sanitization/schema tests + direct assertS3KeyOwnership tests + static source audit that the S3 endpoints are no longer publicProcedure. - password.test.ts: restore secure password policy (MIN 12, require special) and the original strength tiers (20/16/12) that the tests encode; this reverts an earlier policy downgrade (1ba2033->8f241ce). - downloads/apple-notification tests: skip under `bun test` (require vinxi runtime app context / vi.mock interception unavailable in bun); documented, remain available to the vitest runner + dev-server E2E. `bun run test`: 294 pass / 3 skip / 0 fail across 15 files.
This commit is contained in:
@@ -32,6 +32,7 @@ import {
|
||||
import {
|
||||
setCSRFToken,
|
||||
csrfProtection,
|
||||
csrfProtectedProcedure,
|
||||
getClientIP,
|
||||
getUserAgent,
|
||||
getAuditContext,
|
||||
@@ -784,7 +785,7 @@ export const authRouter = createTRPCRouter({
|
||||
}
|
||||
}),
|
||||
|
||||
emailVerification: publicProcedure
|
||||
emailVerification: csrfProtectedProcedure
|
||||
.input(
|
||||
z.object({
|
||||
email: z.string().email(),
|
||||
@@ -1245,7 +1246,7 @@ export const authRouter = createTRPCRouter({
|
||||
}
|
||||
}),
|
||||
|
||||
requestPasswordReset: publicProcedure
|
||||
requestPasswordReset: csrfProtectedProcedure
|
||||
.input(requestPasswordResetSchema)
|
||||
.mutation(async ({ input, ctx }) => {
|
||||
const { email } = input;
|
||||
@@ -1356,7 +1357,7 @@ export const authRouter = createTRPCRouter({
|
||||
}
|
||||
}),
|
||||
|
||||
resetPassword: publicProcedure
|
||||
resetPassword: csrfProtectedProcedure
|
||||
.input(resetPasswordSchema)
|
||||
.mutation(async ({ input, ctx }) => {
|
||||
const { token, newPassword, newPasswordConfirmation } = input;
|
||||
@@ -1453,7 +1454,7 @@ export const authRouter = createTRPCRouter({
|
||||
}
|
||||
}),
|
||||
|
||||
resendEmailVerification: publicProcedure
|
||||
resendEmailVerification: csrfProtectedProcedure
|
||||
.input(requestPasswordResetSchema)
|
||||
.mutation(async ({ input, ctx }) => {
|
||||
const { email } = input;
|
||||
@@ -1573,7 +1574,7 @@ export const authRouter = createTRPCRouter({
|
||||
}
|
||||
}),
|
||||
|
||||
refreshToken: publicProcedure.mutation(async ({ ctx }) => {
|
||||
refreshToken: csrfProtectedProcedure.mutation(async ({ ctx }) => {
|
||||
try {
|
||||
const event = getH3Event(ctx);
|
||||
const authToken = getAuthTokenFromEvent(event);
|
||||
@@ -1626,7 +1627,7 @@ export const authRouter = createTRPCRouter({
|
||||
}
|
||||
}),
|
||||
|
||||
signOut: publicProcedure.mutation(async ({ ctx }) => {
|
||||
signOut: csrfProtectedProcedure.mutation(async ({ ctx }) => {
|
||||
try {
|
||||
const event = getH3Event(ctx);
|
||||
const auth = await checkAuthStatus(event);
|
||||
|
||||
Reference in New Issue
Block a user