port: sync from Mike/pygienium@4e56b46d

tests/agent-runner.test.ts

@@ -10,12 +10,13 @@
 import { describe, expect, it } from "bun:test";
 import {
 	applySessionEvent,
+	emptySessionError,
 	type SessionEventAccumulator,
 } from "../src/agent-runner.js";
 import type { AgentSessionEvent } from "@oh-my-pi/pi-coding-agent";
 
 function fresh(): SessionEventAccumulator {
-	return { text: "" };
+	return { text: "", sawMessage: false };
 }
 
 /** Build a typed-as-unknown event so malformed shapes compile in tests. */
@@ -134,4 +135,54 @@ describe("applySessionEvent", () => {
 		expect(forwarded).toEqual([]);
 		expect(acc.text).toBe("x");
 	});
+
+	it("marks sawMessage when any message or tool event is observed", () => {
+		const fromUpdate = fresh();
+		applySessionEvent(fromUpdate, event({ type: "message_update" }));
+		expect(fromUpdate.sawMessage).toBe(true);
+
+		const fromEnd = fresh();
+		applySessionEvent(fromEnd, event({ type: "message_end", message: null }));
+		expect(fromEnd.sawMessage).toBe(true);
+
+		const fromTool = fresh();
+		applySessionEvent(fromTool, event({ type: "tool_execution_start" }));
+		expect(fromTool.sawMessage).toBe(true);
+	});
+});
+
+describe("emptySessionError", () => {
+	it("fails a session that settled with no text and no observed events", () => {
+		expect(emptySessionError({ text: "", sawMessage: false })).toContain(
+			"no output",
+		);
+	});
+
+	it("fails an empty session whose final message reported stopReason error", () => {
+		expect(
+			emptySessionError({ text: "", sawMessage: true, stopReason: "error" }),
+		).toBe("sub-agent session ended in error with no output.");
+	});
+
+	it("surfaces a recorded errorMessage regardless of text", () => {
+		expect(
+			emptySessionError({
+				text: "partial output",
+				sawMessage: true,
+				errorMessage: "upstream 529",
+			}),
+		).toBe("upstream 529");
+	});
+
+	it("accepts an empty-text session that demonstrably ran (tool activity)", () => {
+		expect(
+			emptySessionError({ text: "", sawMessage: true, stopReason: "end_turn" }),
+		).toBeUndefined();
+	});
+
+	it("accepts any session with text", () => {
+		expect(
+			emptySessionError({ text: "report", sawMessage: false }),
+		).toBeUndefined();
+	});
 });