Michael Freno
a524f23be2
The analytics page could not answer "how many downloads, of which
product". Three of the four download doors recorded nothing: the tRPC
click proxy only left the generic request row, whose path is the raw URL
with the asset buried in `?batch=1&input={"asset_name":...}`, and the S3
file route that serves Sparkle updates and the Nook app logged nothing
at all. The one door that did log (the Nook redirect) kept a private copy
of the logVisit/enrich/flush sequence, under its own path.
All doors now go through trackDownload, which writes one row per event
under /api/downloads/<asset> and flushes it inside the request — a click
is low-volume and serverless is not guaranteed to run the 30s batch
timer after the response. The file route maps its prefix allowlist to
asset keys, so a version bump stays one asset rather than one per
release. getAnalyticsSummary groups those rows into a downloads block and
the freno.me panel renders it under the overview cards.
History is recovered to the degree it exists: the Nook door's rows and
the tRPC clicks still carry enough to derive from (asset name in the URL).
scripts/backfill-downloads.ts inserts those derived rows with a
`backfill-<source id>` primary key and INSERT OR IGNORE, leaving the
originals untouched, so re-running is a no-op. Run against the live table
it added 66 rows: gaze 42, thenook 19, inputhalo 4, lineage 1.
Tests: new backfill suite (derivation, visitor detail carried over,
idempotency, empty history) and summariseDownloads cases; the Nook route
test now pins the canonical path, and the NOOK-337 allowlist audit reads
the map keys instead of quoted strings. Red-checked by stubbing the
downloads block back to zeros — the summary case fails, then passes.
Full suite matches master.
Co-Authored-By: nw-flash <noreply@nw-flash.local>
MISC-48
54 lines
2.1 KiB
TypeScript
54 lines
2.1 KiB
TypeScript
import type { APIEvent } from "@solidjs/start/server";
|
|
import { trackDownload } from "~/server/track-download";
|
|
import { resolveLatestDownload } from "./_download";
|
|
|
|
/**
|
|
* GET /api/the-nook/download
|
|
*
|
|
* The measured download door. Both hero buttons point here instead of
|
|
* resolving the appcast in the browser: this route resolves the latest
|
|
* release enclosure server-side, records the click through the shared
|
|
* analytics buffer, then 302s to the DMG.
|
|
*
|
|
* Why a redirect and not a direct S3 link: the appcast route and the DMG
|
|
* route never logged anything, so step 2 of the funnel (download click →
|
|
* DMG served) was invisible. Every click now lands one row in
|
|
* VisitorAnalytics under `/api/downloads/thenook`, alongside the clicks and
|
|
* served files of every other product — see `~/server/track-download`.
|
|
*
|
|
* Referrer, campaign tags, edge country (with `?c=` override) and user agent
|
|
* are read by `trackDownload`, which is shared with the other download doors.
|
|
*
|
|
* ONLY the handler is exported here: Vinxi's route tree-shake deletes
|
|
* exported declarations that are not in the router's `pick=` list, so a
|
|
* helper exported from this file would be removed while `GET` still
|
|
* referenced it. All resolution helpers live in `./_download.ts`.
|
|
*/
|
|
|
|
export async function GET(event: APIEvent): Promise<Response> {
|
|
// Recorded before resolving: a click that dies at resolution is exactly the
|
|
// failure the funnel needs to show.
|
|
await trackDownload(event, "thenook");
|
|
|
|
let target: string | null = null;
|
|
try {
|
|
target = await resolveLatestDownload();
|
|
} catch (error) {
|
|
console.error("Failed to resolve Nook download:", error);
|
|
}
|
|
|
|
if (!target) {
|
|
return new Response("Download unavailable", {
|
|
status: 503,
|
|
headers: { "Content-Type": "text/plain", "Cache-Control": "no-store" }
|
|
});
|
|
}
|
|
|
|
// No-store is load-bearing: a cached 302 would serve later clicks without
|
|
// ever reaching this handler, silently dropping them from the funnel.
|
|
return new Response(null, {
|
|
status: 302,
|
|
headers: { Location: target, "Cache-Control": "no-store" }
|
|
});
|
|
}
|