Commit Graph

18 Commits

Author SHA1 Message Date
898c891bd5 chore: remediate pygienium audit findings
Dead code: 77 verified-unused exports, files (BackArrow, MenuBars,
cookies.ts, db/create.ts, schemas/comment.ts, security-headers.ts) and
12 unused dependencies removed
Comments: ~370 RESTATE comments stripped across 53 files; 2 verbose
blocks tightened; dead commented-out config removed
Complexity: bulkUpsert extracted into 11 per-entity helpers (CCN 156->~10);
login formHandler split into 3 submitters (CCN 63->~5); account page render
split into 8 section components (CCN 40); updatePost SQL builder rebuilt;
assert*Owned consolidated behind generic assertOwnedBy
Defensive guards: 4 redundant rethrow/nullish guards removed
2026-08-11 13:36:18 -04:00
ff956be80f security(p8): consolidate remediation + regression gate (tasks 02-11)
Consolidates the per-task p8 remediations (02-10) and adds the task-11
regression-test gate so the full `bun run test` suite passes (294 pass,
3 environmental skips, 0 fail).

Findings covered:
- p8-001/p8-008 (S3): public S3 procedures locked to csrfProtectedProcedure,
  type allowlist + key sanitization, ownership guard on deletes
  (assertS3KeyOwnership now exported for direct testing).
- p8-002: per-resource ownership checks on all 15 nessa.ts CRUD mutations.
- p8-003: requireClubMembership enforced on the 7 community endpoints.
- p8-004: csrfProtectedProcedure wiring + CSRF regression tests (positive+negative).
- p8-005: Lineage JWT isolated (LINEAGE_JWT_SECRET + iss/aud claims).
- p8-006/p8-007: secret rotation runbook + .env.example (no real secrets).
- p8-009: Google verifyIdToken with aud check vs GOOGLE_CLIENT_ID.
- p8-010: rate-limit store moved to shared atomic Turso RateLimit table.
- p8-012: post/comment content sanitized (strip HTML + decode entities).

Gate fixes (task 11):
- csrf.test.ts: define `t = initTRPC.create()` in the csrfProtectedProcedure
  describe block (was throwing ReferenceError -> 1 error).
- misc.test.ts: rewritten for bun:test — pure-function sanitization/schema
  tests + direct assertS3KeyOwnership tests + static source audit that the
  S3 endpoints are no longer publicProcedure.
- password.test.ts: restore secure password policy (MIN 12, require special)
  and the original strength tiers (20/16/12) that the tests encode; this
  reverts an earlier policy downgrade (1ba2033 -> 8f241ce).
- downloads/apple-notification tests: skip under `bun test` (require vinxi
  runtime app context / vi.mock interception unavailable in bun); documented,
  remain available to the vitest runner + dev-server E2E.

`bun run test`: 294 pass / 3 skip / 0 fail across 15 files.
2026-07-22 20:21:25 -04:00
58d48dac70 checkpoint 2026-01-21 12:22:19 -05:00
99e5323871 fix: should fix issues with login/session handling 2026-01-11 20:18:01 -05:00
9fc0a73fea general: hot path cooldown 2026-01-11 14:24:28 -05:00
1fb8f45705 fix: session validation fixes 2026-01-11 11:23:32 -05:00
8f241ce611 adjust email/pass addition flow, blog ttl extended 2026-01-07 21:21:27 -05:00
fa28266bad revert bundle change 2026-01-07 20:34:23 -05:00
f056cf05d3 hopeful 2026-01-07 20:19:26 -05:00
0a0c0e313e migrated 2026-01-07 16:22:31 -05:00
5e247e54cb fix rate limit async issue, kill old code 2026-01-06 23:52:51 -05:00
7e89e6dda2 removed excess comments 2026-01-04 11:14:54 -05:00
53a4ae1a43 oh baby boy 2025-12-26 13:41:50 -05:00
8ca8e6f712 remove excess comments 2025-12-23 10:30:51 -05:00
ee9db9f674 undone 2025-12-19 22:41:13 -05:00
3e606d2354 client->server stuff, nav on mobile improvements 2025-12-19 20:35:21 -05:00
8f4fac422b almost done 2025-12-19 14:04:32 -05:00
81969ae907 migrating 2025-12-17 00:23:13 -05:00