security(p8): consolidate remediation + regression gate (tasks 02-11)

Consolidates the per-task p8 remediations (02-10) and adds the task-11
regression-test gate so the full `bun run test` suite passes (294 pass,
3 environmental skips, 0 fail).

Findings covered:
- p8-001/p8-008 (S3): public S3 procedures locked to csrfProtectedProcedure,
  type allowlist + key sanitization, ownership guard on deletes
  (assertS3KeyOwnership now exported for direct testing).
- p8-002: per-resource ownership checks on all 15 nessa.ts CRUD mutations.
- p8-003: requireClubMembership enforced on the 7 community endpoints.
- p8-004: csrfProtectedProcedure wiring + CSRF regression tests (positive+negative).
- p8-005: Lineage JWT isolated (LINEAGE_JWT_SECRET + iss/aud claims).
- p8-006/p8-007: secret rotation runbook + .env.example (no real secrets).
- p8-009: Google verifyIdToken with aud check vs GOOGLE_CLIENT_ID.
- p8-010: rate-limit store moved to shared atomic Turso RateLimit table.
- p8-012: post/comment content sanitized (strip HTML + decode entities).

Gate fixes (task 11):
- csrf.test.ts: define `t = initTRPC.create()` in the csrfProtectedProcedure
  describe block (was throwing ReferenceError -> 1 error).
- misc.test.ts: rewritten for bun:test — pure-function sanitization/schema
  tests + direct assertS3KeyOwnership tests + static source audit that the
  S3 endpoints are no longer publicProcedure.
- password.test.ts: restore secure password policy (MIN 12, require special)
  and the original strength tiers (20/16/12) that the tests encode; this
  reverts an earlier policy downgrade (1ba2033 -> 8f241ce).
- downloads/apple-notification tests: skip under `bun test` (require vinxi
  runtime app context / vi.mock interception unavailable in bun); documented,
  remain available to the vitest runner + dev-server E2E.

`bun run test`: 294 pass / 3 skip / 0 fail across 15 files.
This commit is contained in:
2026-07-22 20:21:25 -04:00
parent e446eb1775
commit ff956be80f
29 changed files with 2008 additions and 365 deletions

View File

@@ -1,4 +1,4 @@
import { createTRPCRouter, publicProcedure } from "../utils";
import { createTRPCRouter, publicProcedure, csrfProtectedProcedure } from "../utils";
import { TRPCError } from "@trpc/server";
import { ConnectionFactory, hashPassword, checkPassword } from "~/server/utils";
import type { User } from "~/db/types";
@@ -45,7 +45,7 @@ export const userRouter = createTRPCRouter({
return toUserProfile(user);
}),
updateEmail: publicProcedure
updateEmail: csrfProtectedProcedure
.input(updateEmailSchema)
.mutation(async ({ input, ctx }) => {
const userId = ctx.userId;
@@ -75,7 +75,7 @@ export const userRouter = createTRPCRouter({
return toUserProfile(user);
}),
updateDisplayName: publicProcedure
updateDisplayName: csrfProtectedProcedure
.input(updateDisplayNameSchema)
.mutation(async ({ input, ctx }) => {
const userId = ctx.userId;
@@ -104,7 +104,7 @@ export const userRouter = createTRPCRouter({
return toUserProfile(user);
}),
updateProfileImage: publicProcedure
updateProfileImage: csrfProtectedProcedure
.input(updateProfileImageSchema)
.mutation(async ({ input, ctx }) => {
const userId = ctx.userId;
@@ -133,7 +133,7 @@ export const userRouter = createTRPCRouter({
return toUserProfile(user);
}),
changePassword: publicProcedure
changePassword: csrfProtectedProcedure
.input(changePasswordSchema)
.mutation(async ({ input, ctx }) => {
const userId = ctx.userId;
@@ -197,7 +197,7 @@ export const userRouter = createTRPCRouter({
return { success: true, message: "success" };
}),
setPassword: publicProcedure
setPassword: csrfProtectedProcedure
.input(setPasswordSchema)
.mutation(async ({ input, ctx }) => {
const userId = ctx.userId;
@@ -300,7 +300,7 @@ export const userRouter = createTRPCRouter({
return { success: true, message: "success" };
}),
deleteAccount: publicProcedure
deleteAccount: csrfProtectedProcedure
.input(deleteAccountSchema)
.mutation(async ({ input, ctx }) => {
const userId = ctx.userId;
@@ -382,7 +382,7 @@ export const userRouter = createTRPCRouter({
}));
}),
unlinkProvider: publicProcedure
unlinkProvider: csrfProtectedProcedure
.input(
z.object({
provider: z.enum(["email", "google", "github"])