security(p8): consolidate remediation + regression gate (tasks 02-11)

Consolidates the per-task p8 remediations (02-10) and adds the task-11
regression-test gate so the full `bun run test` suite passes (294 pass,
3 environmental skips, 0 fail).

Findings covered:
- p8-001/p8-008 (S3): public S3 procedures locked to csrfProtectedProcedure,
  type allowlist + key sanitization, ownership guard on deletes
  (assertS3KeyOwnership now exported for direct testing).
- p8-002: per-resource ownership checks on all 15 nessa.ts CRUD mutations.
- p8-003: requireClubMembership enforced on the 7 community endpoints.
- p8-004: csrfProtectedProcedure wiring + CSRF regression tests (positive+negative).
- p8-005: Lineage JWT isolated (LINEAGE_JWT_SECRET + iss/aud claims).
- p8-006/p8-007: secret rotation runbook + .env.example (no real secrets).
- p8-009: Google verifyIdToken with aud check vs GOOGLE_CLIENT_ID.
- p8-010: rate-limit store moved to shared atomic Turso RateLimit table.
- p8-012: post/comment content sanitized (strip HTML + decode entities).

Gate fixes (task 11):
- csrf.test.ts: define `t = initTRPC.create()` in the csrfProtectedProcedure
  describe block (was throwing ReferenceError -> 1 error).
- misc.test.ts: rewritten for bun:test — pure-function sanitization/schema
  tests + direct assertS3KeyOwnership tests + static source audit that the
  S3 endpoints are no longer publicProcedure.
- password.test.ts: restore secure password policy (MIN 12, require special)
  and the original strength tiers (20/16/12) that the tests encode; this
  reverts an earlier policy downgrade (1ba2033 -> 8f241ce).
- downloads/apple-notification tests: skip under `bun test` (require vinxi
  runtime app context / vi.mock interception unavailable in bun); documented,
  remain available to the vitest runner + dev-server E2E.

`bun run test`: 294 pass / 3 skip / 0 fail across 15 files.
This commit is contained in:
2026-07-22 20:21:25 -04:00
parent e446eb1775
commit ff956be80f
29 changed files with 2008 additions and 365 deletions

View File

@@ -1,7 +1,8 @@
import {
createTRPCRouter,
publicProcedure,
protectedProcedure
protectedProcedure,
csrfProtectedProcedure
} from "../utils";
import { z } from "zod";
import { ConnectionFactory } from "~/server/utils";
@@ -57,7 +58,7 @@ export const databaseRouter = createTRPCRouter({
}
}),
addCommentReaction: publicProcedure
addCommentReaction: csrfProtectedProcedure
.input(toggleCommentReactionMutationSchema)
.mutation(async ({ input }) => {
try {
@@ -86,7 +87,7 @@ export const databaseRouter = createTRPCRouter({
}
}),
removeCommentReaction: publicProcedure
removeCommentReaction: csrfProtectedProcedure
.input(toggleCommentReactionMutationSchema)
.mutation(async ({ input }) => {
try {
@@ -134,7 +135,7 @@ export const databaseRouter = createTRPCRouter({
}
}),
deleteComment: protectedProcedure
deleteComment: csrfProtectedProcedure
.input(deleteCommentWithTypeSchema)
.mutation(async ({ input, ctx }) => {
try {
@@ -363,7 +364,7 @@ export const databaseRouter = createTRPCRouter({
);
}),
createPost: publicProcedure
createPost: csrfProtectedProcedure
.input(
z.object({
category: z.literal("blog"),
@@ -426,7 +427,7 @@ export const databaseRouter = createTRPCRouter({
}
}),
updatePost: publicProcedure
updatePost: csrfProtectedProcedure
.input(
z.object({
id: z.number(),
@@ -545,7 +546,7 @@ export const databaseRouter = createTRPCRouter({
}
}),
deletePost: publicProcedure.input(idSchema).mutation(async ({ input }) => {
deletePost: csrfProtectedProcedure.input(idSchema).mutation(async ({ input }) => {
try {
const conn = ConnectionFactory();
@@ -581,7 +582,7 @@ export const databaseRouter = createTRPCRouter({
}
}),
addPostLike: publicProcedure
addPostLike: csrfProtectedProcedure
.input(togglePostLikeMutationSchema)
.mutation(async ({ input }) => {
try {
@@ -607,7 +608,7 @@ export const databaseRouter = createTRPCRouter({
}
}),
removePostLike: publicProcedure
removePostLike: csrfProtectedProcedure
.input(togglePostLikeMutationSchema)
.mutation(async ({ input }) => {
try {
@@ -716,7 +717,7 @@ export const databaseRouter = createTRPCRouter({
}
}),
updateUserImage: publicProcedure
updateUserImage: csrfProtectedProcedure
.input(updateUserImageSchema)
.mutation(async ({ input }) => {
try {
@@ -738,7 +739,7 @@ export const databaseRouter = createTRPCRouter({
}
}),
updateUserEmail: publicProcedure
updateUserEmail: csrfProtectedProcedure
.input(updateUserEmailSchema)
.mutation(async ({ input }) => {
try {