nook: say when a release carries no notes
Releases that shipped before notes were embedded in the appcast (0.6.2 and earlier) have empty descriptions, so expanding their row rendered a blank expanse that read as broken. Show a muted "no notes recorded" line instead; the appcast embed step now runs every release, so history accumulates from here on. Tests: vinxi build clean; tsc clean. Issue: FRE-13
This commit is contained in:
@@ -90,12 +90,25 @@ export default function NookChangelogPage() {
|
|||||||
</button>
|
</button>
|
||||||
{/* Notes are the publisher's own HTML, written to the same
|
{/* Notes are the publisher's own HTML, written to the same
|
||||||
S3 appcast the Sparkle updater consumes. Kept mounted
|
S3 appcast the Sparkle updater consumes. Kept mounted
|
||||||
and toggled via `hidden` so the content stays crawlable. */}
|
and toggled via `hidden` so the content stays crawlable.
|
||||||
|
Releases that shipped before notes were embedded in the
|
||||||
|
appcast carry no description — say so instead of
|
||||||
|
rendering a blank expanse. */}
|
||||||
<div
|
<div
|
||||||
classList={{ hidden: !isOpen(release.version, i()) }}
|
classList={{ hidden: !isOpen(release.version, i()) }}
|
||||||
class="text-subtext0 px-5 pb-5 pl-14 text-sm [&_h2]:mt-3 [&_h2]:mb-1 [&_h2]:text-base [&_h2]:font-semibold [&_h2]:text-text [&_li]:ml-5 [&_li]:list-disc [&_p]:mb-2 [&_ul]:mb-2"
|
class="text-subtext0 px-5 pb-5 pl-14 text-sm [&_h2]:mt-3 [&_h2]:mb-1 [&_h2]:text-base [&_h2]:font-semibold [&_h2]:text-text [&_li]:ml-5 [&_li]:list-disc [&_p]:mb-2 [&_ul]:mb-2"
|
||||||
innerHTML={release.notesHtml}
|
>
|
||||||
/>
|
<Show
|
||||||
|
when={release.notesHtml}
|
||||||
|
fallback={
|
||||||
|
<p class="text-subtext1 italic">
|
||||||
|
No notes recorded for this release.
|
||||||
|
</p>
|
||||||
|
}
|
||||||
|
>
|
||||||
|
<div innerHTML={release.notesHtml} />
|
||||||
|
</Show>
|
||||||
|
</div>
|
||||||
</article>
|
</article>
|
||||||
)}
|
)}
|
||||||
</For>
|
</For>
|
||||||
|
|||||||
Reference in New Issue
Block a user