Compare commits
4 Commits
v0.6.0
...
20d5b57cb6
| Author | SHA1 | Date | |
|---|---|---|---|
| 20d5b57cb6 | |||
| d7aec4e810 | |||
| 77531ce41d | |||
| 26729fa5e6 |
@@ -1,11 +0,0 @@
|
||||
module.exports = {
|
||||
root: true,
|
||||
parser: "@typescript-eslint/parser",
|
||||
plugins: ["@typescript-eslint"],
|
||||
extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
|
||||
env: {
|
||||
es2022: true,
|
||||
node: true,
|
||||
},
|
||||
ignorePatterns: ["dist", "node_modules"],
|
||||
}
|
||||
2
.gitignore
vendored
2
.gitignore
vendored
@@ -35,3 +35,5 @@ report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json
|
||||
.harness/
|
||||
.ralpi
|
||||
notes.md
|
||||
# pygienium run-state and check artifacts
|
||||
.pygienium/
|
||||
|
||||
@@ -15,7 +15,7 @@
|
||||
- `bun tests/cavacore-smoke.ts` - Run specific native library smoke test
|
||||
|
||||
### Linting
|
||||
- `bun run lint` - Run ESLint with TypeScript rules
|
||||
- `bun run lint` - Run the TypeScript typecheck (`bun tsc --noEmit`)
|
||||
|
||||
## Code Style Guidelines
|
||||
|
||||
|
||||
@@ -18,9 +18,6 @@
|
||||
},
|
||||
"devDependencies": {
|
||||
"@types/bun": "latest",
|
||||
"@typescript-eslint/eslint-plugin": "^8.54.0",
|
||||
"@typescript-eslint/parser": "^8.54.0",
|
||||
"eslint": "^9.39.2",
|
||||
"typescript": "^5.9.3"
|
||||
},
|
||||
"dependencies": {
|
||||
|
||||
@@ -100,24 +100,20 @@ export const parseRSSItem = (item: string, feedUrl: string, index: number): Epis
|
||||
const epDescription = cleanField(getTagValue(item, "description"))
|
||||
const pubDate = new Date(getTagValue(item, "pubDate") || Date.now())
|
||||
|
||||
// Audio URL + file size + MIME type from <enclosure>
|
||||
const enclosure = item.match(/<enclosure[^>]*url=["']([^"']+)["'][^>]*>/i)
|
||||
const audioUrl = enclosure?.[1] ?? ""
|
||||
const fileSizeStr = getAttr(item, "enclosure", "length")
|
||||
const fileSize = fileSizeStr ? parseInt(fileSizeStr, 10) : undefined
|
||||
const mimeType = getAttr(item, "enclosure", "type") || undefined
|
||||
|
||||
// Duration from <itunes:duration>
|
||||
const durationRaw = getTagValue(item, "itunes:duration")
|
||||
const duration = parseDuration(durationRaw)
|
||||
|
||||
// Episode & season numbers
|
||||
const episodeNumRaw = getTagValue(item, "itunes:episode")
|
||||
const episodeNumber = episodeNumRaw ? parseInt(episodeNumRaw, 10) : undefined
|
||||
const seasonNumRaw = getTagValue(item, "itunes:season")
|
||||
const seasonNumber = seasonNumRaw ? parseInt(seasonNumRaw, 10) : undefined
|
||||
|
||||
// Episode type & explicit
|
||||
const episodeType = parseEpisodeType(getTagValue(item, "itunes:episodeType"))
|
||||
const explicitRaw = getTagValue(item, "itunes:explicit").toLowerCase()
|
||||
const explicit = explicitRaw === "yes" || explicitRaw === "true" ? true : undefined
|
||||
@@ -135,7 +131,6 @@ export const parseRSSItem = (item: string, feedUrl: string, index: number): Epis
|
||||
pubDate,
|
||||
}
|
||||
|
||||
// Only set optional fields if present
|
||||
if (episodeNumber !== undefined && !isNaN(episodeNumber)) ep.episodeNumber = episodeNumber
|
||||
if (seasonNumber !== undefined && !isNaN(seasonNumber)) ep.seasonNumber = seasonNumber
|
||||
if (episodeType) ep.episodeType = episodeType
|
||||
|
||||
246
src/components/EpisodeList.tsx
Normal file
246
src/components/EpisodeList.tsx
Normal file
@@ -0,0 +1,246 @@
|
||||
/**
|
||||
* Shared list-row and preview components for the Feed and My Shows pages.
|
||||
*
|
||||
* Both pages render the same episode rows (marker + title, optional subtitle
|
||||
* line, date/duration/selection/download meta line), "[Fetch More]" rows, and
|
||||
* hovered-episode / fetch-more preview panes; the pages differ only in the
|
||||
* props they pass (subtitle line, hint text, manual-mode wording). Extracted
|
||||
* so the previously 3-4-level-nested render blocks run as flat named
|
||||
* components.
|
||||
*
|
||||
* Anything that can change at runtime arrives as a signal getter: Solid
|
||||
* components do not re-render, so only props that are called inside the
|
||||
* component's own JSX stay reactive (focus, selection, download state).
|
||||
*/
|
||||
|
||||
import { Show } from "solid-js";
|
||||
import { format } from "date-fns";
|
||||
import type { RGBA } from "@opentui/core";
|
||||
import { useTheme } from "@/context/ThemeContext";
|
||||
import { useScrollIntoView } from "@/hooks/useScrollIntoView";
|
||||
import { NF_ICONS } from "@/utils/nerd-fonts";
|
||||
import { LoadingIndicator } from "@/components/LoadingIndicator";
|
||||
import type { Episode } from "@/types/episode";
|
||||
|
||||
// ── formatting helpers ──────────────────────────────────────────────────────
|
||||
export const formatDate = (d: Date) => format(d, "MMM d, yyyy");
|
||||
|
||||
export const formatDuration = (s: number) => {
|
||||
const mins = Math.floor(s / 60);
|
||||
const hrs = Math.floor(mins / 60);
|
||||
return hrs > 0 ? `${hrs}h ${mins % 60}m` : `${mins}m`;
|
||||
};
|
||||
|
||||
// ── EpisodeRow ──────────────────────────────────────────────────────────────
|
||||
export function EpisodeRow(props: {
|
||||
/** The episode this row renders. */
|
||||
episode: Episode;
|
||||
/** Optional second line under the title (podcast/show name). */
|
||||
subtitle?: () => string | undefined;
|
||||
/** For index signal (row position). */
|
||||
index: () => number;
|
||||
/** Focused row index in this list (-1 while the Fetch More row is
|
||||
* focused, so no episode row draws the cursor). */
|
||||
focused: () => number;
|
||||
/** Whether the current pane has keyboard focus. */
|
||||
active: () => boolean;
|
||||
/** Whether this episode is selection-marked. */
|
||||
selected: () => boolean;
|
||||
downloadLabel: () => string;
|
||||
downloadColor: () => RGBA;
|
||||
marker: () => string;
|
||||
onMouseDown: () => void;
|
||||
}) {
|
||||
const { theme } = useTheme();
|
||||
const muted = () => theme.muted || theme.text;
|
||||
const ref = useScrollIntoView(() => props.index() === props.focused());
|
||||
const isFocused = () => props.index() === props.focused();
|
||||
const bg = () =>
|
||||
isFocused() && props.active()
|
||||
? theme.primary
|
||||
: isFocused()
|
||||
? theme.border
|
||||
: undefined;
|
||||
const fg = () =>
|
||||
isFocused() && props.active()
|
||||
? theme.surface
|
||||
: isFocused()
|
||||
? theme.selectedListItemText ?? theme.text
|
||||
: theme.text;
|
||||
return (
|
||||
<box
|
||||
ref={ref}
|
||||
flexDirection="column"
|
||||
gap={0}
|
||||
paddingRight={1}
|
||||
backgroundColor={bg()}
|
||||
onMouseDown={props.onMouseDown}
|
||||
>
|
||||
<box flexDirection="row" gap={1}>
|
||||
<text flexShrink={0} fg={fg()}>
|
||||
{isFocused() ? props.marker() : " "}
|
||||
</text>
|
||||
<text wrapMode="none" truncate fg={fg()}>
|
||||
{props.episode.episodeNumber ? `#${props.episode.episodeNumber} ` : ""}
|
||||
{props.episode.title}
|
||||
</text>
|
||||
</box>
|
||||
{/* podcast name on its own row — readable at a glance; the 50%
|
||||
current pane fits it in full for typical names, and truncate
|
||||
keeps the row one line tall either way */}
|
||||
<Show when={props.subtitle?.()}>
|
||||
<box paddingLeft={2}>
|
||||
<text
|
||||
wrapMode="none"
|
||||
truncate
|
||||
fg={isFocused() ? theme.surface : theme.textSecondary}
|
||||
>
|
||||
{props.subtitle?.()}
|
||||
</text>
|
||||
</box>
|
||||
</Show>
|
||||
<box flexDirection="row" gap={2} paddingLeft={2}>
|
||||
<text flexShrink={0} fg={isFocused() ? theme.surface : theme.info}>
|
||||
{formatDate(props.episode.pubDate)}
|
||||
</text>
|
||||
<text flexShrink={0} fg={isFocused() ? theme.surface : muted()}>
|
||||
{formatDuration(props.episode.duration)}
|
||||
</text>
|
||||
<Show when={props.selected()}>
|
||||
<text flexShrink={0} fg={theme.warning}>
|
||||
●
|
||||
</text>
|
||||
</Show>
|
||||
<Show when={props.downloadLabel()}>
|
||||
<text flexShrink={0} fg={props.downloadColor()}>
|
||||
{props.downloadLabel()}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
</box>
|
||||
);
|
||||
}
|
||||
|
||||
// ── FetchMoreRow ────────────────────────────────────────────────────────────
|
||||
export function FetchMoreRow(props: {
|
||||
/** Row index of the Fetch More button within the list. */
|
||||
index: () => number;
|
||||
/** Focused row index. */
|
||||
focused: () => number;
|
||||
/** True while the Fetch More row itself is focused. */
|
||||
onMore: () => boolean;
|
||||
/** Whether the current pane has keyboard focus. */
|
||||
active: () => boolean;
|
||||
isLoadingMore: () => boolean;
|
||||
nerd: boolean;
|
||||
marker: () => string;
|
||||
onMouseDown: () => void;
|
||||
}) {
|
||||
const { theme } = useTheme();
|
||||
const ref = useScrollIntoView(props.onMore);
|
||||
const bg = () =>
|
||||
props.index() === props.focused() && props.active()
|
||||
? theme.primary
|
||||
: props.index() === props.focused()
|
||||
? theme.border
|
||||
: undefined;
|
||||
const fg = () =>
|
||||
props.index() === props.focused() && props.active()
|
||||
? theme.surface
|
||||
: props.index() === props.focused()
|
||||
? theme.selectedListItemText ?? theme.text
|
||||
: theme.text;
|
||||
return (
|
||||
<box
|
||||
ref={ref}
|
||||
flexDirection="row"
|
||||
gap={1}
|
||||
paddingRight={1}
|
||||
backgroundColor={bg()}
|
||||
onMouseDown={props.onMouseDown}
|
||||
>
|
||||
<text fg={fg()}>{props.onMore() ? props.marker() : " "}</text>
|
||||
{props.nerd && (
|
||||
<text fg={fg()}>{NF_ICONS.more}</text>
|
||||
)}
|
||||
<Show
|
||||
when={!props.isLoadingMore()}
|
||||
fallback={<LoadingIndicator label="Fetching…" />}
|
||||
>
|
||||
<text fg={fg()}>[Fetch More]</text>
|
||||
</Show>
|
||||
</box>
|
||||
);
|
||||
}
|
||||
|
||||
// ── EpisodePreview ──────────────────────────────────────────────────────────
|
||||
export function EpisodePreview(props: {
|
||||
episode: () => Episode;
|
||||
/** Optional line under the meta row (podcast/show name). */
|
||||
subtitle?: () => string | undefined;
|
||||
author: () => string | undefined;
|
||||
downloadLabel: () => string;
|
||||
downloadColor: () => RGBA;
|
||||
/** Page-specific action-hint line. */
|
||||
hint: () => string;
|
||||
}) {
|
||||
const { theme } = useTheme();
|
||||
const muted = () => theme.muted || theme.text;
|
||||
return (
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>
|
||||
{props.episode().episodeNumber ? `#${props.episode().episodeNumber} ` : ""}
|
||||
{props.episode().title}
|
||||
</strong>
|
||||
</text>
|
||||
<box flexDirection="row" gap={2}>
|
||||
<text fg={theme.info}>{formatDate(props.episode().pubDate)}</text>
|
||||
<text fg={muted()}>{formatDuration(props.episode().duration)}</text>
|
||||
<Show when={props.downloadLabel()}>
|
||||
<text fg={props.downloadColor()}>{props.downloadLabel()}</text>
|
||||
</Show>
|
||||
</box>
|
||||
<Show when={props.subtitle?.()}>
|
||||
<text fg={muted()}>{props.subtitle?.()}</text>
|
||||
</Show>
|
||||
<Show when={props.author()}>
|
||||
<text fg={muted()}>by {props.author()}</text>
|
||||
</Show>
|
||||
<box height={1} />
|
||||
<text fg={theme.textSecondary}>
|
||||
{props.episode().description?.slice(0, 400) ?? "No description available."}
|
||||
{(props.episode().description?.length ?? 0) > 400 ? "…" : ""}
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>{props.hint()}</text>
|
||||
</box>
|
||||
);
|
||||
}
|
||||
|
||||
// ── FetchMorePreview ────────────────────────────────────────────────────────
|
||||
export function FetchMorePreview(props: {
|
||||
isLoadingMore: () => boolean;
|
||||
fetchMoreMode: () => string;
|
||||
/** Manual-mode explanation line ("across all feeds" vs "for this show"). */
|
||||
manualText: () => string;
|
||||
}) {
|
||||
const { theme } = useTheme();
|
||||
const muted = () => theme.muted || theme.text;
|
||||
return (
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>[Fetch More]</strong>
|
||||
</text>
|
||||
<text fg={muted()}>
|
||||
{props.isLoadingMore()
|
||||
? "Loading the next batch of episodes…"
|
||||
: props.fetchMoreMode() === "auto"
|
||||
? "Auto mode: the next batch loads automatically at the bottom of the list."
|
||||
: props.manualText()}
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>enter: load more · h back</text>
|
||||
</box>
|
||||
);
|
||||
}
|
||||
@@ -169,7 +169,6 @@ export function Shell() {
|
||||
nav.backspaceCommand();
|
||||
return;
|
||||
}
|
||||
// printable char
|
||||
if (evt.name && evt.name.length === 1 && !evt.ctrl && !evt.meta) {
|
||||
evt.preventDefault();
|
||||
nav.appendCommand(evt.name);
|
||||
|
||||
@@ -10,7 +10,8 @@ import {
|
||||
generateSyntax,
|
||||
generateSubtleSyntax,
|
||||
} from "../utils/syntax-highlighter";
|
||||
import { resolveTerminalTheme, loadThemes } from "../utils/theme";
|
||||
import { resolveTerminalTheme } from "../utils/theme";
|
||||
import { getCustomThemes } from "../utils/custom-themes";
|
||||
import { detectModeFromBackground } from "../utils/system-theme";
|
||||
import { createSimpleContext } from "./helper";
|
||||
import {
|
||||
@@ -175,7 +176,7 @@ export const { use: useTheme, provider: ThemeProvider } = createSimpleContext({
|
||||
|
||||
function init() {
|
||||
resolveSystemTheme();
|
||||
loadThemes()
|
||||
getCustomThemes()
|
||||
.then((custom) => {
|
||||
setStore(
|
||||
produce((draft) => {
|
||||
@@ -187,7 +188,6 @@ export const { use: useTheme, provider: ThemeProvider } = createSimpleContext({
|
||||
setStore("active", "catppuccin");
|
||||
})
|
||||
.finally(() => {
|
||||
// Only set ready if not waiting for system theme
|
||||
if (store.active !== "system") {
|
||||
setStore("ready", true);
|
||||
}
|
||||
|
||||
@@ -297,6 +297,34 @@ function stopPolling(): void {
|
||||
// from `--cover-art-files`. Shared helper (utils/cover-art.ts) fetches the
|
||||
// podcast cover to a temp file BEFORE playback starts, bounded to 3s.
|
||||
|
||||
/** Resolve cover art to a local path for mpv's --cover-art-files, per the
|
||||
* call site's latency budget:
|
||||
* "cache" — disk cache only (sync): resume paths must never wait on the
|
||||
* network, so a miss plays artless and warms for next time.
|
||||
* "bounded" — disk hit, else fetch capped at 1.2s: cold play needs the art
|
||||
* at file LOAD, but a slow cover server must not stall audio.
|
||||
* "await" — disk hit, else full (8s-bounded) fetch: boot restore preloads
|
||||
* while feeds/progress load anyway, so the wait is free and the
|
||||
* cover must be present when the file loads.
|
||||
* fetchCoverArt already short-circuits on the disk cache, so "await" costs
|
||||
* nothing on a warm cache. */
|
||||
async function resolveCoverArt(
|
||||
coverUrl: string | undefined,
|
||||
mode: "cache" | "bounded" | "await",
|
||||
): Promise<string | null> {
|
||||
if (!coverUrl) return null;
|
||||
if (mode === "cache") return cachedCoverPath(coverUrl);
|
||||
if (mode === "bounded") {
|
||||
const cached = cachedCoverPath(coverUrl);
|
||||
if (cached) return cached;
|
||||
return Promise.race([
|
||||
fetchCoverArt(coverUrl),
|
||||
new Promise<null>((resolve) => setTimeout(() => resolve(null), 1200)),
|
||||
]);
|
||||
}
|
||||
return fetchCoverArt(coverUrl);
|
||||
}
|
||||
|
||||
async function play(episode: Episode): Promise<void> {
|
||||
const b = ensureBackend();
|
||||
setError(null);
|
||||
@@ -321,21 +349,15 @@ async function play(episode: Episode): Promise<void> {
|
||||
// episode's own image (feeds added by URL may lack a channel cover).
|
||||
const downloadStore = useDownloadStore();
|
||||
const url = downloadStore.getDownloadedFilePath(episode.id) ?? episode.audioUrl;
|
||||
const coverUrl = feed?.podcast.coverUrl ?? episode.imageUrl;
|
||||
// Cover art only applies at file LOAD (the runtime video-add fallback
|
||||
// never becomes an albumart track), so a cold-cache play must wait for
|
||||
// the fetch or play artless. Serve the disk cache synchronously; on a
|
||||
// miss, await the single-flight fetch with a 1.2s cap (covers fetch in
|
||||
// ~300ms typically) — past the cap, play bare and let the fetch warm
|
||||
// the cache for next time.
|
||||
let coverArtPath = coverUrl ? cachedCoverPath(coverUrl) : null;
|
||||
if (coverUrl && !coverArtPath) {
|
||||
const path = await Promise.race([
|
||||
fetchCoverArt(coverUrl),
|
||||
new Promise<null>((resolve) => setTimeout(() => resolve(null), 1200)),
|
||||
]);
|
||||
if (path) coverArtPath = path;
|
||||
}
|
||||
// miss, await the bounded fetch (covers fetch in ~300ms typically) —
|
||||
// past the 1.2s cap, play bare and let the fetch warm the cache.
|
||||
const coverArtPath = await resolveCoverArt(
|
||||
feed?.podcast.coverUrl ?? episode.imageUrl,
|
||||
"bounded",
|
||||
);
|
||||
|
||||
// Resume from saved progress if available and not completed
|
||||
const savedProgress = progressStore.get(episode.id);
|
||||
@@ -436,8 +458,10 @@ async function load(episode: Episode): Promise<void> {
|
||||
// on feeds/progress at boot, so the bounded fetch (~300ms typical,
|
||||
// 8s worst case) is free. Falls back to the episode's own image when
|
||||
// the feed has no channel cover.
|
||||
const coverUrl = feed?.podcast.coverUrl ?? episode.imageUrl;
|
||||
const coverArtPath = coverUrl ? await fetchCoverArt(coverUrl) : null;
|
||||
const coverArtPath = await resolveCoverArt(
|
||||
feed?.podcast.coverUrl ?? episode.imageUrl,
|
||||
"await",
|
||||
);
|
||||
const backendSnap = backend;
|
||||
backendSnap
|
||||
.preload(url, {
|
||||
@@ -612,8 +636,10 @@ async function switchBackend(name: BackendName): Promise<void> {
|
||||
const podcastTitle = feed?.customName || feed?.podcast.title || "";
|
||||
const url =
|
||||
useDownloadStore().getDownloadedFilePath(ep.id) ?? ep.audioUrl;
|
||||
const coverUrl = feed?.podcast.coverUrl ?? ep.imageUrl;
|
||||
const coverArtPath = coverUrl ? cachedCoverPath(coverUrl) : null;
|
||||
const coverArtPath = await resolveCoverArt(
|
||||
feed?.podcast.coverUrl ?? ep.imageUrl,
|
||||
"cache",
|
||||
);
|
||||
await backend.play(url, {
|
||||
startPosition: pos,
|
||||
volume: vol,
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import type { Feed } from "./types/feed"
|
||||
import type { Episode } from "./types/episode"
|
||||
|
||||
const VERSION = "0.6.0";
|
||||
const VERSION = "0.6.2";
|
||||
|
||||
interface CliArgs {
|
||||
version: boolean;
|
||||
@@ -42,7 +42,6 @@ if (cliArgs.version) {
|
||||
|
||||
// ── CLI handlers ──────────────────────────────────────────────────────
|
||||
|
||||
/** Find the most recent episode across all feeds */
|
||||
function findLatestEpisode(
|
||||
feeds: Feed[],
|
||||
): { feed: Feed; episode: Episode } | null {
|
||||
|
||||
@@ -22,7 +22,6 @@ import { useDownloadStore } from "@/stores/download";
|
||||
import { useAppStore } from "@/stores/app";
|
||||
import { prefetchCoverArt } from "@/utils/cover-art";
|
||||
import { DownloadStatus } from "@/types/episode";
|
||||
import { format } from "date-fns";
|
||||
import { useTheme } from "@/context/ThemeContext";
|
||||
import { useAudioNavStore, AudioSource } from "@/stores/audio-nav";
|
||||
import {
|
||||
@@ -33,14 +32,19 @@ import {
|
||||
} from "@/context/NavigationContext";
|
||||
import { useAudio } from "@/hooks/useAudio";
|
||||
import { on, off } from "@/utils/event-bus";
|
||||
import { NF_ICONS, supportsNerdFonts } from "@/utils/nerd-fonts";
|
||||
import { supportsNerdFonts } from "@/utils/nerd-fonts";
|
||||
import type { KeybindActionName } from "@/context/KeybindContext";
|
||||
import type { Episode } from "@/types/episode";
|
||||
import type { Feed } from "@/types/feed";
|
||||
import {
|
||||
EpisodeRow,
|
||||
FetchMoreRow,
|
||||
EpisodePreview,
|
||||
FetchMorePreview,
|
||||
} from "@/components/EpisodeList";
|
||||
import { LoadingIndicator } from "@/components/LoadingIndicator";
|
||||
import { PaneRow } from "@/components/PaneRow";
|
||||
import { TabListPane } from "@/components/TabPanel";
|
||||
import { useScrollIntoView } from "@/hooks/useScrollIntoView";
|
||||
import { useSelectionMarker } from "@/hooks/useSelectionMarker";
|
||||
|
||||
export const FeedPaneCount = 1;
|
||||
@@ -87,7 +91,6 @@ function FeedPage() {
|
||||
const app = useAppStore();
|
||||
const fetchMoreMode = () => app.state().preferences.fetchMoreMode ?? "auto";
|
||||
const showFetchMore = () => feedStore.hasMoreAcrossAll();
|
||||
// Total navigable rows: episodes + the optional Fetch More row.
|
||||
const rowCount = () => episodes().length + (showFetchMore() ? 1 : 0);
|
||||
const focus = () => nav.depthFocus(0);
|
||||
const focusedRow = () =>
|
||||
@@ -103,7 +106,6 @@ function FeedPage() {
|
||||
const focusedItem = (): EpItem | undefined =>
|
||||
focusedOnMore() ? undefined : episodes()[focusedEpIdx()];
|
||||
const curLen = () => rowCount();
|
||||
const moreRef = useScrollIntoView(() => focusedOnMore());
|
||||
|
||||
const ensureFocus = () => {
|
||||
if (rowCount() > 0 && focus() >= rowCount())
|
||||
@@ -129,12 +131,6 @@ function FeedPage() {
|
||||
});
|
||||
|
||||
// ── helpers ────────────────────────────────────────────────────────────────
|
||||
const formatDate = (d: Date) => format(d, "MMM d, yyyy");
|
||||
const formatDuration = (s: number) => {
|
||||
const mins = Math.floor(s / 60);
|
||||
const hrs = Math.floor(mins / 60);
|
||||
return hrs > 0 ? `${hrs}h ${mins % 60}m` : `${mins}m`;
|
||||
};
|
||||
const downloadLabel = (id: string) => {
|
||||
switch (downloadStore.getDownloadStatus(id)) {
|
||||
case DownloadStatus.QUEUED:
|
||||
@@ -229,19 +225,6 @@ function FeedPage() {
|
||||
|
||||
// ── render ──────────────────────────────────────────────────────────────────
|
||||
const isActive = () => nav.activePane() === DEPTH_CENTER_PANE;
|
||||
// Row highlight within the list. `active=true` only for the current pane.
|
||||
const focusBg = (i: number, listFocus: number, active: boolean) =>
|
||||
i === listFocus && active
|
||||
? theme.primary
|
||||
: i === listFocus
|
||||
? theme.border
|
||||
: undefined;
|
||||
const focusFg = (i: number, listFocus: number, active: boolean) =>
|
||||
i === listFocus && active
|
||||
? theme.surface
|
||||
: i === listFocus
|
||||
? theme.selectedListItemText ?? theme.text
|
||||
: theme.text;
|
||||
|
||||
const currentLabel = () => `Feed · ${episodes().length}`;
|
||||
|
||||
@@ -268,108 +251,38 @@ function FeedPage() {
|
||||
}
|
||||
>
|
||||
<For each={episodes()}>
|
||||
{(item, index) => {
|
||||
const fi = () => focusedEpIdx();
|
||||
const ref = useScrollIntoView(() => index() === fi());
|
||||
return (
|
||||
<box
|
||||
ref={ref}
|
||||
flexDirection="column"
|
||||
gap={0}
|
||||
paddingRight={1}
|
||||
backgroundColor={focusBg(index(), fi(), isActive())}
|
||||
{(item, index) => (
|
||||
<EpisodeRow
|
||||
episode={item.episode}
|
||||
subtitle={() => item.feed.customName || item.feed.podcast.title}
|
||||
index={index}
|
||||
focused={focusedEpIdx}
|
||||
active={isActive}
|
||||
selected={() => nav.isSelected(item.episode.id)}
|
||||
downloadLabel={() => downloadLabel(item.episode.id)}
|
||||
downloadColor={() => downloadColor(item.episode.id)}
|
||||
marker={marker}
|
||||
onMouseDown={() => {
|
||||
nav.setActivePane(DEPTH_CENTER_PANE);
|
||||
nav.setDepthFocus(index(), 0);
|
||||
}}
|
||||
>
|
||||
<box flexDirection="row" gap={1}>
|
||||
<text
|
||||
flexShrink={0}
|
||||
fg={focusFg(index(), fi(), isActive())}
|
||||
>
|
||||
{index() === fi() ? marker() : " "}
|
||||
</text>
|
||||
<text
|
||||
wrapMode="none"
|
||||
truncate
|
||||
fg={focusFg(index(), fi(), isActive())}
|
||||
>
|
||||
{item.episode.episodeNumber
|
||||
? `#${item.episode.episodeNumber} `
|
||||
: ""}
|
||||
{item.episode.title}
|
||||
</text>
|
||||
</box>
|
||||
{/* podcast name on its own row — readable at a glance; the
|
||||
50% current pane fits it in full for typical names, and
|
||||
truncate keeps the row one line tall either way */}
|
||||
<box paddingLeft={2}>
|
||||
<text
|
||||
wrapMode="none"
|
||||
truncate
|
||||
fg={index() === fi() ? theme.surface : theme.textSecondary}
|
||||
>
|
||||
{item.feed.customName || item.feed.podcast.title}
|
||||
</text>
|
||||
</box>
|
||||
<box flexDirection="row" gap={2} paddingLeft={2}>
|
||||
<text
|
||||
flexShrink={0}
|
||||
fg={index() === fi() ? theme.surface : theme.info}
|
||||
>
|
||||
{formatDate(item.episode.pubDate)}
|
||||
</text>
|
||||
<text
|
||||
flexShrink={0}
|
||||
fg={index() === fi() ? theme.surface : muted()}
|
||||
>
|
||||
{formatDuration(item.episode.duration)}
|
||||
</text>
|
||||
<Show when={nav.isSelected(item.episode.id)}>
|
||||
<text flexShrink={0} fg={theme.warning}>
|
||||
●
|
||||
</text>
|
||||
</Show>
|
||||
<Show when={downloadLabel(item.episode.id)}>
|
||||
<text flexShrink={0} fg={downloadColor(item.episode.id)}>
|
||||
{downloadLabel(item.episode.id)}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
</box>
|
||||
);
|
||||
}}
|
||||
/>
|
||||
)}
|
||||
</For>
|
||||
<Show when={showFetchMore()}>
|
||||
<box
|
||||
ref={moreRef}
|
||||
flexDirection="row"
|
||||
gap={1}
|
||||
paddingRight={1}
|
||||
backgroundColor={focusBg(episodes().length, focusedRow(), isActive())}
|
||||
<FetchMoreRow
|
||||
index={() => episodes().length}
|
||||
focused={focusedRow}
|
||||
onMore={focusedOnMore}
|
||||
active={isActive}
|
||||
isLoadingMore={() => feedStore.isLoadingMore()}
|
||||
nerd={nerd}
|
||||
marker={marker}
|
||||
onMouseDown={() => {
|
||||
nav.setActivePane(DEPTH_CENTER_PANE);
|
||||
nav.setDepthFocus(episodes().length, 0);
|
||||
}}
|
||||
>
|
||||
<text fg={focusFg(episodes().length, focusedRow(), isActive())}>
|
||||
{focusedOnMore() ? marker() : " "}
|
||||
</text>
|
||||
{nerd && (
|
||||
<text fg={focusFg(episodes().length, focusedRow(), isActive())}>
|
||||
{NF_ICONS.more}
|
||||
</text>
|
||||
)}
|
||||
<Show
|
||||
when={!feedStore.isLoadingMore()}
|
||||
fallback={<LoadingIndicator label="Fetching…" />}
|
||||
>
|
||||
<text fg={focusFg(episodes().length, focusedRow(), isActive())}>
|
||||
[Fetch More]
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
/>
|
||||
</Show>
|
||||
<Show when={feedStore.isLoadingFeeds()}>
|
||||
<box alignItems="center" paddingTop={1}>
|
||||
@@ -380,23 +293,23 @@ function FeedPage() {
|
||||
);
|
||||
|
||||
// ── preview pane: hovered-episode detail (or the Fetch More row) ──────────
|
||||
const episodeHint = (item: EpItem) =>
|
||||
`enter: play · d: download${
|
||||
downloadStore.getDownloadStatus(item.episode.id) !== DownloadStatus.NONE
|
||||
? " · D: delete"
|
||||
: ""
|
||||
} · space: select · h back`;
|
||||
|
||||
const previewContent = () => (
|
||||
<>
|
||||
<Show when={focusedOnMore()}>
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>[Fetch More]</strong>
|
||||
</text>
|
||||
<text fg={muted()}>
|
||||
{feedStore.isLoadingMore()
|
||||
? "Loading the next batch of episodes…"
|
||||
: fetchMoreMode() === "auto"
|
||||
? "Auto mode: the next batch loads automatically at the bottom of the list."
|
||||
: "Load the next batch of older episodes across all feeds (Enter)."}
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>enter: load more · h back</text>
|
||||
</box>
|
||||
<FetchMorePreview
|
||||
isLoadingMore={() => feedStore.isLoadingMore()}
|
||||
fetchMoreMode={fetchMoreMode}
|
||||
manualText={() =>
|
||||
"Load the next batch of older episodes across all feeds (Enter)."
|
||||
}
|
||||
/>
|
||||
</Show>
|
||||
<Show when={!focusedOnMore()}>
|
||||
<Show
|
||||
@@ -408,46 +321,16 @@ function FeedPage() {
|
||||
}
|
||||
>
|
||||
{(item) => (
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>
|
||||
{item().episode.episodeNumber
|
||||
? `#${item().episode.episodeNumber} `
|
||||
: ""}
|
||||
{item().episode.title}
|
||||
</strong>
|
||||
</text>
|
||||
<box flexDirection="row" gap={2}>
|
||||
<text fg={theme.info}>{formatDate(item().episode.pubDate)}</text>
|
||||
<text fg={muted()}>{formatDuration(item().episode.duration)}</text>
|
||||
<Show when={downloadLabel(item().episode.id)}>
|
||||
<text fg={downloadColor(item().episode.id)}>
|
||||
{downloadLabel(item().episode.id)}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
<text fg={muted()}>
|
||||
{item().feed.customName || item().feed.podcast.title}
|
||||
</text>
|
||||
<Show when={item().feed.podcast.author}>
|
||||
<text fg={muted()}>by {item().feed.podcast.author}</text>
|
||||
</Show>
|
||||
<box height={1} />
|
||||
<text fg={theme.textSecondary}>
|
||||
{item().episode.description?.slice(0, 400) ??
|
||||
"No description available."}
|
||||
{(item().episode.description?.length ?? 0) > 400 ? "…" : ""}
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>
|
||||
enter: play · d: download
|
||||
{downloadStore.getDownloadStatus(item().episode.id) !==
|
||||
DownloadStatus.NONE
|
||||
? " · D: delete"
|
||||
: ""}{" "}
|
||||
· space: select · h back
|
||||
</text>
|
||||
</box>
|
||||
<EpisodePreview
|
||||
episode={() => item().episode}
|
||||
subtitle={() =>
|
||||
item().feed.customName || item().feed.podcast.title
|
||||
}
|
||||
author={() => item().feed.podcast.author}
|
||||
downloadLabel={() => downloadLabel(item().episode.id)}
|
||||
downloadColor={() => downloadColor(item().episode.id)}
|
||||
hint={() => episodeHint(item())}
|
||||
/>
|
||||
)}
|
||||
</Show>
|
||||
</Show>
|
||||
|
||||
@@ -15,11 +15,11 @@
|
||||
*/
|
||||
|
||||
import { createMemo, createEffect, For, Show, onMount, onCleanup } from "solid-js";
|
||||
import type { RGBA } from "@opentui/core";
|
||||
import { useFeedStore } from "@/stores/feed";
|
||||
import { useDownloadStore } from "@/stores/download";
|
||||
import { useAppStore } from "@/stores/app";
|
||||
import { DownloadStatus } from "@/types/episode";
|
||||
import { format } from "date-fns";
|
||||
import { useTheme } from "@/context/ThemeContext";
|
||||
import { useAudioNavStore, AudioSource } from "@/stores/audio-nav";
|
||||
import {
|
||||
@@ -31,16 +31,208 @@ import {
|
||||
} from "@/context/NavigationContext";
|
||||
import { useAudio } from "@/hooks/useAudio";
|
||||
import { on, off } from "@/utils/event-bus";
|
||||
import { NF_ICONS, supportsNerdFonts } from "@/utils/nerd-fonts";
|
||||
import { supportsNerdFonts } from "@/utils/nerd-fonts";
|
||||
import type { KeybindActionName } from "@/context/KeybindContext";
|
||||
import type { Episode, DownloadedEpisode } from "@/types/episode";
|
||||
import type { Feed } from "@/types/feed";
|
||||
import { LoadingIndicator } from "@/components/LoadingIndicator";
|
||||
import {
|
||||
EpisodeRow,
|
||||
FetchMoreRow,
|
||||
EpisodePreview,
|
||||
FetchMorePreview,
|
||||
formatDate,
|
||||
} from "@/components/EpisodeList";
|
||||
import { PaneRow } from "@/components/PaneRow";
|
||||
import { TabListPane } from "@/components/TabPanel";
|
||||
import { useScrollIntoView } from "@/hooks/useScrollIntoView";
|
||||
import { useSelectionMarker } from "@/hooks/useSelectionMarker";
|
||||
|
||||
// ── render components ────────────────────────────────────────────────────────
|
||||
// Depth-0 rows (subscribed shows, unsubscribed-show downloads) and their
|
||||
// preview panes are My Shows-specific; episode rows/previews are shared with
|
||||
// the Feed page (see EpisodeList.tsx).
|
||||
|
||||
/** A subscribed-show row (depth 0). */
|
||||
function ShowRow(props: {
|
||||
feed: Feed;
|
||||
title: string;
|
||||
index: () => number;
|
||||
focused: () => number;
|
||||
active: () => boolean;
|
||||
marker: () => string;
|
||||
wlScope: () => boolean;
|
||||
wlInList: () => boolean;
|
||||
onMouseDown: () => void;
|
||||
}) {
|
||||
const { theme } = useTheme();
|
||||
const muted = () => theme.muted || theme.text;
|
||||
const ref = useScrollIntoView(() => props.index() === props.focused());
|
||||
const isFocused = () => props.index() === props.focused();
|
||||
const bg = () =>
|
||||
isFocused() && props.active()
|
||||
? theme.primary
|
||||
: isFocused()
|
||||
? theme.border
|
||||
: undefined;
|
||||
const fg = () =>
|
||||
isFocused() && props.active()
|
||||
? theme.surface
|
||||
: isFocused()
|
||||
? theme.selectedListItemText ?? theme.text
|
||||
: theme.text;
|
||||
return (
|
||||
<box
|
||||
ref={ref}
|
||||
flexDirection="row"
|
||||
gap={1}
|
||||
paddingRight={1}
|
||||
backgroundColor={bg()}
|
||||
onMouseDown={props.onMouseDown}
|
||||
>
|
||||
<text fg={fg()}>{isFocused() ? props.marker() : " "}</text>
|
||||
<text fg={fg()}>{props.title}</text>
|
||||
<text fg={isFocused() ? theme.surface : muted()}>
|
||||
({props.feed.episodes.length})
|
||||
</text>
|
||||
<Show when={props.wlScope()}>
|
||||
<text
|
||||
fg={
|
||||
isFocused()
|
||||
? theme.surface
|
||||
: props.wlInList()
|
||||
? theme.warning
|
||||
: muted()
|
||||
}
|
||||
>
|
||||
{props.wlInList() ? "●" : "○"}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
);
|
||||
}
|
||||
|
||||
/** An unsubscribed-show download row (depth 0, below the shows list). */
|
||||
function UnsubscribedRow(props: {
|
||||
d: DownloadedEpisode;
|
||||
index: () => number;
|
||||
focused: () => number;
|
||||
active: () => boolean;
|
||||
marker: () => string;
|
||||
downloadLabel: () => string;
|
||||
downloadColor: () => RGBA;
|
||||
onMouseDown: () => void;
|
||||
}) {
|
||||
const { theme } = useTheme();
|
||||
const ref = useScrollIntoView(() => props.index() === props.focused());
|
||||
const isFocused = () => props.index() === props.focused();
|
||||
const bg = () =>
|
||||
isFocused() && props.active()
|
||||
? theme.primary
|
||||
: isFocused()
|
||||
? theme.border
|
||||
: undefined;
|
||||
const fg = () =>
|
||||
isFocused() && props.active()
|
||||
? theme.surface
|
||||
: isFocused()
|
||||
? theme.selectedListItemText ?? theme.text
|
||||
: theme.text;
|
||||
return (
|
||||
<box
|
||||
ref={ref}
|
||||
flexDirection="column"
|
||||
gap={0}
|
||||
paddingRight={1}
|
||||
backgroundColor={bg()}
|
||||
onMouseDown={props.onMouseDown}
|
||||
>
|
||||
<box flexDirection="row" gap={1}>
|
||||
<text flexShrink={0} fg={fg()}>
|
||||
{isFocused() ? props.marker() : " "}
|
||||
</text>
|
||||
<text wrapMode="none" truncate fg={fg()}>
|
||||
{props.d.episodeTitle ?? props.d.episodeId}
|
||||
</text>
|
||||
<Show when={props.downloadLabel()}>
|
||||
<text flexShrink={0} fg={props.downloadColor()}>
|
||||
{props.downloadLabel()}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
<box paddingLeft={2}>
|
||||
<text
|
||||
wrapMode="none"
|
||||
truncate
|
||||
fg={isFocused() ? theme.surface : theme.textSecondary}
|
||||
>
|
||||
{props.d.podcastTitle ?? props.d.feedId}
|
||||
</text>
|
||||
</box>
|
||||
</box>
|
||||
);
|
||||
}
|
||||
|
||||
/** Depth-0 preview: the hovered subscribed show. */
|
||||
function ShowPreview(props: {
|
||||
show: () => Feed;
|
||||
title: () => string;
|
||||
hint: () => string;
|
||||
}) {
|
||||
const { theme } = useTheme();
|
||||
const muted = () => theme.muted || theme.text;
|
||||
const show = props.show;
|
||||
return (
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>{props.title()}</strong>
|
||||
</text>
|
||||
<Show when={show().podcast.author}>
|
||||
<text fg={muted()}>by {show().podcast.author}</text>
|
||||
</Show>
|
||||
<text fg={theme.textSecondary}>{show().episodes.length} episodes</text>
|
||||
<text fg={muted()}>
|
||||
{show().podcast.description?.slice(0, 400) ?? "No description."}
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>{props.hint()}</text>
|
||||
</box>
|
||||
);
|
||||
}
|
||||
|
||||
/** Depth-0 preview: the hovered unsubscribed-show download. */
|
||||
function UnsubscribedPreview(props: {
|
||||
d: () => DownloadedEpisode;
|
||||
downloadLabel: () => string;
|
||||
downloadColor: () => RGBA;
|
||||
}) {
|
||||
const { theme } = useTheme();
|
||||
const muted = () => theme.muted || theme.text;
|
||||
const d = props.d;
|
||||
return (
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>{d().episodeTitle ?? d().episodeId}</strong>
|
||||
</text>
|
||||
<text fg={theme.textSecondary}>{d().podcastTitle ?? d().feedId}</text>
|
||||
<box flexDirection="row" gap={2}>
|
||||
<Show when={d().pubDate}>
|
||||
<text fg={theme.info}>{formatDate(new Date(d().pubDate!))}</text>
|
||||
</Show>
|
||||
<Show when={props.downloadLabel()}>
|
||||
<text fg={props.downloadColor()}>
|
||||
{props.downloadLabel()}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
<text fg={muted()}>
|
||||
Downloaded from episode search — the show is not subscribed.
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>enter: play · D: delete download · h: back</text>
|
||||
</box>
|
||||
);
|
||||
}
|
||||
|
||||
export const MyShowsPaneCount = 1;
|
||||
|
||||
export function MyShowsPage() {
|
||||
@@ -67,7 +259,6 @@ export function MyShowsPage() {
|
||||
// entry drops out the moment the user subscribes to its show.
|
||||
const unsubs = () => downloadStore.getUnsubscribedDownloads();
|
||||
|
||||
// Total depth-0 rows: subscribed shows + unsubscribed-show downloads.
|
||||
const depth0Count = () => shows().length + unsubs().length;
|
||||
|
||||
const focusedShowIdx = () =>
|
||||
@@ -107,7 +298,6 @@ export function MyShowsPage() {
|
||||
depth() >= 1 &&
|
||||
!!drilledShowId() &&
|
||||
feedStore.hasMoreEpisodes(drilledShowId());
|
||||
// Total navigable rows at depth 1: episodes + the optional Fetch More row.
|
||||
const rowCount = () => episodes().length + (showFetchMore() ? 1 : 0);
|
||||
const focusedRow = () =>
|
||||
rowCount() === 0 ? 0 : Math.min(focus(1), rowCount() - 1);
|
||||
@@ -121,7 +311,6 @@ export function MyShowsPage() {
|
||||
: Math.min(focusedRow(), Math.max(episodes().length - 1, 0));
|
||||
const focusedEpisode = () =>
|
||||
focusedOnMore() ? undefined : episodes()[focusedEpIdx()];
|
||||
const moreRef = useScrollIntoView(() => focusedOnMore());
|
||||
|
||||
const curLen = () => (depth() === 0 ? depth0Count() : rowCount());
|
||||
|
||||
@@ -155,12 +344,6 @@ export function MyShowsPage() {
|
||||
});
|
||||
|
||||
// ── helpers ─────────────────────────────────────────────────────────────────
|
||||
const formatDate = (d: Date) => format(d, "MMM d, yyyy");
|
||||
const formatDuration = (s: number) => {
|
||||
const mins = Math.floor(s / 60);
|
||||
const hrs = Math.floor(mins / 60);
|
||||
return hrs > 0 ? `${hrs}h ${mins % 60}m` : `${mins}m`;
|
||||
};
|
||||
const downloadLabel = (id: string) => {
|
||||
switch (downloadStore.getDownloadStatus(id)) {
|
||||
case DownloadStatus.QUEUED:
|
||||
@@ -323,14 +506,6 @@ export function MyShowsPage() {
|
||||
|
||||
// ── render ──────────────────────────────────────────────────────────────────
|
||||
const isActive = () => nav.activePane() === DEPTH_CENTER_PANE;
|
||||
const focusBg = (i: number, lf: number, active: boolean) =>
|
||||
i === lf && active ? theme.primary : i === lf ? theme.border : undefined;
|
||||
const focusFg = (i: number, lf: number, active: boolean) =>
|
||||
i === lf && active
|
||||
? theme.surface
|
||||
: i === lf
|
||||
? theme.selectedListItemText ?? theme.text
|
||||
: theme.text;
|
||||
const showTitle = (f: Feed) => f.customName || f.podcast.title;
|
||||
|
||||
const currentLabel = () =>
|
||||
@@ -349,18 +524,21 @@ export function MyShowsPage() {
|
||||
{(feed, index) => {
|
||||
const lf = () => nav.depthFocus(0);
|
||||
const ref = useScrollIntoView(() => index() === lf());
|
||||
const focused = () => index() === lf();
|
||||
const fg = () =>
|
||||
focused()
|
||||
? theme.selectedListItemText ?? theme.text
|
||||
: theme.text;
|
||||
return (
|
||||
<box
|
||||
ref={ref}
|
||||
flexDirection="row"
|
||||
gap={1}
|
||||
paddingRight={1}
|
||||
backgroundColor={focusBg(index(), lf(), false)}
|
||||
backgroundColor={focused() ? theme.border : undefined}
|
||||
>
|
||||
<text fg={focusFg(index(), lf(), false)}>
|
||||
{index() === lf() ? marker() : " "}
|
||||
</text>
|
||||
<text fg={focusFg(index(), lf(), false)}>{showTitle(feed)}</text>
|
||||
<text fg={fg()}>{focused() ? marker() : " "}</text>
|
||||
<text fg={fg()}>{showTitle(feed)}</text>
|
||||
<text fg={muted()}>({feed.episodes.length})</text>
|
||||
</box>
|
||||
);
|
||||
@@ -385,51 +563,28 @@ export function MyShowsPage() {
|
||||
}
|
||||
>
|
||||
<For each={shows()}>
|
||||
{(feed, index) => {
|
||||
const lf = () => focusedShowIdx();
|
||||
const ref = useScrollIntoView(() => index() === lf());
|
||||
const wlScope =
|
||||
app.state().preferences.autoDownloadScope === "whitelist";
|
||||
const wlInList = (
|
||||
app.state().preferences.autoDownloadWhitelist ?? []
|
||||
).includes(feed.id);
|
||||
return (
|
||||
<box
|
||||
ref={ref}
|
||||
flexDirection="row"
|
||||
gap={1}
|
||||
paddingRight={1}
|
||||
backgroundColor={focusBg(index(), lf(), isActive())}
|
||||
{(feed, index) => (
|
||||
<ShowRow
|
||||
feed={feed}
|
||||
title={showTitle(feed)}
|
||||
index={index}
|
||||
focused={focusedShowIdx}
|
||||
active={isActive}
|
||||
marker={marker}
|
||||
wlScope={() =>
|
||||
app.state().preferences.autoDownloadScope === "whitelist"
|
||||
}
|
||||
wlInList={() =>
|
||||
(app.state().preferences.autoDownloadWhitelist ?? []).includes(
|
||||
feed.id,
|
||||
)
|
||||
}
|
||||
onMouseDown={() => {
|
||||
nav.setActivePane(DEPTH_CENTER_PANE);
|
||||
nav.setDepthFocus(index(), 0);
|
||||
}}
|
||||
>
|
||||
<text fg={focusFg(index(), lf(), isActive())}>
|
||||
{index() === lf() ? marker() : " "}
|
||||
</text>
|
||||
<text fg={focusFg(index(), lf(), isActive())}>
|
||||
{showTitle(feed)}
|
||||
</text>
|
||||
<text fg={index() === lf() ? theme.surface : muted()}>
|
||||
({feed.episodes.length})
|
||||
</text>
|
||||
<Show when={wlScope}>
|
||||
<text
|
||||
fg={
|
||||
index() === lf()
|
||||
? theme.surface
|
||||
: wlInList
|
||||
? theme.warning
|
||||
: muted()
|
||||
}
|
||||
>
|
||||
{wlInList ? "●" : "○"}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
);
|
||||
}}
|
||||
/>
|
||||
)}
|
||||
</For>
|
||||
<Show when={unsubs().length > 0}>
|
||||
<box paddingLeft={1} paddingTop={1}>
|
||||
@@ -438,62 +593,21 @@ export function MyShowsPage() {
|
||||
</text>
|
||||
</box>
|
||||
<For each={unsubs()}>
|
||||
{(d, index) => {
|
||||
// Rows continue after the shows list.
|
||||
const rowIdx = () => shows().length + index();
|
||||
const lf = () => nav.depthFocus(0);
|
||||
const ref = useScrollIntoView(() => rowIdx() === lf());
|
||||
return (
|
||||
<box
|
||||
ref={ref}
|
||||
flexDirection="column"
|
||||
gap={0}
|
||||
paddingRight={1}
|
||||
backgroundColor={focusBg(rowIdx(), lf(), isActive())}
|
||||
{(d, index) => (
|
||||
<UnsubscribedRow
|
||||
d={d}
|
||||
index={() => shows().length + index()}
|
||||
focused={() => nav.depthFocus(0)}
|
||||
active={isActive}
|
||||
marker={marker}
|
||||
downloadLabel={() => downloadLabel(d.episodeId)}
|
||||
downloadColor={() => downloadColor(d.episodeId)}
|
||||
onMouseDown={() => {
|
||||
nav.setActivePane(DEPTH_CENTER_PANE);
|
||||
nav.setDepthFocus(rowIdx(), 0);
|
||||
}}
|
||||
>
|
||||
<box flexDirection="row" gap={1}>
|
||||
<text
|
||||
flexShrink={0}
|
||||
fg={focusFg(rowIdx(), lf(), isActive())}
|
||||
>
|
||||
{rowIdx() === lf() ? marker() : " "}
|
||||
</text>
|
||||
<text
|
||||
wrapMode="none"
|
||||
truncate
|
||||
fg={focusFg(rowIdx(), lf(), isActive())}
|
||||
>
|
||||
{d.episodeTitle ?? d.episodeId}
|
||||
</text>
|
||||
<Show when={downloadLabel(d.episodeId)}>
|
||||
<text
|
||||
flexShrink={0}
|
||||
fg={downloadColor(d.episodeId)}
|
||||
>
|
||||
{downloadLabel(d.episodeId)}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
<box paddingLeft={2}>
|
||||
<text
|
||||
wrapMode="none"
|
||||
truncate
|
||||
fg={
|
||||
rowIdx() === lf()
|
||||
? theme.surface
|
||||
: theme.textSecondary
|
||||
}
|
||||
>
|
||||
{d.podcastTitle ?? d.feedId}
|
||||
</text>
|
||||
</box>
|
||||
</box>
|
||||
);
|
||||
nav.setDepthFocus(shows().length + index(), 0);
|
||||
}}
|
||||
/>
|
||||
)}
|
||||
</For>
|
||||
</Show>
|
||||
</Show>
|
||||
@@ -509,98 +623,37 @@ export function MyShowsPage() {
|
||||
}
|
||||
>
|
||||
<For each={episodes()}>
|
||||
{(ep, index) => {
|
||||
const lf = () => focusedEpIdx();
|
||||
const ref = useScrollIntoView(() => index() === lf());
|
||||
return (
|
||||
<box
|
||||
ref={ref}
|
||||
flexDirection="column"
|
||||
gap={0}
|
||||
paddingRight={1}
|
||||
backgroundColor={focusBg(index(), lf(), isActive())}
|
||||
{(ep, index) => (
|
||||
<EpisodeRow
|
||||
episode={ep}
|
||||
index={index}
|
||||
focused={focusedEpIdx}
|
||||
active={isActive}
|
||||
selected={() => nav.isSelected(ep.id)}
|
||||
downloadLabel={() => downloadLabel(ep.id)}
|
||||
downloadColor={() => downloadColor(ep.id)}
|
||||
marker={marker}
|
||||
onMouseDown={() => {
|
||||
nav.setActivePane(DEPTH_CENTER_PANE);
|
||||
nav.setDepthFocus(index(), 1);
|
||||
}}
|
||||
>
|
||||
<box flexDirection="row" gap={1}>
|
||||
<text
|
||||
flexShrink={0}
|
||||
fg={focusFg(index(), lf(), isActive())}
|
||||
>
|
||||
{index() === lf() ? marker() : " "}
|
||||
</text>
|
||||
<text
|
||||
wrapMode="none"
|
||||
truncate
|
||||
fg={focusFg(index(), lf(), isActive())}
|
||||
>
|
||||
{ep.episodeNumber ? `#${ep.episodeNumber} ` : ""}
|
||||
{ep.title}
|
||||
</text>
|
||||
</box>
|
||||
<box flexDirection="row" gap={2} paddingLeft={2}>
|
||||
<text
|
||||
flexShrink={0}
|
||||
fg={index() === lf() ? theme.surface : theme.info}
|
||||
>
|
||||
{formatDate(ep.pubDate)}
|
||||
</text>
|
||||
<text
|
||||
flexShrink={0}
|
||||
fg={index() === lf() ? theme.surface : muted()}
|
||||
>
|
||||
{formatDuration(ep.duration)}
|
||||
</text>
|
||||
<Show when={nav.isSelected(ep.id)}>
|
||||
<text flexShrink={0} fg={theme.warning}>
|
||||
●
|
||||
</text>
|
||||
</Show>
|
||||
<Show when={downloadLabel(ep.id)}>
|
||||
<text flexShrink={0} fg={downloadColor(ep.id)}>
|
||||
{downloadLabel(ep.id)}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
</box>
|
||||
);
|
||||
}}
|
||||
/>
|
||||
)}
|
||||
</For>
|
||||
<Show when={showFetchMore()}>
|
||||
<box
|
||||
ref={moreRef}
|
||||
flexDirection="row"
|
||||
gap={1}
|
||||
paddingRight={1}
|
||||
backgroundColor={focusBg(
|
||||
episodes().length,
|
||||
focusedRow(),
|
||||
isActive(),
|
||||
)}
|
||||
<FetchMoreRow
|
||||
index={() => episodes().length}
|
||||
focused={focusedRow}
|
||||
onMore={focusedOnMore}
|
||||
active={isActive}
|
||||
isLoadingMore={() => feedStore.isLoadingMore()}
|
||||
nerd={nerd}
|
||||
marker={marker}
|
||||
onMouseDown={() => {
|
||||
nav.setActivePane(DEPTH_CENTER_PANE);
|
||||
nav.setDepthFocus(episodes().length, 1);
|
||||
}}
|
||||
>
|
||||
<text fg={focusFg(episodes().length, focusedRow(), isActive())}>
|
||||
{focusedOnMore() ? marker() : " "}
|
||||
</text>
|
||||
{nerd && (
|
||||
<text fg={focusFg(episodes().length, focusedRow(), isActive())}>
|
||||
{NF_ICONS.more}
|
||||
</text>
|
||||
)}
|
||||
<Show
|
||||
when={!feedStore.isLoadingMore()}
|
||||
fallback={<LoadingIndicator label="Fetching…" />}
|
||||
>
|
||||
<text fg={focusFg(episodes().length, focusedRow(), isActive())}>
|
||||
[Fetch More]
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
/>
|
||||
</Show>
|
||||
</Show>
|
||||
</Show>
|
||||
@@ -608,6 +661,30 @@ export function MyShowsPage() {
|
||||
);
|
||||
|
||||
// ── preview pane ───────────────────────────────────────────────────────────
|
||||
const episodeHint = (epId: string) =>
|
||||
`enter: play · d: download${
|
||||
downloadStore.getDownloadStatus(epId) !== DownloadStatus.NONE
|
||||
? " · D: delete"
|
||||
: ""
|
||||
}${
|
||||
app.state().preferences.autoDownloadScope === "whitelist"
|
||||
? (app.state().preferences.autoDownloadWhitelist ?? []).includes(
|
||||
drilledShowId(),
|
||||
)
|
||||
? " · w: un-whitelist"
|
||||
: " · w: whitelist"
|
||||
: ""
|
||||
} · space: select · h: back`;
|
||||
|
||||
const showHint = (show: Feed) =>
|
||||
`enter/l: open · h: back · x: unsubscribe${
|
||||
app.state().preferences.autoDownloadScope === "whitelist"
|
||||
? (app.state().preferences.autoDownloadWhitelist ?? []).includes(show.id)
|
||||
? " · w: un-whitelist"
|
||||
: " · w: whitelist"
|
||||
: ""
|
||||
}`;
|
||||
|
||||
const previewContent = () =>
|
||||
depth() === 0 ? (
|
||||
// depth 0 preview: hovered unsubscribed-show download, else the
|
||||
@@ -624,86 +701,34 @@ export function MyShowsPage() {
|
||||
}
|
||||
>
|
||||
{(show) => (
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>{showTitle(show())}</strong>
|
||||
</text>
|
||||
<Show when={show().podcast.author}>
|
||||
<text fg={muted()}>by {show().podcast.author}</text>
|
||||
</Show>
|
||||
<text fg={theme.textSecondary}>
|
||||
{show().episodes.length} episodes
|
||||
</text>
|
||||
<text fg={muted()}>
|
||||
{show().podcast.description?.slice(0, 400) ??
|
||||
"No description."}
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>
|
||||
enter/l: open · h: back · x: unsubscribe
|
||||
{app.state().preferences.autoDownloadScope ===
|
||||
"whitelist"
|
||||
? (app.state().preferences.autoDownloadWhitelist ??
|
||||
[]
|
||||
).includes(show().id)
|
||||
? " · w: un-whitelist"
|
||||
: " · w: whitelist"
|
||||
: ""}
|
||||
</text>
|
||||
</box>
|
||||
<ShowPreview
|
||||
show={() => show()}
|
||||
title={() => showTitle(show())}
|
||||
hint={() => showHint(show())}
|
||||
/>
|
||||
)}
|
||||
</Show>
|
||||
}
|
||||
>
|
||||
{(d) => (
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>{d().episodeTitle ?? d().episodeId}</strong>
|
||||
</text>
|
||||
<text fg={theme.textSecondary}>
|
||||
{d().podcastTitle ?? d().feedId}
|
||||
</text>
|
||||
<box flexDirection="row" gap={2}>
|
||||
<Show when={d().pubDate}>
|
||||
<text fg={theme.info}>
|
||||
{formatDate(new Date(d().pubDate!))}
|
||||
</text>
|
||||
</Show>
|
||||
<Show when={downloadLabel(d().episodeId)}>
|
||||
<text fg={downloadColor(d().episodeId)}>
|
||||
{downloadLabel(d().episodeId)}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
<text fg={muted()}>
|
||||
Downloaded from episode search — the show is not
|
||||
subscribed.
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>
|
||||
enter: play · D: delete download · h: back
|
||||
</text>
|
||||
</box>
|
||||
<UnsubscribedPreview
|
||||
d={() => d()}
|
||||
downloadLabel={() => downloadLabel(d().episodeId)}
|
||||
downloadColor={() => downloadColor(d().episodeId)}
|
||||
/>
|
||||
)}
|
||||
</Show>
|
||||
) : (
|
||||
// depth ≥1 preview: hovered episode (or the Fetch More row)
|
||||
<>
|
||||
<Show when={focusedOnMore()}>
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>[Fetch More]</strong>
|
||||
</text>
|
||||
<text fg={muted()}>
|
||||
{feedStore.isLoadingMore()
|
||||
? "Loading the next batch of episodes…"
|
||||
: fetchMoreMode() === "auto"
|
||||
? "Auto mode: the next batch loads automatically at the bottom of the list."
|
||||
: "Load the next batch of older episodes for this show (Enter)."}
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>enter: load more · h back</text>
|
||||
</box>
|
||||
<FetchMorePreview
|
||||
isLoadingMore={() => feedStore.isLoadingMore()}
|
||||
fetchMoreMode={fetchMoreMode}
|
||||
manualText={() =>
|
||||
"Load the next batch of older episodes for this show (Enter)."
|
||||
}
|
||||
/>
|
||||
</Show>
|
||||
<Show when={!focusedOnMore()}>
|
||||
<Show
|
||||
@@ -715,47 +740,13 @@ export function MyShowsPage() {
|
||||
}
|
||||
>
|
||||
{(ep) => (
|
||||
<box flexDirection="column" gap={1} padding={1}>
|
||||
<text fg={theme.textPrimary ?? theme.text}>
|
||||
<strong>
|
||||
{ep().episodeNumber ? `#${ep().episodeNumber} ` : ""}
|
||||
{ep().title}
|
||||
</strong>
|
||||
</text>
|
||||
<box flexDirection="row" gap={2}>
|
||||
<text fg={theme.info}>{formatDate(ep().pubDate)}</text>
|
||||
<text fg={muted()}>{formatDuration(ep().duration)}</text>
|
||||
<Show when={downloadLabel(ep().id)}>
|
||||
<text fg={downloadColor(ep().id)}>
|
||||
{downloadLabel(ep().id)}
|
||||
</text>
|
||||
</Show>
|
||||
</box>
|
||||
<Show when={selectedShow()?.podcast.author}>
|
||||
<text fg={muted()}>by {selectedShow()!.podcast.author}</text>
|
||||
</Show>
|
||||
<box height={1} />
|
||||
<text fg={theme.textSecondary}>
|
||||
{ep().description?.slice(0, 400) ?? "No description available."}
|
||||
{(ep().description?.length ?? 0) > 400 ? "…" : ""}
|
||||
</text>
|
||||
<box height={1} />
|
||||
<text fg={muted()}>
|
||||
enter: play · d: download
|
||||
{downloadStore.getDownloadStatus(ep().id) !==
|
||||
DownloadStatus.NONE
|
||||
? " · D: delete"
|
||||
: ""}
|
||||
{app.state().preferences.autoDownloadScope === "whitelist"
|
||||
? (app.state().preferences.autoDownloadWhitelist ?? []).includes(
|
||||
drilledShowId(),
|
||||
)
|
||||
? " · w: un-whitelist"
|
||||
: " · w: whitelist"
|
||||
: ""}{" "}
|
||||
· space: select · h: back
|
||||
</text>
|
||||
</box>
|
||||
<EpisodePreview
|
||||
episode={() => ep()}
|
||||
author={() => selectedShow()?.podcast.author}
|
||||
downloadLabel={() => downloadLabel(ep().id)}
|
||||
downloadColor={() => downloadColor(ep().id)}
|
||||
hint={() => episodeHint(ep().id)}
|
||||
/>
|
||||
)}
|
||||
</Show>
|
||||
</Show>
|
||||
|
||||
@@ -77,30 +77,15 @@ function SearchPage() {
|
||||
const submittedQuery = (): string => stack()[1]?.ctx ?? searchStore.query();
|
||||
|
||||
// ── input focusing ────────────────────────────────────────────────────────
|
||||
// `inputFocused` is true while the query input is being typed in. The Shell
|
||||
// router yields keys to the <input> while this is true; Escape (in Shell)
|
||||
// sets it false so navigation resumes; `s` (search action) sets it true.
|
||||
//
|
||||
// The input's REAL focus is the source of truth for the flag:
|
||||
// useInputFocusNav (the same hook the Settings forms use) flips
|
||||
// `inputFocused` from the input's FOCUSED/BLURRED events, keeping the flag
|
||||
// and the renderable in lockstep. That matters when the user clicks OFF the
|
||||
// input: opentui's mouse dispatch auto-focuses the clicked target's nearest
|
||||
// focusable ancestor (a pane scrollbox), blurring the input. The BLURRED
|
||||
// event drops the flag, so the Shell router immediately resumes j/k/h
|
||||
// instead of swallowing keys with no input to receive them — no more
|
||||
// stuck "typing" state where Esc/j/k/s all do nothing.
|
||||
//
|
||||
// The depth stack still SEEDS the flag on transitions, since the query
|
||||
// depth defaults to typing: re-entering depth 0 (h back from results, or a
|
||||
// fresh mount) focuses the input; mounting at depth 1 (returning to the
|
||||
// tab after a search) stays list-navigation — a stuck-on flag there would
|
||||
// have the Shell yield j/k to a non-existent input. The depth STACK signal
|
||||
// is also written by focus moves (setDepthFocus), so gate the seed on the
|
||||
// depth VALUE via a memo: the effect must re-run only on an actual depth
|
||||
// transition. Without the memo every j/k at the query depth re-focuses the
|
||||
// input (undoing Escape), which keeps the recents list unreachable by
|
||||
// keyboard.
|
||||
// `inputFocused` tells the Shell router to yield keys to the query input.
|
||||
// The input's REAL focus is the source of truth: useInputFocusNav flips
|
||||
// the flag from the input's FOCUSED/BLURRED events, so clicking off the
|
||||
// input drops it and the router resumes j/k/h — no stuck "typing" state.
|
||||
// The depth stack only SEEDS it on transitions (re-entering depth 0
|
||||
// focuses the input; mounting at depth 1 stays list-nav), gated on the
|
||||
// depth VALUE via a memo because setDepthFocus also writes the stack
|
||||
// signal — without the memo every j/k at query depth re-focuses the input
|
||||
// and strands the recents list.
|
||||
onMount(() => nav.setInputFocused(depth() === 0));
|
||||
onCleanup(() => nav.setInputFocused(false));
|
||||
const focusNavRef = useInputFocusNav();
|
||||
|
||||
@@ -4,13 +4,15 @@
|
||||
* driven by the Shell router via nav.action.
|
||||
*
|
||||
* Auto-download (global setting, see stores/feed.ts runAutoDownload):
|
||||
* • Auto Download — master toggle (default: off)
|
||||
* • Auto Download Count — X most recent episodes per show (default: 2,
|
||||
* any positive integer — type it in the editor)
|
||||
* • Auto Download Scope — which shows: all / none / whitelist (default: all)
|
||||
* • Auto Download Whitelist — shown only when scope is "whitelist": search
|
||||
* field over subscribed shows; suggestions toggle
|
||||
* in/out with Space (j/k to move, Esc to browse).
|
||||
* • Episode Cache Mode — date or count bound for the episode list
|
||||
* (default: date)
|
||||
* • Episode Cache Count — N most recent episodes when mode is count
|
||||
* (default: 25)
|
||||
* • Episode Cache Days — rolling N-day window when mode is date
|
||||
* (default: 60)
|
||||
*/
|
||||
|
||||
import { createSignal, Show, For, onMount, onCleanup } from "solid-js";
|
||||
@@ -30,7 +32,7 @@ import {
|
||||
import { on } from "@/utils/event-bus";
|
||||
import type { KeybindActionName } from "@/context/KeybindContext";
|
||||
import { TABS } from "@/utils/navigation";
|
||||
import type { AutoDownloadScope, ThemeName } from "@/types/settings";
|
||||
import type { AutoDownloadScope, EpisodeCacheMode, ThemeName } from "@/types/settings";
|
||||
import type { Feed } from "@/types/feed";
|
||||
import type { SettingItem } from "./types";
|
||||
|
||||
@@ -48,6 +50,14 @@ const SCOPE_LABELS: Array<{ value: AutoDownloadScope; label: string }> = [
|
||||
{ value: "none", label: "None" },
|
||||
{ value: "whitelist", label: "Whitelist" },
|
||||
];
|
||||
const CACHE_MODE_LABELS: Array<{ value: EpisodeCacheMode; label: string }> = [
|
||||
{ value: "date", label: "Date" },
|
||||
{ value: "count", label: "Count" },
|
||||
];
|
||||
|
||||
function cacheModeLabel(mode: EpisodeCacheMode): string {
|
||||
return CACHE_MODE_LABELS.find((s) => s.value === mode)?.label ?? mode;
|
||||
}
|
||||
|
||||
function scopeLabel(scope: AutoDownloadScope): string {
|
||||
return SCOPE_LABELS.find((s) => s.value === scope)?.label ?? scope;
|
||||
@@ -205,6 +215,79 @@ export function usePreferencesItems(): SettingItem[] {
|
||||
autoJumpToPlayer: !prefs().autoJumpToPlayer,
|
||||
}),
|
||||
},
|
||||
{
|
||||
id: "episodeCacheMode",
|
||||
label: "Episode Cache Mode",
|
||||
kind: "select",
|
||||
display: () => cacheModeLabel(prefs().episodeCacheMode),
|
||||
help: () =>
|
||||
`How the Feed and My Shows episode lists are bounded.\nDate: keep episodes from the last N days (see Cache Days below).\nCount: keep the N most recent episodes (see Cache Count below).\nFetch More always pages beyond this bound — these episodes are volatile and don't persist.\nType: select\nDefault: date\nCurrent: ${cacheModeLabel(prefs().episodeCacheMode)}\nCycle with j/k; Enter to apply.`,
|
||||
cycle: (dir) => {
|
||||
const idx = CACHE_MODE_LABELS.findIndex(
|
||||
(s) => s.value === prefs().episodeCacheMode,
|
||||
);
|
||||
const next =
|
||||
CACHE_MODE_LABELS[
|
||||
(idx + dir + CACHE_MODE_LABELS.length) % CACHE_MODE_LABELS.length
|
||||
].value;
|
||||
app.updatePreferences({ episodeCacheMode: next });
|
||||
},
|
||||
},
|
||||
{
|
||||
id: "episodeCacheCount",
|
||||
label: "Episode Cache Count",
|
||||
kind: "number",
|
||||
display: () =>
|
||||
prefs().episodeCacheMode === "count"
|
||||
? `${prefs().episodeCacheCount} eps`
|
||||
: "(date mode)",
|
||||
help: () =>
|
||||
`Number of most-recent episodes to keep in the Feed/My Shows lists when mode is Count.\nType: number (any positive integer)\nDefault: 25\nCurrent: ${prefs().episodeCacheCount}\nj/k to −/+1 · Enter to type a value.`,
|
||||
cycle: (dir) => {
|
||||
const next = Math.max(1, prefs().episodeCacheCount + dir);
|
||||
app.updatePreferences({ episodeCacheCount: next });
|
||||
},
|
||||
renderEditor: () => (
|
||||
<NumberInputEditor
|
||||
label="Episode Cache Count"
|
||||
value={() => prefs().episodeCacheCount}
|
||||
commit={(n) => {
|
||||
app.updatePreferences({
|
||||
episodeCacheCount: Math.max(1, n),
|
||||
});
|
||||
}}
|
||||
/>
|
||||
),
|
||||
},
|
||||
{
|
||||
id: "episodeCacheDays",
|
||||
label: "Episode Cache Days",
|
||||
kind: "number",
|
||||
display: () =>
|
||||
prefs().episodeCacheMode === "date"
|
||||
? `${prefs().episodeCacheDays} days`
|
||||
: "(count mode)",
|
||||
help: () =>
|
||||
`Rolling window in days for the Feed/My Shows episode lists when mode is Date.\nType: number (1–365)\nDefault: 60\nCurrent: ${prefs().episodeCacheDays} days\nj/k to −/+5 · Enter to type a value.`,
|
||||
cycle: (dir) => {
|
||||
const next = Math.min(
|
||||
365,
|
||||
Math.max(1, prefs().episodeCacheDays + dir * 5),
|
||||
);
|
||||
app.updatePreferences({ episodeCacheDays: next });
|
||||
},
|
||||
renderEditor: () => (
|
||||
<NumberInputEditor
|
||||
label="Episode Cache Days"
|
||||
value={() => prefs().episodeCacheDays}
|
||||
commit={(n) => {
|
||||
app.updatePreferences({
|
||||
episodeCacheDays: Math.min(365, Math.max(1, n)),
|
||||
});
|
||||
}}
|
||||
/>
|
||||
),
|
||||
},
|
||||
{
|
||||
id: "fetchMore",
|
||||
label: "Fetch More",
|
||||
|
||||
@@ -140,7 +140,6 @@ export function SettingsPage() {
|
||||
function open() {
|
||||
const d = depth();
|
||||
if (d === 0) {
|
||||
// drill into the focused section's items
|
||||
const id = focusedSection().id;
|
||||
nav.pushDepth({
|
||||
kind: `settings:${id}`,
|
||||
@@ -206,7 +205,6 @@ export function SettingsPage() {
|
||||
function step(delta: number) {
|
||||
const d = depth();
|
||||
if (d === 2) {
|
||||
// editor: j/k nudges the value
|
||||
const it = editorItem();
|
||||
if (it?.kind === "number" || it?.kind === "select")
|
||||
it.cycle?.(delta as -1 | 1);
|
||||
@@ -220,7 +218,6 @@ export function SettingsPage() {
|
||||
pane: PaneId;
|
||||
mode: NavMode;
|
||||
}) => {
|
||||
// ignore actions meant for non-center panes
|
||||
if (data.pane !== DEPTH_CENTER_PANE) return;
|
||||
if (nav.activePane() !== DEPTH_CENTER_PANE) return;
|
||||
const handler = PAGE_ACTIONS[data.action];
|
||||
|
||||
@@ -10,7 +10,6 @@
|
||||
|
||||
import { createSignal } from "solid-js";
|
||||
|
||||
/** Create activity store */
|
||||
function createActivityStore() {
|
||||
const [count, setCount] = createSignal(0);
|
||||
const [labels, setLabels] = createSignal<string[]>([]);
|
||||
@@ -64,7 +63,6 @@ function createActivityStore() {
|
||||
};
|
||||
}
|
||||
|
||||
/** Singleton activity store */
|
||||
let activityStoreInstance: ReturnType<typeof createActivityStore> | null = null;
|
||||
|
||||
export function useActivityStore() {
|
||||
|
||||
@@ -45,6 +45,9 @@ const defaultPreferences: UserPreferences = {
|
||||
autoJumpToPlayer: true,
|
||||
fetchMoreMode: "auto",
|
||||
refreshIntervalMinutes: 30,
|
||||
episodeCacheMode: "date",
|
||||
episodeCacheCount: 25,
|
||||
episodeCacheDays: 60,
|
||||
};
|
||||
|
||||
const defaultState: AppState = {
|
||||
|
||||
@@ -9,14 +9,12 @@ import {
|
||||
saveAudioNavToFile,
|
||||
} from "../utils/app-persistence";
|
||||
|
||||
/** Source type for audio navigation */
|
||||
export enum AudioSource {
|
||||
FEED = "feed",
|
||||
MY_SHOWS = "my_shows",
|
||||
SEARCH = "search",
|
||||
}
|
||||
|
||||
/** Audio navigation state */
|
||||
export interface AudioNavState {
|
||||
/** Current source type */
|
||||
source: AudioSource;
|
||||
@@ -28,14 +26,12 @@ export interface AudioNavState {
|
||||
lastUpdated: Date;
|
||||
}
|
||||
|
||||
/** Default navigation state */
|
||||
const defaultNavState: AudioNavState = {
|
||||
source: AudioSource.FEED,
|
||||
currentIndex: 0,
|
||||
lastUpdated: new Date(),
|
||||
};
|
||||
|
||||
/** Create audio navigation store */
|
||||
function createAudioNavStore() {
|
||||
const [navState, setNavState] = createSignal<AudioNavState>(defaultNavState);
|
||||
|
||||
@@ -56,12 +52,10 @@ function createAudioNavStore() {
|
||||
init();
|
||||
|
||||
return {
|
||||
/** Get current navigation state */
|
||||
get state(): AudioNavState {
|
||||
return navState();
|
||||
},
|
||||
|
||||
/** Update source type */
|
||||
setSource: (source: AudioSource, podcastId?: string) => {
|
||||
setNavState((prev) => ({
|
||||
...prev,
|
||||
@@ -72,7 +66,6 @@ function createAudioNavStore() {
|
||||
persist();
|
||||
},
|
||||
|
||||
/** Move to next episode */
|
||||
next: (currentIndex: number) => {
|
||||
setNavState((prev) => ({
|
||||
...prev,
|
||||
@@ -82,7 +75,6 @@ function createAudioNavStore() {
|
||||
persist();
|
||||
},
|
||||
|
||||
/** Move to previous episode */
|
||||
prev: (currentIndex: number) => {
|
||||
setNavState((prev) => ({
|
||||
...prev,
|
||||
@@ -92,23 +84,19 @@ function createAudioNavStore() {
|
||||
persist();
|
||||
},
|
||||
|
||||
/** Reset to default state */
|
||||
reset: () => {
|
||||
setNavState(defaultNavState);
|
||||
persist();
|
||||
},
|
||||
|
||||
/** Get current index */
|
||||
getCurrentIndex: (): number => {
|
||||
return navState().currentIndex;
|
||||
},
|
||||
|
||||
/** Get current source */
|
||||
getSource: (): AudioSource => {
|
||||
return navState().source;
|
||||
},
|
||||
|
||||
/** Get current podcast ID */
|
||||
getPodcastId: (): string | undefined => {
|
||||
return navState().podcastId;
|
||||
},
|
||||
|
||||
@@ -85,7 +85,6 @@ function syncSubscriptionState(
|
||||
}));
|
||||
}
|
||||
|
||||
/** Create discover store */
|
||||
export function createDiscoverStore() {
|
||||
const [selectedCategory, setSelectedCategory] = createSignal<string>("all");
|
||||
const [isLoading, setIsLoading] = createSignal(false);
|
||||
@@ -107,7 +106,6 @@ export function createDiscoverStore() {
|
||||
const refresh = async () => {
|
||||
setIsLoading(true);
|
||||
try {
|
||||
// Skip if cache is still fresh
|
||||
const now = Date.now();
|
||||
if (now - cachedAt < FEATURED_CACHE_TTL_MS) {
|
||||
syncSubscriptions();
|
||||
@@ -131,7 +129,6 @@ export function createDiscoverStore() {
|
||||
cachedAt = now;
|
||||
setPodcasts(fetched);
|
||||
|
||||
// Reflect current feed-store subscriptions
|
||||
syncSubscriptions();
|
||||
} catch {
|
||||
// Network failure — keep whatever we have (stale or empty)
|
||||
@@ -140,7 +137,6 @@ export function createDiscoverStore() {
|
||||
}
|
||||
};
|
||||
|
||||
/** Get filtered podcasts by category */
|
||||
const filteredPodcasts = () => {
|
||||
const category = selectedCategory();
|
||||
if (category === "all") {
|
||||
@@ -155,7 +151,6 @@ export function createDiscoverStore() {
|
||||
});
|
||||
};
|
||||
|
||||
/** Subscribe to a podcast */
|
||||
const subscribe = (podcastId: string) => {
|
||||
const podcast = podcasts().find((p) => p.id === podcastId);
|
||||
if (podcast) {
|
||||
@@ -168,7 +163,6 @@ export function createDiscoverStore() {
|
||||
);
|
||||
};
|
||||
|
||||
/** Unsubscribe from a podcast */
|
||||
const unsubscribe = (podcastId: string) => {
|
||||
const podcast = podcasts().find((p) => p.id === podcastId);
|
||||
if (podcast) {
|
||||
@@ -180,7 +174,6 @@ export function createDiscoverStore() {
|
||||
);
|
||||
};
|
||||
|
||||
/** Toggle subscription */
|
||||
const toggleSubscription = (podcastId: string) => {
|
||||
const podcast = podcasts().find((p) => p.id === podcastId);
|
||||
if (podcast?.isSubscribed) {
|
||||
@@ -207,7 +200,6 @@ export function createDiscoverStore() {
|
||||
};
|
||||
}
|
||||
|
||||
/** Singleton discover store */
|
||||
let discoverStoreInstance: ReturnType<typeof createDiscoverStore> | null = null;
|
||||
|
||||
export function useDiscoverStore() {
|
||||
|
||||
@@ -63,7 +63,62 @@ interface QueueItem {
|
||||
episodeTitle: string;
|
||||
}
|
||||
|
||||
/** Create download store */
|
||||
// ── post-download decoration ─────────────────────────────────────────────────
|
||||
/** Write the podcast cover beside the audio so mpv's --cover-art-auto=exact
|
||||
* picks it up for Now Playing art when the local file plays (same basename,
|
||||
* .jpg extension — verified against mpv 0.41). curl, NOT fetch: Bun's fetch
|
||||
* hangs in compiled binaries, so the shipped app never wrote this file. */
|
||||
function writeCoverArt(filePath: string, coverUrl: string): void {
|
||||
const dot = filePath.lastIndexOf(".");
|
||||
if (dot <= 0) return;
|
||||
const coverPath = filePath.slice(0, dot) + ".jpg";
|
||||
Bun.spawn([
|
||||
"curl",
|
||||
"-sS",
|
||||
"--fail",
|
||||
"-m",
|
||||
"8",
|
||||
"--max-filesize",
|
||||
"2097152",
|
||||
"-o",
|
||||
coverPath,
|
||||
coverUrl,
|
||||
])
|
||||
.exited.catch(() => {});
|
||||
}
|
||||
|
||||
/** Tag the local file (codec-copy, no re-encode) so mpv's Now Playing
|
||||
* metadata for local playback is title=episode, artist=podcast — the source
|
||||
* streams carry no usable tags and macOS composes "title - artist" from
|
||||
* exactly these fields. Atomic: ffmpeg writes a temp file, then renames
|
||||
* into place. */
|
||||
function tagLocalFile(
|
||||
filePath: string,
|
||||
episode: Episode,
|
||||
podcastTitle: string,
|
||||
): void {
|
||||
const tmp = `${filePath}.tag.mp3`;
|
||||
Bun.spawn([
|
||||
"ffmpeg",
|
||||
"-y",
|
||||
"-i",
|
||||
filePath,
|
||||
"-c",
|
||||
"copy",
|
||||
"-metadata",
|
||||
`title=${episode.title}`,
|
||||
"-metadata",
|
||||
`artist=${podcastTitle}`,
|
||||
tmp,
|
||||
])
|
||||
.exited.then(async (code) => {
|
||||
if (code !== 0) return;
|
||||
const { renameSync } = await import("node:fs");
|
||||
renameSync(tmp, filePath);
|
||||
})
|
||||
.catch(() => {});
|
||||
}
|
||||
|
||||
function createDownloadStore() {
|
||||
const [downloads, setDownloads] = createSignal<
|
||||
Map<string, DownloadedEpisode>
|
||||
@@ -195,7 +250,6 @@ function createDownloadStore() {
|
||||
}
|
||||
}
|
||||
|
||||
/** Execute a single download */
|
||||
async function executeDownload(item: QueueItem): Promise<void> {
|
||||
const controller = new AbortController();
|
||||
abortControllers.set(item.episodeId, controller);
|
||||
@@ -236,70 +290,23 @@ function createDownloadStore() {
|
||||
error: null,
|
||||
});
|
||||
|
||||
// Write the podcast cover beside the audio so mpv's
|
||||
// --cover-art-auto=exact picks it up for Now Playing art when the
|
||||
// local file plays (same basename, .jpg extension — verified
|
||||
// against mpv 0.41). curl, NOT fetch: Bun's fetch hangs in
|
||||
// compiled binaries, so the shipped app never wrote this file.
|
||||
// Falls back to the episode's own image when the feed has no
|
||||
// channel cover (URL-added feeds).
|
||||
// Decorate the local file: cover art + ID3 tags (see the
|
||||
// module-level helpers above) — the source streams carry neither.
|
||||
// Cover falls back to the episode's own image when the feed has
|
||||
// no channel cover (URL-added feeds).
|
||||
const feedStore = useFeedStore();
|
||||
const episode = feedStore.findEpisode(item.episodeId);
|
||||
const coverUrl =
|
||||
feedStore
|
||||
.feeds()
|
||||
.find((f) => f.id === item.feedId)?.podcast.coverUrl ??
|
||||
episode?.imageUrl;
|
||||
if (coverUrl && result.filePath) {
|
||||
const dot = result.filePath.lastIndexOf(".");
|
||||
if (dot > 0) {
|
||||
const coverPath = result.filePath.slice(0, dot) + ".jpg";
|
||||
Bun.spawn([
|
||||
"curl",
|
||||
"-sS",
|
||||
"--fail",
|
||||
"-m",
|
||||
"8",
|
||||
"--max-filesize",
|
||||
"2097152",
|
||||
"-o",
|
||||
coverPath,
|
||||
coverUrl,
|
||||
])
|
||||
.exited.catch(() => {});
|
||||
const feed = feedStore.feeds().find((f) => f.id === item.feedId);
|
||||
const coverUrl = feed?.podcast.coverUrl ?? episode?.imageUrl;
|
||||
if (result.filePath && coverUrl) {
|
||||
writeCoverArt(result.filePath, coverUrl);
|
||||
}
|
||||
}
|
||||
|
||||
// Tag the local file (codec-copy, no re-encode) so mpv's Now
|
||||
// Playing metadata for local playback is title=episode,
|
||||
// artist=podcast — the source streams carry no usable tags and
|
||||
// macOS composes "title - artist" from exactly these fields.
|
||||
// Atomic: ffmpeg writes a temp file, then renames into place.
|
||||
if (result.filePath && episode) {
|
||||
const podcastTitle =
|
||||
feedStore.feeds().find((f) => f.id === item.feedId)?.podcast.title ??
|
||||
feed?.podcast.title ??
|
||||
downloads().get(item.episodeId)?.podcastTitle;
|
||||
if (podcastTitle) {
|
||||
const tmp = `${result.filePath}.tag.mp3`;
|
||||
Bun.spawn([
|
||||
"ffmpeg",
|
||||
"-y",
|
||||
"-i",
|
||||
result.filePath,
|
||||
"-c",
|
||||
"copy",
|
||||
"-metadata",
|
||||
`title=${episode.title}`,
|
||||
"-metadata",
|
||||
`artist=${podcastTitle}`,
|
||||
tmp,
|
||||
])
|
||||
.exited.then(async (code) => {
|
||||
if (code !== 0) return;
|
||||
const { renameSync } = await import("node:fs");
|
||||
renameSync(tmp, result.filePath);
|
||||
})
|
||||
.catch(() => {});
|
||||
tagLocalFile(result.filePath, episode, podcastTitle);
|
||||
}
|
||||
}
|
||||
} else {
|
||||
@@ -315,22 +322,18 @@ function createDownloadStore() {
|
||||
processQueue();
|
||||
}
|
||||
|
||||
/** Get download status for an episode */
|
||||
const getDownloadStatus = (episodeId: string): DownloadStatus => {
|
||||
return downloads().get(episodeId)?.status ?? DownloadStatus.NONE;
|
||||
};
|
||||
|
||||
/** Get download progress for an episode (0-100) */
|
||||
const getDownloadProgress = (episodeId: string): number => {
|
||||
return downloads().get(episodeId)?.progress ?? 0;
|
||||
};
|
||||
|
||||
/** Get full download info for an episode */
|
||||
const getDownload = (episodeId: string): DownloadedEpisode | undefined => {
|
||||
return downloads().get(episodeId);
|
||||
};
|
||||
|
||||
/** Get the local file path for a completed download */
|
||||
const getDownloadedFilePath = (episodeId: string): string | null => {
|
||||
const dl = downloads().get(episodeId);
|
||||
if (dl?.status === DownloadStatus.COMPLETED && dl.filePath) {
|
||||
@@ -347,7 +350,6 @@ function createDownloadStore() {
|
||||
podcastFeedUrl?: string;
|
||||
}
|
||||
|
||||
/** Start downloading an episode */
|
||||
const startDownload = (
|
||||
episode: Episode,
|
||||
feedId: string,
|
||||
@@ -411,7 +413,6 @@ function createDownloadStore() {
|
||||
});
|
||||
};
|
||||
|
||||
/** Cancel a download */
|
||||
const cancelDownload = (episodeId: string): void => {
|
||||
// Abort active download
|
||||
const controller = abortControllers.get(episodeId);
|
||||
@@ -432,7 +433,6 @@ function createDownloadStore() {
|
||||
saveDownloads().catch(() => {});
|
||||
};
|
||||
|
||||
/** Remove a completed download (delete file and metadata) */
|
||||
const removeDownload = async (episodeId: string): Promise<void> => {
|
||||
const dl = downloads().get(episodeId);
|
||||
if (dl?.filePath) {
|
||||
@@ -478,7 +478,6 @@ function createDownloadStore() {
|
||||
}
|
||||
};
|
||||
|
||||
/** Get all downloads as an array */
|
||||
const getAllDownloads = (): DownloadedEpisode[] => {
|
||||
return Array.from(downloads().values());
|
||||
};
|
||||
@@ -501,12 +500,10 @@ function createDownloadStore() {
|
||||
});
|
||||
};
|
||||
|
||||
/** Get the current queue */
|
||||
const getQueue = (): QueueItem[] => {
|
||||
return queue();
|
||||
};
|
||||
|
||||
/** Get count of active downloads */
|
||||
const getActiveCount = (): number => {
|
||||
return activeCount();
|
||||
};
|
||||
@@ -531,7 +528,6 @@ function createDownloadStore() {
|
||||
};
|
||||
}
|
||||
|
||||
/** Singleton download store */
|
||||
let downloadStoreInstance: ReturnType<typeof createDownloadStore> | null = null;
|
||||
|
||||
export function useDownloadStore() {
|
||||
|
||||
@@ -13,8 +13,9 @@ import { DEFAULT_SOURCES } from "../types/source";
|
||||
import { getRSSItems, parseRSSItem, parseChannelCoverUrl } from "../api/rss-parser";
|
||||
import { resolveItunesFeedUrl } from "../utils/itunes-feed-resolver";
|
||||
import { savePodcastIndexCredentials } from "../utils/source-credentials";
|
||||
import { mergeEpisodes } from "../utils/episode-merge";
|
||||
import { mergeEpisodesBounded } from "../utils/episode-merge";
|
||||
import {
|
||||
episodeInWindow,
|
||||
loadFeedsFromFile,
|
||||
saveFeedsToFile,
|
||||
loadSourcesFromFile,
|
||||
@@ -31,11 +32,6 @@ const MAX_EPISODES_REFRESH = 50;
|
||||
/** Max episodes to fetch on initial subscribe */
|
||||
const MAX_EPISODES_SUBSCRIBE = 20;
|
||||
|
||||
/** Per-feed bound on both the cached parse results and the merged in-memory
|
||||
* window; 500 covers years of a weekly show's history while capping a
|
||||
* 20-subscription install at 10k episodes. */
|
||||
export const MAX_EPISODES_IN_MEMORY = 500;
|
||||
|
||||
/** Per-feed fetch timeout — a hung feed must not stall a refresh batch or
|
||||
* the background refresh loop. */
|
||||
const FETCH_TIMEOUT_MS = 20_000;
|
||||
@@ -53,6 +49,16 @@ const DEFAULT_REFRESH_INTERVAL_MINUTES = 30;
|
||||
* feeds) can't stall the renderer. */
|
||||
const PARSE_CHUNK_SIZE = 5;
|
||||
|
||||
/** Hard ceiling on the in-memory full-parse cache per feed (newest first).
|
||||
* The cache exists so fetch-more can page deeper without a refetch; without
|
||||
* a ceiling a 5,000-episode archive pins tens of MB of Episode objects in
|
||||
* RAM for the whole session (the old cache held EVERY parsed episode of
|
||||
* every feed, contributing hundreds of MB for archive-heavy
|
||||
* subscriptions). 1000 covers any realistic show's entire history —
|
||||
* beyond it, hasMoreEpisodes flips false and the visible list is bounded
|
||||
* by the user's cache preference as usual. */
|
||||
const MAX_CACHED_EPISODES_PER_FEED = 1000;
|
||||
|
||||
/** Yield to the event loop (task queue) so the renderer can paint between
|
||||
* parse chunks. MessageChannel instead of setTimeout/setImmediate because
|
||||
* bun:test fake timers trap those (feed-refresh/pagination tests run under
|
||||
@@ -93,15 +99,42 @@ const parseEpisodesIncremental = async (
|
||||
return episodes;
|
||||
};
|
||||
|
||||
/** Cache of all parsed episodes per feed (feedId -> Episode[]) */
|
||||
/** Cache of ALL parsed episodes per feed (feedId -> Episode[]). Holds the
|
||||
* full parse — the bound (count or date) is applied when reading, not when
|
||||
* writing, so changing the preference takes effect without a refetch.
|
||||
* Fetch-more reads beyond the bound from this cache (volatile only — the
|
||||
* cache itself is never extended by fetch-more). */
|
||||
const fullEpisodeCache = new Map<string, Episode[]>();
|
||||
|
||||
/** Track how many episodes are currently loaded per feed */
|
||||
/** Track how many episodes are currently loaded (visible) per feed. The
|
||||
* loaded window grows via fetch-more but never exceeds what the cache
|
||||
* holds — when it reaches the cache length, hasMoreEpisodes flips false. */
|
||||
const episodeLoadCount = new Map<string, number>();
|
||||
|
||||
/** Save feeds to file (async, fire-and-forget) */
|
||||
/** Read the episode cache bound from preferences: a closure that decides
|
||||
* whether the episode at `index` (0 = newest, after sort) is kept. */
|
||||
function episodeKeepFn(prefs: {
|
||||
episodeCacheMode: "date" | "count";
|
||||
episodeCacheCount: number;
|
||||
episodeCacheDays: number;
|
||||
}): (ep: Episode, index: number) => boolean {
|
||||
const now = new Date();
|
||||
if (prefs.episodeCacheMode === "count") {
|
||||
const count = Math.max(1, prefs.episodeCacheCount);
|
||||
return (_ep: Episode, index: number) => index < count;
|
||||
}
|
||||
const days = Math.max(1, prefs.episodeCacheDays);
|
||||
return (ep: Episode) => episodeInWindow(ep, now, days);
|
||||
}
|
||||
|
||||
/** Save feeds to file (async, fire-and-forget). */
|
||||
function saveFeeds(feeds: Feed[]): void {
|
||||
saveFeedsToFile(feeds);
|
||||
const prefs = useAppStore().state().preferences;
|
||||
const days =
|
||||
prefs.episodeCacheMode === "date"
|
||||
? Math.max(1, prefs.episodeCacheDays)
|
||||
: undefined;
|
||||
saveFeedsToFile(feeds, days);
|
||||
}
|
||||
|
||||
/** Save sources to file (async, fire-and-forget) */
|
||||
@@ -191,7 +224,6 @@ async function mapWithConcurrency<T, R>(
|
||||
return results;
|
||||
}
|
||||
|
||||
/** Create feed store */
|
||||
function createFeedStore() {
|
||||
const [feeds, setFeeds] = createSignal<Feed[]>([]);
|
||||
const [sources, setSources] = createSignal<PodcastSource[]>([
|
||||
@@ -239,7 +271,6 @@ function createFeedStore() {
|
||||
saveFeeds(feeds());
|
||||
};
|
||||
|
||||
/** Get filtered and sorted feeds */
|
||||
const getFilteredFeeds = (): Feed[] => {
|
||||
let result = [...feeds()];
|
||||
const f = filter();
|
||||
@@ -297,7 +328,6 @@ function createFeedStore() {
|
||||
return result;
|
||||
};
|
||||
|
||||
/** Get episodes in reverse chronological order across all feeds */
|
||||
const getAllEpisodesChronological = (): Array<{
|
||||
episode: Episode;
|
||||
feed: Feed;
|
||||
@@ -318,20 +348,21 @@ function createFeedStore() {
|
||||
return allEpisodes;
|
||||
};
|
||||
|
||||
/** Sort episodes in reverse chronological order (newest first) */
|
||||
const sortEpisodesReverseChronological = (episodes: Episode[]): Episode[] => {
|
||||
return [...episodes].sort(
|
||||
(a, b) => b.pubDate.getTime() - a.pubDate.getTime(),
|
||||
);
|
||||
};
|
||||
|
||||
/** Fetch latest episodes from an RSS feed URL, caching all parsed episodes.
|
||||
* Returns NULL when the feed could not be fetched (network error, non-OK
|
||||
/** Fetch latest episodes from an RSS feed URL, caching all parsed episodes.
|
||||
* Also returns the channel-level artwork so callers can backfill a feed's
|
||||
* coverUrl (subscribe + refresh). Null episodes on any failure — a
|
||||
* failed fetch must not look like an empty feed, or the store would wipe
|
||||
* a subscribed show's episodes. */
|
||||
/** Fetch latest episodes from an RSS feed URL, caching ALL parsed
|
||||
* episodes in fullEpisodeCache. The visible episodes returned are
|
||||
* bounded by the user's cache preference (count or date); the full
|
||||
* cache survives so fetch-more can page beyond the bound without a
|
||||
* refetch (volatile only — the cache is never extended by fetch-more).
|
||||
* Returns NULL episodes on any failure — a failed fetch must not look
|
||||
* like an empty feed, or the store would wipe a subscribed show's
|
||||
* episodes. Also returns the channel-level artwork so callers can
|
||||
* backfill a feed's coverUrl (subscribe + refresh). */
|
||||
const fetchEpisodes = async (
|
||||
feedUrl: string,
|
||||
limit: number,
|
||||
@@ -356,14 +387,34 @@ function createFeedStore() {
|
||||
await parseEpisodesIncremental(xml, feedUrl),
|
||||
);
|
||||
|
||||
// Cache all parsed episodes for pagination
|
||||
if (feedId) {
|
||||
fullEpisodeCache.set(feedId, allEpisodes.slice(0, MAX_EPISODES_IN_MEMORY));
|
||||
episodeLoadCount.set(feedId, Math.min(limit, allEpisodes.length));
|
||||
// Cache the FULL parse — the bound is applied when reading,
|
||||
// not when writing, so a preference change takes effect
|
||||
// without a refetch. Capped at MAX_CACHED_EPISODES_PER_FEED
|
||||
// so an archive-heavy feed can't pin its entire history in
|
||||
// RAM for the session (the visible window below is bounded
|
||||
// by the user's preference regardless).
|
||||
fullEpisodeCache.set(
|
||||
feedId,
|
||||
allEpisodes.slice(0, MAX_CACHED_EPISODES_PER_FEED),
|
||||
);
|
||||
}
|
||||
|
||||
// Bound the visible window by the user's cache preference.
|
||||
const prefs = useAppStore().state().preferences;
|
||||
const keep = episodeKeepFn(prefs);
|
||||
const bounded = allEpisodes.filter((ep, i) => keep(ep, i));
|
||||
const visible = bounded.slice(0, limit);
|
||||
|
||||
if (feedId) {
|
||||
// Track how many episodes are visible — the bounded window,
|
||||
// not the full parse. hasMoreEpisodes compares this to the
|
||||
// full cache length to decide if fetch-more can page deeper.
|
||||
episodeLoadCount.set(feedId, visible.length);
|
||||
}
|
||||
|
||||
return {
|
||||
episodes: allEpisodes.slice(0, limit),
|
||||
episodes: visible,
|
||||
coverUrl: parseChannelCoverUrl(xml),
|
||||
};
|
||||
} catch {
|
||||
@@ -371,7 +422,6 @@ function createFeedStore() {
|
||||
}
|
||||
};
|
||||
|
||||
/** Check if a feed with this URL already exists */
|
||||
const hasFeedByUrl = (feedUrl: string): boolean => {
|
||||
return feeds().some((f) => f.podcast.feedUrl === feedUrl);
|
||||
};
|
||||
@@ -470,19 +520,22 @@ function createFeedStore() {
|
||||
* only when the content actually changed (see sameRefreshWindow). The
|
||||
* fetched window is MERGED into the existing episodes (fetched copy wins
|
||||
* on id collision) so a refresh never shrinks the in-memory list; the
|
||||
* union is capped at MAX_EPISODES_IN_MEMORY. Returns the ORIGINAL array
|
||||
* reference when nothing changed so callers skip persistence entirely —
|
||||
* a refresh that fetched identical episodes must not re-sort the
|
||||
* "updated" view. */
|
||||
* union is pruned by the user's cache bound (count or date) so episodes
|
||||
* outside the bound fall out of the visible list on the next refresh.
|
||||
* Returns the ORIGINAL array reference when nothing changed so callers
|
||||
* skip persistence entirely — a refresh that fetched identical episodes
|
||||
* must not re-sort the "updated" view. */
|
||||
const applyRefreshedEpisodes = (
|
||||
prev: Feed[],
|
||||
feedId: string,
|
||||
episodes: Episode[],
|
||||
): Feed[] => {
|
||||
let changed = false;
|
||||
const prefs = useAppStore().state().preferences;
|
||||
const keep = episodeKeepFn(prefs);
|
||||
const updated = prev.map((f) => {
|
||||
if (f.id !== feedId) return f;
|
||||
const merged = mergeEpisodes(f.episodes, episodes, MAX_EPISODES_IN_MEMORY);
|
||||
const merged = mergeEpisodesBounded(f.episodes, episodes, keep);
|
||||
if (sameRefreshWindow(f.episodes, episodes)) return f;
|
||||
changed = true;
|
||||
return { ...f, episodes: merged, lastUpdated: new Date() };
|
||||
@@ -574,7 +627,11 @@ function createFeedStore() {
|
||||
const { promise: feedsReady, resolve: resolveFeedsReady } =
|
||||
Promise.withResolvers<void>();
|
||||
(async () => {
|
||||
const loadedFeeds = await loadFeedsFromFile();
|
||||
const loadedFeeds = await loadFeedsFromFile(
|
||||
useAppStore().state().preferences.episodeCacheMode === "date"
|
||||
? Math.max(1, useAppStore().state().preferences.episodeCacheDays)
|
||||
: undefined,
|
||||
);
|
||||
if (loadedFeeds.length > 0) setFeeds(loadedFeeds);
|
||||
resolveFeedsReady();
|
||||
const loadedSources = await loadSourcesFromFile<PodcastSource>();
|
||||
@@ -629,7 +686,6 @@ function createFeedStore() {
|
||||
};
|
||||
scheduleNextRefresh();
|
||||
|
||||
/** Remove a feed */
|
||||
const removeFeed = (feedId: string) => {
|
||||
fullEpisodeCache.delete(feedId);
|
||||
episodeLoadCount.delete(feedId);
|
||||
@@ -660,7 +716,6 @@ function createFeedStore() {
|
||||
}
|
||||
};
|
||||
|
||||
/** Update a feed */
|
||||
const updateFeed = (feedId: string, updates: Partial<Feed>) => {
|
||||
setFeeds((prev) => {
|
||||
const updated = prev.map((f) =>
|
||||
@@ -671,7 +726,6 @@ function createFeedStore() {
|
||||
});
|
||||
};
|
||||
|
||||
/** Toggle feed pinned status */
|
||||
const togglePinned = (feedId: string) => {
|
||||
setFeeds((prev) => {
|
||||
const updated = prev.map((f) =>
|
||||
@@ -682,7 +736,6 @@ function createFeedStore() {
|
||||
});
|
||||
};
|
||||
|
||||
/** Add a source */
|
||||
const addSource = (source: Omit<PodcastSource, "id">) => {
|
||||
const newSource: PodcastSource = {
|
||||
...source,
|
||||
@@ -696,7 +749,6 @@ function createFeedStore() {
|
||||
return newSource;
|
||||
};
|
||||
|
||||
/** Update a source */
|
||||
const updateSource = (sourceId: string, updates: Partial<PodcastSource>) => {
|
||||
setSources((prev) => {
|
||||
const updated = prev.map((source) =>
|
||||
@@ -707,7 +759,6 @@ function createFeedStore() {
|
||||
});
|
||||
};
|
||||
|
||||
/** Remove a source */
|
||||
const removeSource = (sourceId: string) => {
|
||||
// Don't remove default sources
|
||||
if (DEFAULT_SOURCES.some((s) => s.id === sourceId)) return false;
|
||||
@@ -720,7 +771,6 @@ function createFeedStore() {
|
||||
return true;
|
||||
};
|
||||
|
||||
/** Toggle source enabled status */
|
||||
const toggleSource = (sourceId: string) => {
|
||||
setSources((prev) => {
|
||||
const updated = prev.map((s) =>
|
||||
@@ -731,7 +781,6 @@ function createFeedStore() {
|
||||
});
|
||||
};
|
||||
|
||||
/** Get feed by ID */
|
||||
const getFeed = (feedId: string): Feed | undefined => {
|
||||
return feeds().find((f) => f.id === feedId);
|
||||
};
|
||||
@@ -746,13 +795,17 @@ function createFeedStore() {
|
||||
return undefined;
|
||||
};
|
||||
|
||||
/** Get selected feed */
|
||||
const getSelectedFeed = (): Feed | undefined => {
|
||||
const id = selectedFeedId();
|
||||
return id ? getFeed(id) : undefined;
|
||||
};
|
||||
|
||||
/** Check if a feed has more episodes available beyond what's currently loaded */
|
||||
/** Check if a feed has more episodes available beyond what's currently
|
||||
* loaded. The full parse cache holds ALL episodes (including beyond the
|
||||
* cache bound), so fetch-more can always page deeper — the bound limits
|
||||
* what the Feed/My Shows list shows initially, not what fetch-more can
|
||||
* reach. When the loaded window reaches the cache length, this flips
|
||||
* false. */
|
||||
const hasMoreEpisodes = (feedId: string): boolean => {
|
||||
const cached = fullEpisodeCache.get(feedId);
|
||||
if (!cached) return false;
|
||||
@@ -760,7 +813,13 @@ function createFeedStore() {
|
||||
return loaded < cached.length;
|
||||
};
|
||||
|
||||
/** Load the next chunk of episodes for one feed from the cache.
|
||||
/** Load the next chunk of episodes for one feed from the full parse
|
||||
* cache — VOLATILE only: the episodes surfaced beyond the cache bound
|
||||
* are held in the feed's in-memory episode list (so the user can browse
|
||||
* them) but are NOT written back to fullEpisodeCache (the cache keeps
|
||||
* its original bounded shape; these episodes vanish on the next
|
||||
* refresh or restart). The cache is populated by fetchEpisodes/refresh;
|
||||
* a cold cache (post-restart) triggers a refetch here.
|
||||
* No global guard — callers own the `isLoadingMore` flag so batches
|
||||
* (loadMoreAllFeeds) can loop over multiple feeds in one go. */
|
||||
const loadMoreEpisodesForFeed = async (feedId: string) => {
|
||||
@@ -769,7 +828,8 @@ function createFeedStore() {
|
||||
|
||||
let cached = fullEpisodeCache.get(feedId);
|
||||
|
||||
// If no cache, re-fetch and parse the full feed
|
||||
// If no cache, re-fetch and parse the full feed (cold path after a
|
||||
// restart). The cache holds the FULL parse — no bound applied here.
|
||||
if (!cached) {
|
||||
try {
|
||||
const response = await fetch(feed.podcast.feedUrl, {
|
||||
@@ -789,14 +849,15 @@ function createFeedStore() {
|
||||
// untouched rather than throwing out of loadMoreEpisodes.
|
||||
return;
|
||||
}
|
||||
// Cold-refetch parse output is unsorted; sort and cap it so the
|
||||
// cache and the pagination window stay newest-first and bounded.
|
||||
// Cold-refetch parse output is unsorted; sort it newest-first.
|
||||
// Yield before the sync sort (the parse already yielded before
|
||||
// this point, but the sort of potentially hundreds of episodes
|
||||
// is its own sync block).
|
||||
await yieldToUI();
|
||||
cached = sortEpisodesReverseChronological(cached);
|
||||
cached = cached.slice(0, MAX_EPISODES_IN_MEMORY);
|
||||
// Same ceiling as fetchEpisodes: the cache (and the paging
|
||||
// window below) never exceeds MAX_CACHED_EPISODES_PER_FEED.
|
||||
cached = cached.slice(0, MAX_CACHED_EPISODES_PER_FEED);
|
||||
fullEpisodeCache.set(feedId, cached);
|
||||
// Set current load count to match what's already displayed
|
||||
episodeLoadCount.set(feedId, feed.episodes.length);
|
||||
@@ -810,6 +871,9 @@ function createFeedStore() {
|
||||
|
||||
if (newCount <= currentCount) return; // nothing more to load
|
||||
|
||||
// Advance the loaded window — volatile: the episodes beyond the cache
|
||||
// bound are held in feed.episodes (visible) but the cache itself is
|
||||
// NOT extended. episodeLoadCount tracks the volatile window size.
|
||||
episodeLoadCount.set(feedId, newCount);
|
||||
const episodes = cached.slice(0, newCount);
|
||||
|
||||
@@ -841,7 +905,6 @@ function createFeedStore() {
|
||||
}
|
||||
};
|
||||
|
||||
/** True if any feed still has cached episodes beyond its loaded window. */
|
||||
const hasMoreAcrossAll = (): boolean => {
|
||||
return feeds().some((f) => hasMoreEpisodes(f.id));
|
||||
};
|
||||
@@ -861,7 +924,6 @@ function createFeedStore() {
|
||||
}
|
||||
};
|
||||
|
||||
/** Run the global auto-download pass (see runAutoDownload above). */
|
||||
const runAutoDownloadNow = (): void => {
|
||||
runAutoDownload();
|
||||
};
|
||||
@@ -910,7 +972,6 @@ function createFeedStore() {
|
||||
};
|
||||
}
|
||||
|
||||
/** Singleton feed store */
|
||||
let feedStoreInstance: ReturnType<typeof createFeedStore> | null = null;
|
||||
|
||||
export function useFeedStore() {
|
||||
|
||||
@@ -64,16 +64,10 @@ function createProgressStore() {
|
||||
*/
|
||||
whenReady: () => progressInit,
|
||||
|
||||
/**
|
||||
* Get progress for a specific episode.
|
||||
*/
|
||||
get(episodeId: string): Progress | undefined {
|
||||
return progressMap()[episodeId];
|
||||
},
|
||||
|
||||
/**
|
||||
* Get all progress entries.
|
||||
*/
|
||||
all(): Record<string, Progress> {
|
||||
return progressMap();
|
||||
},
|
||||
@@ -102,18 +96,12 @@ function createProgressStore() {
|
||||
persist();
|
||||
},
|
||||
|
||||
/**
|
||||
* Check if an episode is completed.
|
||||
*/
|
||||
isCompleted(episodeId: string): boolean {
|
||||
const p = progressMap()[episodeId];
|
||||
if (!p || p.duration <= 0) return false;
|
||||
return p.position / p.duration >= COMPLETION_THRESHOLD;
|
||||
},
|
||||
|
||||
/**
|
||||
* Get progress percentage (0-100) for an episode.
|
||||
*/
|
||||
getPercent(episodeId: string): number {
|
||||
const p = progressMap()[episodeId];
|
||||
if (!p || p.duration <= 0) return 0;
|
||||
@@ -151,9 +139,6 @@ function createProgressStore() {
|
||||
persist();
|
||||
},
|
||||
|
||||
/**
|
||||
* Clear all progress data.
|
||||
*/
|
||||
clear(): void {
|
||||
setProgressMap({});
|
||||
persist();
|
||||
|
||||
@@ -60,7 +60,6 @@ function saveScope(scope: SearchScope): void {
|
||||
}
|
||||
}
|
||||
|
||||
/** Create search store */
|
||||
export function createSearchStore() {
|
||||
const feedStore = useFeedStore();
|
||||
const [query, setQuery] = createSignal("");
|
||||
@@ -167,7 +166,6 @@ export function createSearchStore() {
|
||||
}
|
||||
};
|
||||
|
||||
/** Add query to history */
|
||||
const addToHistory = (q: string) => {
|
||||
setHistory((prev) => {
|
||||
const updated = sanitizeHistory([q, ...prev]);
|
||||
@@ -176,13 +174,11 @@ export function createSearchStore() {
|
||||
});
|
||||
};
|
||||
|
||||
/** Clear search history */
|
||||
const clearHistory = () => {
|
||||
setHistory([]);
|
||||
saveSearchHistoryToFile([]);
|
||||
};
|
||||
|
||||
/** Remove single history item */
|
||||
const removeFromHistory = (q: string) => {
|
||||
setHistory((prev) => {
|
||||
const updated = prev.filter((h) => h !== q);
|
||||
@@ -191,14 +187,12 @@ export function createSearchStore() {
|
||||
});
|
||||
};
|
||||
|
||||
/** Clear results */
|
||||
const clearResults = () => {
|
||||
setResults([]);
|
||||
setQuery("");
|
||||
setError(null);
|
||||
};
|
||||
|
||||
/** Mark a podcast as subscribed in results */
|
||||
const markSubscribed = (podcastId: string, feedUrl?: string) => {
|
||||
setResults((prev) =>
|
||||
prev.map((result) => {
|
||||
@@ -262,7 +256,6 @@ export function createSearchStore() {
|
||||
};
|
||||
}
|
||||
|
||||
/** Singleton search store */
|
||||
let searchStoreInstance: ReturnType<typeof createSearchStore> | null = null;
|
||||
|
||||
export function useSearchStore() {
|
||||
|
||||
@@ -96,6 +96,11 @@ export type FetchMoreMode = "manual" | "auto";
|
||||
/** Which shows the auto-download setting applies to (default: all). */
|
||||
export type AutoDownloadScope = "all" | "none" | "whitelist";
|
||||
|
||||
/** How the episode cache (the Feed / My Shows list + the pagination cache)
|
||||
* is bounded: by a rolling date window or by a count of most-recent
|
||||
* episodes (default: date). */
|
||||
export type EpisodeCacheMode = "date" | "count";
|
||||
|
||||
export type UserPreferences = {
|
||||
showExplicit: boolean;
|
||||
autoDownload: boolean;
|
||||
@@ -111,6 +116,12 @@ export type UserPreferences = {
|
||||
fetchMoreMode: FetchMoreMode;
|
||||
/** Minutes between automatic background feed refreshes (default: 30). */
|
||||
refreshIntervalMinutes: number;
|
||||
/** How the episode list cache is bounded — by date or by count (default: date). */
|
||||
episodeCacheMode: EpisodeCacheMode;
|
||||
/** Number of most-recent episodes to keep when mode is "count" (default: 25). */
|
||||
episodeCacheCount: number;
|
||||
/** Rolling window in days for the episode list when mode is "date" (default: 60). */
|
||||
episodeCacheDays: number;
|
||||
};
|
||||
|
||||
export type AppState = {
|
||||
|
||||
@@ -156,9 +156,6 @@ function init() {
|
||||
setRegistrations((arr) => arr.filter((x) => x !== results));
|
||||
});
|
||||
},
|
||||
/**
|
||||
* Get all visible options.
|
||||
*/
|
||||
get options() {
|
||||
return visibleOptions();
|
||||
},
|
||||
@@ -195,9 +192,6 @@ export function CommandProvider(props: ParentProps) {
|
||||
return <ctx.Provider value={value}>{props.children}</ctx.Provider>;
|
||||
}
|
||||
|
||||
/**
|
||||
* Command palette dialog component.
|
||||
*/
|
||||
function CommandDialog(props: {
|
||||
options: CommandOption[];
|
||||
suggestedOptions: CommandOption[];
|
||||
|
||||
@@ -98,9 +98,6 @@ function init() {
|
||||
})
|
||||
|
||||
return {
|
||||
/**
|
||||
* Clear all dialogs from the stack.
|
||||
*/
|
||||
clear() {
|
||||
for (const item of store.stack) {
|
||||
if (item.onClose) item.onClose()
|
||||
@@ -113,9 +110,6 @@ function init() {
|
||||
emit("dialog.close", {})
|
||||
},
|
||||
|
||||
/**
|
||||
* Replace all dialogs with a new one.
|
||||
*/
|
||||
replace(input: JSX.Element | (() => JSX.Element), onClose?: () => void) {
|
||||
if (store.stack.length === 0) {
|
||||
focus = renderer.currentFocusedRenderable
|
||||
@@ -130,9 +124,6 @@ function init() {
|
||||
emit("dialog.open", { dialogId: "dialog" })
|
||||
},
|
||||
|
||||
/**
|
||||
* Push a new dialog onto the stack.
|
||||
*/
|
||||
push(input: JSX.Element | (() => JSX.Element), onClose?: () => void) {
|
||||
if (store.stack.length === 0) {
|
||||
focus = renderer.currentFocusedRenderable
|
||||
@@ -143,9 +134,6 @@ function init() {
|
||||
emit("dialog.open", { dialogId: "dialog" })
|
||||
},
|
||||
|
||||
/**
|
||||
* Pop the top dialog from the stack.
|
||||
*/
|
||||
pop() {
|
||||
if (store.stack.length === 0) return
|
||||
const current = store.stack.at(-1)!
|
||||
|
||||
@@ -49,6 +49,9 @@ const defaultPreferences: UserPreferences = {
|
||||
autoJumpToPlayer: true,
|
||||
fetchMoreMode: "auto",
|
||||
refreshIntervalMinutes: 30,
|
||||
episodeCacheMode: "date",
|
||||
episodeCacheCount: 25,
|
||||
episodeCacheDays: 60,
|
||||
};
|
||||
|
||||
const defaultState: AppState = {
|
||||
@@ -59,7 +62,6 @@ const defaultState: AppState = {
|
||||
|
||||
// ── App State (config.json) ─────────────────────────────────────────────────
|
||||
|
||||
/** Load app state from config.json */
|
||||
export async function loadAppStateFromFile(): Promise<AppState> {
|
||||
try {
|
||||
const cfg = await loadConfig();
|
||||
@@ -85,7 +87,6 @@ export async function loadAppStateFromFile(): Promise<AppState> {
|
||||
}
|
||||
}
|
||||
|
||||
/** Save app state to config.json */
|
||||
export function saveAppStateToFile(state: AppState): void {
|
||||
updateConfig({
|
||||
settings: state.settings,
|
||||
@@ -106,7 +107,6 @@ interface ProgressEntry {
|
||||
playbackSpeed?: number;
|
||||
}
|
||||
|
||||
/** Load progress map from JSON file */
|
||||
export async function loadProgressFromFile(): Promise<
|
||||
Record<string, ProgressEntry>
|
||||
> {
|
||||
@@ -142,7 +142,6 @@ export function saveProgressToFile(data: Record<string, unknown>): void {
|
||||
|
||||
const SEARCH_HISTORY_FILE = "search-history.json";
|
||||
|
||||
/** Load search history from JSON file */
|
||||
export async function loadSearchHistoryFromFile(): Promise<string[]> {
|
||||
try {
|
||||
const file = Bun.file(getConfigFilePath(SEARCH_HISTORY_FILE));
|
||||
@@ -156,7 +155,6 @@ export async function loadSearchHistoryFromFile(): Promise<string[]> {
|
||||
}
|
||||
}
|
||||
|
||||
/** Save search history to JSON file (overwrite, no backup) */
|
||||
export function saveSearchHistoryToFile(history: string[]): void {
|
||||
(async () => {
|
||||
try {
|
||||
@@ -175,7 +173,6 @@ export function saveSearchHistoryToFile(history: string[]): void {
|
||||
|
||||
const AUDIO_NAV_FILE = "audio-nav.json";
|
||||
|
||||
/** Load audio navigation state from JSON file */
|
||||
export async function loadAudioNavFromFile<T>(): Promise<T | null> {
|
||||
try {
|
||||
const file = Bun.file(getConfigFilePath(AUDIO_NAV_FILE));
|
||||
|
||||
@@ -23,9 +23,16 @@
|
||||
* pass over just that region) — earlier segments stay valid, mp3 decode of
|
||||
* the same file is deterministic so abutting segments agree.
|
||||
*
|
||||
* Memory: 22050 Hz mono s16 ≈ 44 KB/s ≈ 2.6 MB/min (~80 MB per 30 min),
|
||||
* freed on stop(). 22050 Hz covers Nyquist 11 kHz, above the default 10 kHz
|
||||
* high-cutoff of the visualizer's FFT config.
|
||||
* Memory: 22050 Hz mono s16 ≈ 44 KB/s ≈ 2.6 MB/min. The cache is a
|
||||
* SLIDING WINDOW around the playback position — the decode pass stops
|
||||
* once it is maxAheadSec ahead of the cursor and segments entirely older
|
||||
* than keepBehindSec behind it are dropped (both re-filled/restarted on
|
||||
* demand). Steady state is bounded by (maxAheadSec + keepBehindSec) of
|
||||
* audio (~40 MB at the defaults) INDEPENDENT of episode length; the old
|
||||
* whole-episode cache grew ~160 MB per hour of audio and hit 2.5 GB on
|
||||
* long-form episodes. Fully freed on stop(). 22050 Hz covers Nyquist
|
||||
* 11 kHz, above the default 10 kHz high-cutoff of the visualizer's FFT
|
||||
* config.
|
||||
*
|
||||
* Downloads via ffmpeg's own http stack with reconnect flags, matching the
|
||||
* old reader; local files skip them (ffmpeg rejects http-only options for
|
||||
@@ -49,6 +56,24 @@ const INITIAL_CAPACITY_SAMPLES = 4 * 1024 * 1024;
|
||||
*/
|
||||
const CLOSE_IN_PLACE_GAP_SEC = 15;
|
||||
|
||||
/**
|
||||
* Default decode-head budget: the ffmpeg pass pauses once it is this far
|
||||
* ahead of the playback cursor. Bounds RAM (~26 MB of s16 at 22050 Hz) AND
|
||||
* the network pull — the old cache decoded the whole episode at 4x, so a
|
||||
* 3h show pinned ~500 MB (2.5 GB+ for long-form) and dragged the entire
|
||||
* remote file even when only the first 10 minutes were listened to. At 4x
|
||||
* pacing a refill costs ~150s of background decode, one ffmpeg spawn per
|
||||
* ~10 min of playback.
|
||||
*/
|
||||
const DEFAULT_DECODE_AHEAD_SEC = 600;
|
||||
|
||||
/**
|
||||
* Default retention behind the cursor: decoded audio entirely older than
|
||||
* this is dropped. Keeps pause/resume and small backward seeks instant
|
||||
* without letting the window grow with playback time.
|
||||
*/
|
||||
const DEFAULT_KEEP_BEHIND_SEC = 300;
|
||||
|
||||
/**
|
||||
* Monotonically increasing generation counter.
|
||||
* Each startDecode() increments this; the read loop checks it to know
|
||||
@@ -73,6 +98,10 @@ export interface EpisodePcmCacheOptions {
|
||||
url: string;
|
||||
/** Sample rate (default: 22050) */
|
||||
sampleRate?: number;
|
||||
/** Decode-head budget in seconds ahead of the cursor (default: 600). */
|
||||
maxAheadSec?: number;
|
||||
/** Retention in seconds behind the cursor (default: 300). */
|
||||
keepBehindSec?: number;
|
||||
}
|
||||
|
||||
export class EpisodePcmCache {
|
||||
@@ -84,10 +113,15 @@ export class EpisodePcmCache {
|
||||
private activeSegment: Segment | null = null;
|
||||
readonly url: string;
|
||||
readonly sampleRate: number;
|
||||
/** Sliding-window budgets (see maintainWindow). */
|
||||
readonly maxAheadSec: number;
|
||||
readonly keepBehindSec: number;
|
||||
|
||||
constructor(options: EpisodePcmCacheOptions) {
|
||||
this.url = options.url;
|
||||
this.sampleRate = options.sampleRate ?? PCM_SAMPLE_RATE;
|
||||
this.maxAheadSec = options.maxAheadSec ?? DEFAULT_DECODE_AHEAD_SEC;
|
||||
this.keepBehindSec = options.keepBehindSec ?? DEFAULT_KEEP_BEHIND_SEC;
|
||||
}
|
||||
|
||||
/** Whether an ffmpeg decode pass is currently running. */
|
||||
@@ -238,11 +272,20 @@ export class EpisodePcmCache {
|
||||
* new segment at `sec` (seek into a hole / resume past cached audio).
|
||||
*/
|
||||
ensureDecodeAround(sec: number): void {
|
||||
// Enforce the sliding-window budget first (head cap, prune, refill)
|
||||
// so a resume or seek never leaves stale segments behind the cursor.
|
||||
this.maintainWindow(sec);
|
||||
|
||||
// Data already on hand: nothing needed here; only keep the tail
|
||||
// filling if the decode is idle and the episode is unfinished.
|
||||
// filling if the decode is idle, the episode is unfinished, AND the
|
||||
// head is inside its budget. A head-capped cache ("we're maxAheadSec
|
||||
// ahead, enough decoded") is NOT a stalled decode — restarting it
|
||||
// here would fight maintainWindow's cap on every resume call.
|
||||
if (this.covers(sec)) {
|
||||
if (this._decoding || this.decodeFinished) return;
|
||||
this.startDecode(this.coverageEndSec > sec ? this.coverageEndSec : sec);
|
||||
const end = this.coverageEndSec;
|
||||
if (end >= sec + this.maxAheadSec) return;
|
||||
this.startDecode(end > sec ? end : sec);
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -265,6 +308,48 @@ export class EpisodePcmCache {
|
||||
this.startDecode(Math.max(0, sec));
|
||||
}
|
||||
|
||||
/**
|
||||
* Sliding-window budget for the in-memory cache, driven by the live
|
||||
* playback position. Runs on every read (the render loop is the only
|
||||
* consumer that knows the cursor continuously) and on resume/seek:
|
||||
* - capHead: the decode pass pauses once it is maxAheadSec ahead of the
|
||||
* cursor (pauseDecode keeps the decoded data — a plain startDecode
|
||||
* from the frontier refills it later).
|
||||
* - prune: segments entirely keepBehindSec behind the cursor are
|
||||
* dropped. A backward seek past the window restarts a segment there —
|
||||
* the same mechanism as a seek into an undecoded hole, so no new
|
||||
* failure mode.
|
||||
* - topUp: when the cursor has outrun the head, restart the tail decode
|
||||
* from the frontier (one ffmpeg spawn per maxAheadSec of playback).
|
||||
* Together these bound memory to (maxAheadSec + keepBehindSec) of audio
|
||||
* regardless of episode length.
|
||||
*/
|
||||
private maintainWindow(atSec: number): void {
|
||||
const pos = Math.max(0, atSec);
|
||||
|
||||
if (this._decoding && this.coverageEndSec >= pos + this.maxAheadSec) {
|
||||
this.pauseDecode();
|
||||
}
|
||||
|
||||
const keepFromSec = pos - this.keepBehindSec;
|
||||
if (
|
||||
this.segments.some(
|
||||
(seg) => seg.baseSec + seg.written / this.sampleRate < keepFromSec,
|
||||
)
|
||||
) {
|
||||
this.segments = this.segments.filter(
|
||||
(seg) => seg.baseSec + seg.written / this.sampleRate >= keepFromSec,
|
||||
);
|
||||
}
|
||||
|
||||
if (!this._decoding && !this.decodeFinished) {
|
||||
const end = this.coverageEndSec;
|
||||
if (end < pos + this.maxAheadSec) {
|
||||
this.startDecode(Math.max(end, pos));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Read the PCM window ENDING at `atSec` of playback into `out`
|
||||
* (Int16 magnitudes widened to f64, the scale cavacore expects).
|
||||
@@ -275,6 +360,7 @@ export class EpisodePcmCache {
|
||||
*/
|
||||
readWindow(out: Float64Array, atSec: number): number {
|
||||
if (out.length === 0) return 0;
|
||||
this.maintainWindow(atSec);
|
||||
const endIdx = Math.round(atSec * this.sampleRate);
|
||||
const startIdx = endIdx - out.length + 1;
|
||||
for (const seg of this.segments) {
|
||||
|
||||
@@ -52,7 +52,6 @@ const DEFAULTS: Required<CavaCoreConfig> = {
|
||||
scalingMode: 0,
|
||||
};
|
||||
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
type CavaLib = {
|
||||
symbols: Record<string, (...args: any[]) => any>;
|
||||
close(): void;
|
||||
@@ -102,7 +101,6 @@ export class CavaCore {
|
||||
this.lib = lib;
|
||||
}
|
||||
|
||||
/** Number of frequency bars configured. */
|
||||
get bars(): number {
|
||||
return this._bars;
|
||||
}
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import type { Episode } from "../types/episode"
|
||||
import type { Episode } from "../types/episode";
|
||||
|
||||
/** Sort key for an episode's pubDate — missing/invalid dates sort as NEWEST
|
||||
* (Infinity) so undated episodes float to the top instead of dropping into
|
||||
@@ -10,17 +10,21 @@ const ts = (ep: Episode): number => {
|
||||
|
||||
/**
|
||||
* Union of two episode lists keyed by id — on collision the fetched copy
|
||||
* wins (fresh metadata). Result is sorted newest-first by pubDate and capped
|
||||
* at `cap` entries (oldest dropped). Never mutates either input.
|
||||
* wins (fresh metadata). Result is sorted newest-first by pubDate and pruned
|
||||
* by the supplied `keep` predicate: episodes outside the configured cache
|
||||
* bound (date window or count) are dropped. Never mutates either input.
|
||||
*
|
||||
* The caller supplies `keep` so this module stays free of the preference
|
||||
* types — the feed store passes a closure bound to the user's mode/count/days.
|
||||
*/
|
||||
export function mergeEpisodes(
|
||||
export function mergeEpisodesBounded(
|
||||
existing: Episode[],
|
||||
fetched: Episode[],
|
||||
cap: number,
|
||||
keep: (ep: Episode, index: number) => boolean,
|
||||
): Episode[] {
|
||||
const byId = new Map<string, Episode>()
|
||||
for (const ep of existing) byId.set(ep.id, ep)
|
||||
for (const ep of fetched) byId.set(ep.id, ep)
|
||||
const sorted = [...byId.values()].sort((a, b) => ts(b) - ts(a))
|
||||
return sorted.slice(0, cap)
|
||||
return sorted.filter((ep, i) => keep(ep, i))
|
||||
}
|
||||
|
||||
@@ -43,7 +43,6 @@ function createEventBus(): EventBusInstance {
|
||||
}
|
||||
handlers.get(event)!.add(handler as EventHandler);
|
||||
|
||||
// Return unsubscribe function
|
||||
return () => {
|
||||
this.off(event, handler);
|
||||
};
|
||||
|
||||
@@ -10,22 +10,35 @@ import type { Episode } from "../types/episode";
|
||||
import type { Feed } from "../types/feed";
|
||||
import type { PodcastSource } from "../types/source";
|
||||
|
||||
/** Retention window for persisted episodes: older episodes are dropped when
|
||||
* feeds are written to config.json unless they are completed downloads. */
|
||||
export const PERSISTED_WINDOW_DAYS = 30;
|
||||
/** Default episode lifecycle window in days — used when no preference is
|
||||
* configured (legacy configs, first launch). The actual bound is the user's
|
||||
* episodeCacheDays preference; this is just the fail-safe default. */
|
||||
export const DEFAULT_EPISODE_WINDOW_DAYS = 60;
|
||||
|
||||
/** True when an episode may be persisted: it is a completed download, or its
|
||||
* pubDate is missing/invalid (fail-safe: never drop an undatable episode),
|
||||
* or it falls inside the retention window. */
|
||||
/** True when an episode falls inside a rolling date window of `days` days.
|
||||
* A missing/invalid pubDate is ALWAYS kept (fail-safe: never drop an
|
||||
* undatable episode) — the volatile cache must agree with
|
||||
* episodeIsPersistable so an episode the persistence layer retains can
|
||||
* never be silently pruned from the list. */
|
||||
export function episodeInWindow(
|
||||
ep: Episode,
|
||||
now: Date,
|
||||
days: number = DEFAULT_EPISODE_WINDOW_DAYS,
|
||||
): boolean {
|
||||
const t = ep.pubDate?.getTime();
|
||||
if (!t || Number.isNaN(t)) return true;
|
||||
return t >= now.getTime() - days * 24 * 3600 * 1000;
|
||||
}
|
||||
|
||||
/** True when an episode may be persisted: a completed download, or it falls
|
||||
* inside the lifecycle window (undatable episodes always kept). */
|
||||
export function episodeIsPersistable(
|
||||
ep: Episode,
|
||||
downloadedIds: Set<string>,
|
||||
now: Date,
|
||||
days: number = DEFAULT_EPISODE_WINDOW_DAYS,
|
||||
): boolean {
|
||||
if (downloadedIds.has(ep.id)) return true;
|
||||
const t = ep.pubDate?.getTime();
|
||||
if (!t || Number.isNaN(t)) return true;
|
||||
return t >= now.getTime() - PERSISTED_WINDOW_DAYS * 24 * 3600 * 1000;
|
||||
return downloadedIds.has(ep.id) || episodeInWindow(ep, now, days);
|
||||
}
|
||||
|
||||
/** Episode ids of completed downloads, read from downloads.json. In-flight
|
||||
@@ -70,12 +83,13 @@ function reviveDates(feed: Feed): Feed {
|
||||
})),
|
||||
};
|
||||
}
|
||||
|
||||
/** Load feeds from config.json, pruning episodes outside the retention
|
||||
* window (completed downloads always kept). When anything was pruned, the
|
||||
* pruned list is rewritten to config.json (startup cleanup for legacy
|
||||
* configs). The read path is awaited so the returned value is deterministic. */
|
||||
export async function loadFeedsFromFile(): Promise<Feed[]> {
|
||||
export async function loadFeedsFromFile(
|
||||
windowDays?: number,
|
||||
): Promise<Feed[]> {
|
||||
try {
|
||||
const cfg = await loadConfig();
|
||||
if (!Array.isArray(cfg.feeds)) return [];
|
||||
@@ -85,14 +99,14 @@ export async function loadFeedsFromFile(): Promise<Feed[]> {
|
||||
let prunedAny = false;
|
||||
const pruned = feeds.map((f) => {
|
||||
const kept = f.episodes.filter((ep) =>
|
||||
episodeIsPersistable(ep, downloadedIds, now),
|
||||
episodeIsPersistable(ep, downloadedIds, now, windowDays),
|
||||
);
|
||||
if (kept.length !== f.episodes.length) prunedAny = true;
|
||||
return { ...f, episodes: kept };
|
||||
});
|
||||
if (prunedAny) {
|
||||
// Fire-and-forget cleanup rewrite of the legacy config.
|
||||
saveFeedsToFile(pruned);
|
||||
saveFeedsToFile(pruned, windowDays);
|
||||
}
|
||||
return pruned;
|
||||
} catch {
|
||||
@@ -104,14 +118,14 @@ export async function loadFeedsFromFile(): Promise<Feed[]> {
|
||||
* (completed downloads always kept). Fire-and-forget: the prune reads
|
||||
* downloads.json asynchronously, then enqueues the write. On any error the
|
||||
* UNPRUNED feeds are saved instead, so data is never lost. */
|
||||
export function saveFeedsToFile(feeds: Feed[]): void {
|
||||
export function saveFeedsToFile(feeds: Feed[], windowDays?: number): void {
|
||||
(async () => {
|
||||
try {
|
||||
const downloadedIds = await readDownloadedEpisodeIds();
|
||||
const pruned = feeds.map((f) => ({
|
||||
...f,
|
||||
episodes: f.episodes.filter((ep) =>
|
||||
episodeIsPersistable(ep, downloadedIds, new Date()),
|
||||
episodeIsPersistable(ep, downloadedIds, new Date(), windowDays),
|
||||
),
|
||||
}));
|
||||
updateConfig({ feeds: pruned });
|
||||
@@ -120,8 +134,6 @@ export function saveFeedsToFile(feeds: Feed[]): void {
|
||||
}
|
||||
})().catch(() => {});
|
||||
}
|
||||
|
||||
/** Load sources from config.json */
|
||||
export async function loadSourcesFromFile<T>(): Promise<T[] | null> {
|
||||
try {
|
||||
const cfg = await loadConfig();
|
||||
@@ -131,8 +143,6 @@ export async function loadSourcesFromFile<T>(): Promise<T[] | null> {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
/** Save sources to config.json */
|
||||
export function saveSourcesToFile<T>(sources: T[]): void {
|
||||
updateConfig({ sources: sources as unknown as PodcastSource[] });
|
||||
}
|
||||
|
||||
@@ -5,9 +5,6 @@
|
||||
* and multi-line comments, which is useful for configuration files.
|
||||
*/
|
||||
|
||||
/**
|
||||
* Remove JSONC comments from a string
|
||||
*/
|
||||
function stripComments(jsonString: string): string {
|
||||
const comments = [
|
||||
{ pattern: /\/\/.*$/gm, replacement: "" },
|
||||
@@ -23,9 +20,6 @@ function stripComments(jsonString: string): string {
|
||||
return result;
|
||||
}
|
||||
|
||||
/**
|
||||
* Parse JSONC string into a JavaScript object
|
||||
*/
|
||||
export function parseJSONC(jsonString: string): unknown {
|
||||
const stripped = stripComments(jsonString);
|
||||
return JSON.parse(stripped);
|
||||
|
||||
@@ -95,7 +95,6 @@ export async function copyKeybindsIfNeeded(): Promise<void> {
|
||||
}
|
||||
}
|
||||
|
||||
/** Load keybinds from JSONC file */
|
||||
export async function loadKeybindsFromFile(): Promise<KeybindsResolved> {
|
||||
try {
|
||||
const filePath = getConfigFilePath(KEYBINDS_FILE);
|
||||
|
||||
@@ -9,23 +9,14 @@
|
||||
|
||||
import { emit } from "./event-bus"
|
||||
|
||||
/**
|
||||
* Emit a theme reload event.
|
||||
*/
|
||||
function emitThemeReload(): void {
|
||||
emit("theme.reload", {})
|
||||
}
|
||||
|
||||
/**
|
||||
* Emit a theme changed event.
|
||||
*/
|
||||
export function emitThemeChanged(theme: string, mode: "dark" | "light"): void {
|
||||
emit("theme.changed", { theme, mode })
|
||||
}
|
||||
|
||||
/**
|
||||
* Emit a theme mode changed event.
|
||||
*/
|
||||
export function emitThemeModeChanged(mode: "dark" | "light"): void {
|
||||
emit("theme.mode.changed", { mode })
|
||||
}
|
||||
|
||||
@@ -1,28 +1,13 @@
|
||||
/**
|
||||
* Theme CSS Variable Manager
|
||||
* Handles dynamic theme switching by updating CSS custom properties
|
||||
* Terminal Theme Resolver
|
||||
* Resolves the active theme (built-in, custom, or system-derived) to colors.
|
||||
*/
|
||||
|
||||
import type { TerminalColors } from "@opentui/core";
|
||||
import type { ThemeJson } from "../types/theme-schema";
|
||||
import { THEME_JSON } from "../constants/themes";
|
||||
import { getCustomThemes } from "./custom-themes";
|
||||
import { resolveTheme as resolveThemeJson } from "./theme-resolver";
|
||||
import { generateSystemTheme } from "./system-theme";
|
||||
|
||||
/**
|
||||
* Apply CSS variable data-theme attribute
|
||||
*/
|
||||
export function setThemeAttribute(themeName: string) {
|
||||
if (typeof document === "undefined") return;
|
||||
const root = document.documentElement;
|
||||
root.setAttribute("data-theme", themeName);
|
||||
}
|
||||
|
||||
export async function loadThemes() {
|
||||
return await getCustomThemes();
|
||||
}
|
||||
|
||||
export function resolveTerminalTheme(
|
||||
themes: Record<string, ThemeJson>,
|
||||
name: string,
|
||||
@@ -32,9 +17,5 @@ export function resolveTerminalTheme(
|
||||
if (name === "system" && system) {
|
||||
return resolveThemeJson(generateSystemTheme(system, mode), mode);
|
||||
}
|
||||
const theme = themes[name] ?? themes.catppuccin;
|
||||
if (!theme) {
|
||||
return resolveThemeJson(THEME_JSON.catppuccin, mode);
|
||||
}
|
||||
return resolveThemeJson(theme, mode);
|
||||
return resolveThemeJson(themes[name] ?? themes.catppuccin, mode);
|
||||
}
|
||||
|
||||
@@ -22,11 +22,9 @@ background (read this before touching code):
|
||||
deliverables:
|
||||
|
||||
- `src/utils/feeds-persistence.ts`:
|
||||
- New exported constant `PERSISTED_WINDOW_DAYS = 30`.
|
||||
- New exported pure function `episodeIsPersistable(ep: Episode, downloadedIds: Set<string>, now: Date): boolean` — returns `true` when:
|
||||
- `ep.pubDate` is missing/not a valid `Date` (fail-safe: never drop an undatable episode), OR
|
||||
- `ep.pubDate.getTime() >= now.getTime() - PERSISTED_WINDOW_DAYS * 24 * 3600 * 1000`, OR
|
||||
- `downloadedIds.has(ep.id)`.
|
||||
- New exported constant `EPISODE_WINDOW_DAYS = 30` — the lifecycle window: bounds BOTH persistence (here) and the volatile episode list/cache (task 02).
|
||||
- New exported pure function `episodeInWindow(ep: Episode, now: Date): boolean` — returns `true` when `ep.pubDate` is missing/not a valid `Date` (fail-safe: never drop an undatable episode) OR `ep.pubDate.getTime() >= now.getTime() - EPISODE_WINDOW_DAYS * 24 * 3600 * 1000`.
|
||||
- New exported pure function `episodeIsPersistable(ep: Episode, downloadedIds: Set<string>, now: Date): boolean` — returns `true` when `downloadedIds.has(ep.id)` OR `episodeInWindow(ep, now)`.
|
||||
- New (module-private) async helper `readDownloadedEpisodeIds(): Promise<Set<string>>` — reads `getConfigFilePath("downloads.json")` with `Bun.file`, returns the `episodeId`s of records whose `status` equals `DownloadStatus.COMPLETED`; returns an empty set on any error or missing file. Note: an episode whose download is merely in-flight is NOT exempted; it will be re-included by the next save after completion, since the in-memory `feed.episodes` still holds it — document this in the function comment.
|
||||
- `saveFeedsToFile(feeds: Feed[])` — before calling `updateConfig`, map each feed to `{ ...feed, episodes: feed.episodes.filter(ep => episodeIsPersistable(ep, downloadedIds, new Date())) }`. The downloaded-ids lookup is async, so wrap the whole body in a fire-and-forget async IIFE (`.catch(() => {})`) that preserves the existing sync/fire-and-forget signature; on any lookup failure, save the feeds unpruned (never lose data on an error path).
|
||||
- `loadFeedsFromFile()` — after `reviveDates`, apply the same prune to the loaded feeds; if the prune removed at least one episode, call `saveFeedsToFile(pruned)` to rewrite `config.json` (this is the startup cleanup for legacy configs). `await` the prune path deterministically (the function is already async).
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
# 02. Merge refreshes against the volatile in-memory episode window with bounded per-feed caches
|
||||
# 02. Merge refreshes against the volatile in-memory episode window with a date-windowed cache
|
||||
|
||||
meta:
|
||||
id: bounded-feed-lifecycle-02
|
||||
@@ -9,7 +9,7 @@ meta:
|
||||
|
||||
objective:
|
||||
|
||||
- Refreshing a feed must UNION the freshly fetched latest window with the episodes already in memory (instead of replacing), so episodes that task 01 pruned from disk — or deep episodes pulled in via "Fetch More" — survive refreshes within a session. Bound in-memory retention so memory stops growing unbounded (`fullEpisodeCache` currently holds every parsed episode of every feed ever fetched).
|
||||
- Refreshing a feed must UNION the freshly fetched latest window with the episodes already in memory (instead of replacing), so episodes that task 01 pruned from disk — or deep episodes pulled in via "Fetch More" — survive refreshes within a session. Bound in-memory retention by the SAME date window persistence uses (`EPISODE_WINDOW_DAYS`, 30 days) instead of an episode count: the visible list and the pagination cache hold every episode from the last 30 days, and episodes older than that age out of the list on the next refresh (`fullEpisodeCache` currently holds every parsed episode of every feed ever fetched).
|
||||
|
||||
background (read this before touching code):
|
||||
|
||||
@@ -17,52 +17,58 @@ background (read this before touching code):
|
||||
- `fetchEpisodes(feedUrl, limit, feedId?)` parses the whole feed, stores ALL episodes in the module-level `fullEpisodeCache` Map, returns the first `limit`.
|
||||
- `refreshFeed` / `refreshAllFeeds` pass the fetched window through `applyRefreshedEpisodes`, which REPLACES `feed.episodes` when ids differ (`sameEpisodes` id-set compare; unchanged → keep object identity and skip save — this order-stability contract is pinned by `tests/feed-refresh.test.ts` and must keep passing).
|
||||
- `loadMoreEpisodesForFeed` grows the displayed window from `fullEpisodeCache` (fetching+parsing the full feed when the cache is cold — e.g. after a restart), tracking progress in `episodeLoadCount`.
|
||||
- Task 01 made persistence prune everything over 30 days old (except completed downloads). After a restart, `feed.episodes` therefore only contains the 30-day persisted window; the full cached episode list is rebuilt lazily by the first fetch-more or refresh within the new session. This task makes the session-time behavior correct: old episodes stay browsable until the app exits, fetched refreshes never shrink the list.
|
||||
- Task 01 made persistence prune everything over 30 days old (except completed downloads). After a restart, `feed.episodes` therefore only contains the 30-day persisted window; the full cached episode list is rebuilt lazily by the first fetch-more or refresh within the new session. This task makes the session-time behavior correct: fetched refreshes merge (never replace), and the volatile list + cache are bounded by the SAME 30-day window persistence uses — what can be browsed is exactly what can be persisted, and episodes older than the window age out on refresh.
|
||||
- Style: `feed.ts` is tab-indented WITH semicolons. New utils file: match `src/api/rss-parser.ts` style (2-space, no semicolons).
|
||||
|
||||
deliverables:
|
||||
|
||||
- New `src/utils/episode-merge.ts` (pure, store-free, unit-testable):
|
||||
- `mergeEpisodes(existing: Episode[], fetched: Episode[], cap: number): Episode[]` — union by `ep.id`; on id collision the `fetched` copy wins (fresh metadata); result sorted by `pubDate` descending; truncated to `cap` entries (the OLDEST are dropped — after sorting, a plain `.slice(0, cap)`).
|
||||
- `src/utils/feeds-persistence.ts` (the canonical window owner):
|
||||
- Rename the retention constant to `EPISODE_WINDOW_DAYS = 30` — it now bounds the volatile cache/list as well as persistence.
|
||||
- New exported `episodeInWindow(ep: Episode, now: Date): boolean` — `pubDate >= now - EPISODE_WINDOW_DAYS`; missing/invalid pubDates are ALWAYS kept (fail-safe mirror of the persistence rule, so cache and disk can never disagree about an undatable episode). `episodeIsPersistable` becomes `downloadedIds.has(ep.id) || episodeInWindow(ep, now)`.
|
||||
- Rework `src/utils/episode-merge.ts` (pure, store-free, unit-testable):
|
||||
- `mergeEpisodesInWindow(existing: Episode[], fetched: Episode[], now: Date): Episode[]` — union by `ep.id`; on id collision the `fetched` copy wins (fresh metadata); result sorted by `pubDate` descending; pruned to the lifecycle window via `episodeInWindow` (out-of-window episodes dropped, undated kept). No count cap — the bound is the date.
|
||||
- Invariants: never mutates inputs; stable output for `existing=[]`; entries with invalid `pubDate` sort as newest (use `getTime()`, treat `NaN` as `+Infinity` with a small `ts()` helper).
|
||||
- `src/stores/feed.ts`:
|
||||
- New constant `MAX_EPISODES_IN_MEMORY = 500` (comment: per-feed bound on both the cached parse results and the merged in-memory window; 500 covers years of a weekly show's history while capping a 20-subscription install at 10k episodes).
|
||||
- `fetchEpisodes`: cap what goes into `fullEpisodeCache` — `fullEpisodeCache.set(feedId, allEpisodes.slice(0, MAX_EPISODES_IN_MEMORY))` (the array is already sorted newest-first via `sortEpisodesReverseChronological`). The LIMIT window returned to callers is unchanged.
|
||||
- Delete `MAX_EPISODES_IN_MEMORY` — no episode-count bound anywhere.
|
||||
- `fetchEpisodes`: window-filter the parsed feed (`allEpisodes.filter(ep => episodeInWindow(ep, new Date()))`) BEFORE caching and returning: `fullEpisodeCache.set(feedId, windowed)` and `episodes: windowed.slice(0, limit)`. The limit is a page size; the window is the bound.
|
||||
- `applyRefreshedEpisodes(prev, feedId, episodes)`: replace the `sameEpisodes` replace-with-fetched logic with merge semantics:
|
||||
- Compute `merged = mergeEpisodes(f.episodes, episodes, MAX_EPISODES_IN_MEMORY)`.
|
||||
- Compute `merged = mergeEpisodesInWindow(f.episodes, episodes, new Date())`.
|
||||
- Unchanged detection must compare the FETCHED window against the corresponding prefix of the existing list, i.e. keep a small `sameRefreshWindow(existing: Episode[], fetched: Episode[])` helper next to (and replacing the use of) `sameEpisodes`: `fetched.length === 0 → true`; otherwise compare id-sets of `fetched` and `existing.slice(0, fetched.length)`. Rationale: with union semantics `merged` legitimately contains episodes beyond the fetched window, so comparing full lists would bump `lastUpdated` on every refresh and resurrect the order-flapping bug `tests/feed-refresh.test.ts` guards.
|
||||
- Return unmodified `prev` when every feed's window is unchanged (preserve the existing identity-no-save contract); on change, set `{ ...f, episodes: merged, lastUpdated: new Date() }`.
|
||||
- Delete the now-unused `sameEpisodes` if nothing else references it (grep first: `grep sameEpisodes src tests`).
|
||||
- `loadMoreEpisodesForFeed`: cap the cold-refetch cache the same way after `parseEpisodesIncremental` (it's unsorted there — wrap with `sortEpisodesReverseChronological` before capping); everything else (window growth by `MAX_EPISODES_REFRESH`, `hasMoreEpisodes` comparing `episodeLoadCount < cached.length`) works unchanged against the capped cache.
|
||||
- `tests/feed-volatile-merge.test.ts` (new) — see tests section.
|
||||
- `loadMoreEpisodesForFeed`: window-filter the cold-refetch cache the same way after `parseEpisodesIncremental` (it's unsorted there — wrap with `sortEpisodesReverseChronological` before filtering); everything else (window growth by `MAX_EPISODES_REFRESH`, `hasMoreEpisodes` comparing `episodeLoadCount < cached.length`) works unchanged against the filtered cache.
|
||||
- `tests/feed-volatile-merge.test.ts` (reworked) — see tests section.
|
||||
|
||||
steps:
|
||||
|
||||
1. Read `src/stores/feed.ts` fully and `tests/feed-refresh.test.ts` + `tests/feed-pagination.test.ts` (they pin the contracts you must not break; reuse their harness).
|
||||
2. Write `src/utils/episode-merge.ts` with `mergeEpisodes`.
|
||||
3. Integrate in `feed.ts`: replace `sameEpisodes` usage with `sameRefreshWindow` + `mergeEpisodes` in `applyRefreshedEpisodes`; cap `fullEpisodeCache` writes in `fetchEpisodes` and `loadMoreEpisodesForFeed`; add `MAX_EPISODES_IN_MEMORY`.
|
||||
2. Rework `src/utils/episode-merge.ts` to `mergeEpisodesInWindow`; add `episodeInWindow` (and rename `PERSISTED_WINDOW_DAYS` → `EPISODE_WINDOW_DAYS`) in `feeds-persistence.ts`.
|
||||
3. Integrate in `feed.ts`: replace `sameEpisodes` usage with `sameRefreshWindow` + `mergeEpisodesInWindow` in `applyRefreshedEpisodes`; window-filter `fullEpisodeCache` writes and the returned window in `fetchEpisodes` and `loadMoreEpisodesForFeed`; delete `MAX_EPISODES_IN_MEMORY`.
|
||||
4. Run the existing feed tests — all must pass unchanged (merge must keep order stability and pagination intact).
|
||||
5. Write the new tests, run, then full suite + lint.
|
||||
|
||||
tests:
|
||||
|
||||
- New `tests/feed-volatile-merge.test.ts`:
|
||||
- Pure unit (Arrange–Act–Assert) for `mergeEpisodes`:
|
||||
- Pure unit (Arrange–Act–Assert) for `mergeEpisodesInWindow(existing, fetched, now)`:
|
||||
- dedupe on collision, fetched copy wins (mutate title in the fetched twin, assert the merged entry shows the new title).
|
||||
- union of disjoint lists sorted by `pubDate` desc.
|
||||
- cap trimming drops the oldest: `cap=2`, three episodes spanning three days → the two newest survive.
|
||||
- window prune drops out-of-window episodes from BOTH inputs and keeps undated (NaN pubDate) episodes.
|
||||
- input arrays not mutated.
|
||||
- Store integration (harness per `tests/feed-refresh.test.ts`: temp `XDG_CONFIG_HOME` BEFORE imports, `Bun.serve` on port 0 serving generated RSS, fake timers):
|
||||
- Refresh-keeps-volatile-window: serve 3 episodes at t0, `addFeed`; then serve the same 3 plus 2 new ones, `refreshFeed`. Assert `feed.episodes.length === 5` AND `lastUpdated` advanced AND a second identical refresh leaves `lastUpdated` untouched (window-compare, not union-compare).
|
||||
- Bounded cache: serve 600 items (generate programmatically), refresh, then `hasMoreEpisodes` grows only to the cap: loop `loadMoreEpisodes` until it returns false and assert total loaded ≤ `MAX_EPISODES_IN_MEMORY` (import the constant from the store module if exported, else assert `=== 500`).
|
||||
- Boundary: a 25-day-old episode loads; a 31-day-old episode is neither visible nor cached.
|
||||
- Out-of-window never cached: 600 items at 2h spacing span ~50 days — only the in-window tail is loadable (fewer than the old 500 cap), `hasMoreEpisodes` flips false there.
|
||||
- No count ceiling: 600 items at 1h spacing (all within 25 days) are ALL loadable — the bound is the date, not a number.
|
||||
- Clock constraint: these tests run under fake timers, and a large `vi.advanceTimersByTime` (past ~5 days of fake time) makes Bun 1.3.8 hang every subsequent network fetch — the boundary is pinned with relative pubDates, never by moving the clock across it.
|
||||
- Existing suites that must keep passing: `tests/feed-refresh.test.ts`, `tests/feed-pagination.test.ts`, `tests/feed-refresh-spinner.test.tsx`.
|
||||
|
||||
acceptance_criteria:
|
||||
|
||||
- A refresh never removes an episode that was visible before the refresh during the same session.
|
||||
- A refresh never removes an episode that was visible before the refresh during the same session — except episodes that aged past the window, which drop out on refresh (the date bound).
|
||||
- An unchanged refresh does not bump `lastUpdated` (object identity of the feed is preserved).
|
||||
- Per-feed cached/parsed episodes never exceed `MAX_EPISODES_IN_MEMORY`; `loadMore` stops (hasMore → false) at the cap.
|
||||
- After a simulated restart (fresh store boot from a pruned config), fetch-more re-parses the feed and can surface over-30-day episodes in volatile memory.
|
||||
- Per-feed cached/parsed episodes are exactly the in-window set: nothing outside the last `EPISODE_WINDOW_DAYS` days is cached or loadable, and everything inside is (no count ceiling).
|
||||
- After a simulated restart (fresh store boot from a pruned config), fetch-more re-parses the feed and applies the same window to the cache.
|
||||
- `bun test` full suite passes; `bun run lint` clean.
|
||||
|
||||
validation:
|
||||
@@ -70,10 +76,10 @@ validation:
|
||||
- `bun test tests/feed-volatile-merge.test.ts tests/feed-refresh.test.ts tests/feed-pagination.test.ts`
|
||||
- `bun test`
|
||||
- `bun run lint`
|
||||
- Manual smoke: `bun start`, drill a show in My Shows, fetch-more a few pages, press `r` to refresh — the deep pages stay; quit and relaunch — deep (over-30-day) pages are gone from the list but fetch-more brings them back.
|
||||
- Manual smoke: `bun start`, drill a show in My Shows, fetch-more a few pages, press `r` to refresh — the in-window pages stay; quit and relaunch — the list holds only the 30-day window, and fetch-more re-parses the feed with the same window applied.
|
||||
|
||||
notes:
|
||||
|
||||
- Depends on task 01 only conceptually: without the persisted-window prune, this merge is still correct but harder to observe. If 01 isn't merged yet, the store tests still pass; the "restart keeps only 30 days" manual check requires 01.
|
||||
- `fullEpisodeCache`/`episodeLoadCount` are module-level Maps in `feed.ts` — the cap belongs at the two write sites named in deliverables, not in a wrapper.
|
||||
- `fullEpisodeCache`/`episodeLoadCount` are module-level Maps in `feed.ts` — the window filter belongs at the two write sites named in deliverables, not in a wrapper.
|
||||
- Do not touch persistence writes in this task; debounced save behavior is task 03. Keep calling the module-scope `saveFeeds(updated)` helper exactly as today.
|
||||
|
||||
@@ -21,7 +21,7 @@ Dependencies
|
||||
Exit criteria
|
||||
|
||||
- After any refresh + save, `config.json` `feeds[*].episodes` contains only episodes with `pubDate` within the last 30 days or episodes marked `completed` in `downloads.json`; loading a legacy config prunes stale episodes on first launch.
|
||||
- In-memory retention is capped per feed; episodes aged out of the persisted window remain browsable within the session and are re-fetchable via fetch-more after a restart.
|
||||
- The volatile episode list and pagination cache are bounded by the same 30-day window as persistence: only in-window episodes are cached/loadable, and everything in-window is (no episode-count ceiling).
|
||||
- A refresh batch never exceeds a fixed fetch concurrency, applies each feed's result as it lands (no `Promise.all` barrier), and persistence writes are debounced; keyboard input stays responsive throughout.
|
||||
- The top-right indicator is visible iff at least one feed refresh, fetch-more, subscribe fetch, search, or episode download is in flight, hidden otherwise.
|
||||
- `bun test` and `bun run lint` pass.
|
||||
|
||||
@@ -278,3 +278,87 @@ test.skipIf(!hasFfmpeg)(
|
||||
},
|
||||
{ timeout: 20000 },
|
||||
);
|
||||
|
||||
test.skipIf(!hasFfmpeg)(
|
||||
"decode head caps at maxAheadSec ahead of the cursor — the cache is a window, not a whole-episode dump",
|
||||
async () => {
|
||||
const wav = tmpWav();
|
||||
writeSineWav(wav, 30);
|
||||
const cache = new EpisodePcmCache({
|
||||
url: wav,
|
||||
maxAheadSec: 4,
|
||||
keepBehindSec: 2,
|
||||
});
|
||||
try {
|
||||
cache.startDecode(0);
|
||||
// The 8s initial burst delivers the front of the file instantly.
|
||||
await waitForCoverage(cache, 5);
|
||||
|
||||
// Park the cursor at 0 and drive the cap (the render loop reads
|
||||
// every frame; the cap applies on the first read past the head).
|
||||
const out = new Float64Array(512);
|
||||
for (let i = 0; i < 30 && cache.decoding; i++) {
|
||||
cache.readWindow(out, 0);
|
||||
await Bun.sleep(20);
|
||||
}
|
||||
|
||||
// Paused at the head budget (4s) + one 8s burst of slack — NOT
|
||||
// decoded to the 30s EOF.
|
||||
expect(cache.decoding).toBe(false);
|
||||
expect(cache.coverageEndSec).toBeGreaterThanOrEqual(4);
|
||||
expect(cache.coverageEndSec).toBeLessThanOrEqual(4 + 8 + 1);
|
||||
expect(cache.decodeFinished).toBe(false);
|
||||
|
||||
// A parked cursor keeps the cap: more reads must not restart
|
||||
// the pass or grow the cache.
|
||||
const cappedAt = cache.coverageEndSec;
|
||||
for (let i = 0; i < 10; i++) {
|
||||
cache.readWindow(out, 0);
|
||||
await Bun.sleep(20);
|
||||
}
|
||||
expect(cache.decoding).toBe(false);
|
||||
expect(cache.coverageEndSec).toBeLessThanOrEqual(cappedAt + 1);
|
||||
} finally {
|
||||
cache.stop();
|
||||
await Bun.$`rm -f ${wav}`.quiet();
|
||||
}
|
||||
},
|
||||
{ timeout: 20000 },
|
||||
);
|
||||
|
||||
test.skipIf(!hasFfmpeg)(
|
||||
"the window prunes segments behind the cursor as playback advances",
|
||||
async () => {
|
||||
const wav = tmpWav();
|
||||
writeSineWav(wav, 30);
|
||||
const cache = new EpisodePcmCache({
|
||||
url: wav,
|
||||
maxAheadSec: 4,
|
||||
keepBehindSec: 2,
|
||||
});
|
||||
try {
|
||||
// Two segments: the back half [10, ~18] and, after the seek,
|
||||
// the front [2, ~10].
|
||||
cache.startDecode(10);
|
||||
await waitForCoverage(cache, 11);
|
||||
cache.ensureDecodeAround(2);
|
||||
await waitForCoverage(cache, 2.2);
|
||||
expect(cache.covers(2.5)).toBe(true);
|
||||
expect(cache.covers(10.5)).toBe(true);
|
||||
|
||||
// Cursor advances past the front segment's end + keepBehind:
|
||||
// the front must fall out of the window, the back must survive.
|
||||
const out = new Float64Array(512);
|
||||
for (let i = 0; i < 40 && cache.covers(2.5); i++) {
|
||||
cache.readWindow(out, 13);
|
||||
await Bun.sleep(25);
|
||||
}
|
||||
expect(cache.covers(2.5)).toBe(false);
|
||||
expect(cache.covers(10.5)).toBe(true);
|
||||
} finally {
|
||||
cache.stop();
|
||||
await Bun.$`rm -f ${wav}`.quiet();
|
||||
}
|
||||
},
|
||||
{ timeout: 20000 },
|
||||
);
|
||||
|
||||
@@ -3,11 +3,12 @@
|
||||
* row in a drilled show's episode list (My Shows depth 1) and the Feed
|
||||
* page's row.
|
||||
*
|
||||
* addFeed caches the FULL parsed feed while exposing only the first
|
||||
* MAX_EPISODES_SUBSCRIBE (20) episodes. `hasMoreEpisodes` reports when the
|
||||
* cache holds more than the loaded window; `loadMoreEpisodes` advances that
|
||||
* window in MAX_EPISODES_REFRESH (50) chunks until it is exhausted. This
|
||||
* pins:
|
||||
* addFeed caches every episode inside the lifecycle window (the last
|
||||
* EPISODE_WINDOW_DAYS days — the date bound, not a count) while exposing
|
||||
* only the first MAX_EPISODES_SUBSCRIBE (20) episodes. `hasMoreEpisodes`
|
||||
* reports when the cache holds more than the loaded window;
|
||||
* `loadMoreEpisodes` advances that window in MAX_EPISODES_REFRESH (50)
|
||||
* chunks until it is exhausted. This pins:
|
||||
* 1. A freshly subscribed feed with a longer cache reports hasMoreEpisodes.
|
||||
* 2. loadMoreEpisodes grows that feed's episodes from the cache (no refetch
|
||||
* needed) and hasMoreEpisodes flips false once the window reaches the end.
|
||||
@@ -27,6 +28,8 @@ process.env.XDG_CONFIG_HOME = configHome;
|
||||
import { useFeedStore } from "../src/stores/feed";
|
||||
import type { Podcast } from "../src/types/podcast";
|
||||
|
||||
const HOUR = 3600 * 1000;
|
||||
|
||||
interface ServedEpisode {
|
||||
title: string;
|
||||
date: string;
|
||||
@@ -94,10 +97,12 @@ afterAll(() => {
|
||||
|
||||
test("loadMoreEpisodes advances one feed's window from the cache, then no-ops", async () => {
|
||||
const store = useFeedStore();
|
||||
// 60 episodes: 20 shown at subscribe, 40 held back in the cache.
|
||||
// 60 episodes: 20 shown at subscribe, 40 held back in the cache. All
|
||||
// inside the lifecycle window (11h apart ≈ 27.5 days) so every one is
|
||||
// cacheable — the cache bound is the date window, not a count.
|
||||
servedEpisodes = Array.from({ length: 60 }, (_, i) => ({
|
||||
title: `Ep ${60 - i}`,
|
||||
date: new Date(Date.UTC(2026, 0, 1 + i)).toISOString(),
|
||||
date: new Date(Date.now() - (60 - i) * 11 * HOUR).toISOString(),
|
||||
}));
|
||||
const feedUrl = `http://127.0.0.1:${server!.port}/paged.xml`;
|
||||
const feed = await store.addFeed(makePodcast(feedUrl), "test-source");
|
||||
@@ -123,9 +128,10 @@ test("loadMoreEpisodes advances one feed's window from the cache, then no-ops",
|
||||
test("hasMoreEpisodes stays true across chunked loads until the end", async () => {
|
||||
const store = useFeedStore();
|
||||
// 120 episodes: 20 shown, 100 cached — two 50-episode chunks remaining.
|
||||
// All inside the lifecycle window (5h apart = 25 days).
|
||||
servedEpisodes = Array.from({ length: 120 }, (_, i) => ({
|
||||
title: `Ep ${120 - i}`,
|
||||
date: new Date(Date.UTC(2026, 0, 1 + i)).toISOString(),
|
||||
date: new Date(Date.now() - (120 - i) * 5 * HOUR).toISOString(),
|
||||
}));
|
||||
const feedUrl = `http://127.0.0.1:${server!.port}/paged-chunked.xml`;
|
||||
const feed = await store.addFeed(makePodcast(feedUrl), "test-source");
|
||||
|
||||
@@ -41,11 +41,12 @@ let delayMs = 0;
|
||||
let feedUrl = "";
|
||||
let feedId = "";
|
||||
|
||||
/** 3 episodes × 3 rows = 9 list rows: the spinner sits right below them. */
|
||||
/** 3 episodes × 3 rows = 9 list rows: the spinner sits right below them.
|
||||
* Dated inside the lifecycle window (1–3 days ago) so all three render. */
|
||||
function feedXml(origin: string): string {
|
||||
const items = Array.from({ length: 3 }, (_, i) => `<item>
|
||||
<title>Spin Ep ${3 - i}</title>
|
||||
<pubDate>${new Date(Date.UTC(2026, 0, 1 + i)).toISOString()}</pubDate>
|
||||
<pubDate>${new Date(Date.now() - (3 - i) * 24 * 3600 * 1000).toISOString()}</pubDate>
|
||||
<enclosure url="${origin}/audio-${i}.mp3" length="12345" type="audio/mpeg"/>
|
||||
</item>`).join("\n");
|
||||
return `<?xml version="1.0" encoding="UTF-8"?>
|
||||
|
||||
@@ -29,6 +29,8 @@ process.env.XDG_CONFIG_HOME = configHome;
|
||||
import { useFeedStore } from "../src/stores/feed";
|
||||
import type { Podcast } from "../src/types/podcast";
|
||||
|
||||
const HOUR = 3600 * 1000;
|
||||
|
||||
interface ServedEpisode {
|
||||
title: string;
|
||||
date: string;
|
||||
@@ -193,10 +195,12 @@ test("refreshAllFeeds keeps unchanged feeds' order and timestamps", async () =>
|
||||
test("refresh parses in bounded chunks, yielding to the event loop between them", async () => {
|
||||
const store = useFeedStore();
|
||||
// 60 episodes: a chunked parse (25/chunk) must yield between chunks; a
|
||||
// monolithic parse would complete without yielding at all.
|
||||
// monolithic parse would complete without yielding at all. All dated
|
||||
// inside the lifecycle window (11h apart ≈ 27.5 days) so every one is
|
||||
// cacheable and the window assertions below hold.
|
||||
servedEpisodes = Array.from({ length: 60 }, (_, i) => ({
|
||||
title: `Ep ${60 - i}`,
|
||||
date: new Date(Date.UTC(2026, 0, 1 + i)).toISOString(),
|
||||
date: new Date(Date.now() - (60 - i) * 11 * HOUR).toISOString(),
|
||||
}));
|
||||
const feedUrl = `http://127.0.0.1:${server!.port}/chunky.xml`;
|
||||
const feed = await store.addFeed(makePodcast(feedUrl), "test-source");
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
* Bounded-feed-lifecycle persistence tests — task 01 (retention window).
|
||||
*
|
||||
* Pins the persistence contract:
|
||||
* 1. saveFeedsToFile never writes an episode older than PERSISTED_WINDOW_DAYS
|
||||
* 1. saveFeedsToFile never writes an episode older than DEFAULT_EPISODE_WINDOW_DAYS
|
||||
* unless its id is a completed download in downloads.json.
|
||||
* 2. loadFeedsFromFile prunes over-window episodes from legacy configs and
|
||||
* rewrites config.json when it pruned anything.
|
||||
@@ -27,7 +27,7 @@ const configHome = mkdtempSync(join(tmpdir(), "podtui-retention-"));
|
||||
process.env.XDG_CONFIG_HOME = configHome;
|
||||
|
||||
import {
|
||||
PERSISTED_WINDOW_DAYS,
|
||||
DEFAULT_EPISODE_WINDOW_DAYS,
|
||||
episodeIsPersistable,
|
||||
loadFeedsFromFile,
|
||||
saveFeedsToFile,
|
||||
@@ -134,18 +134,18 @@ afterAll(() => {
|
||||
|
||||
// ── Unit: episodeIsPersistable ──────────────────────────────────────────────
|
||||
|
||||
test("episodeIsPersistable drops a 40-day-old episode that is not downloaded", () => {
|
||||
test("episodeIsPersistable drops a 70-day-old episode that is not downloaded", () => {
|
||||
const ep = makeEpisode({
|
||||
id: "old-plain-id",
|
||||
pubDate: new Date(Date.now() - 40 * DAY),
|
||||
pubDate: new Date(Date.now() - 70 * DAY),
|
||||
});
|
||||
expect(episodeIsPersistable(ep, new Set(), new Date())).toBe(false);
|
||||
});
|
||||
|
||||
test("episodeIsPersistable keeps a 40-day-old episode whose id is a completed download", () => {
|
||||
test("episodeIsPersistable keeps a 70-day-old episode whose id is a completed download", () => {
|
||||
const ep = makeEpisode({
|
||||
id: "old-downloaded-id",
|
||||
pubDate: new Date(Date.now() - 40 * DAY),
|
||||
pubDate: new Date(Date.now() - 70 * DAY),
|
||||
});
|
||||
expect(
|
||||
episodeIsPersistable(ep, new Set(["old-downloaded-id"]), new Date()),
|
||||
@@ -165,8 +165,8 @@ test("episodeIsPersistable keeps an episode with an invalid pubDate", () => {
|
||||
expect(episodeIsPersistable(ep, new Set(), new Date())).toBe(true);
|
||||
});
|
||||
|
||||
test("PERSISTED_WINDOW_DAYS is 30", () => {
|
||||
expect(PERSISTED_WINDOW_DAYS).toBe(30);
|
||||
test("DEFAULT_EPISODE_WINDOW_DAYS is 60", () => {
|
||||
expect(DEFAULT_EPISODE_WINDOW_DAYS).toBe(60);
|
||||
});
|
||||
|
||||
// ── Save path: retention window applied with completed-download exemption ──
|
||||
@@ -199,11 +199,11 @@ test("saveFeedsToFile prunes over-window episodes but keeps completed downloads"
|
||||
}),
|
||||
makeEpisode({
|
||||
id: "old-plain-id",
|
||||
pubDate: new Date(Date.now() - 40 * DAY),
|
||||
pubDate: new Date(Date.now() - 70 * DAY),
|
||||
}),
|
||||
makeEpisode({
|
||||
id: "old-downloaded-id",
|
||||
pubDate: new Date(Date.now() - 40 * DAY),
|
||||
pubDate: new Date(Date.now() - 70 * DAY),
|
||||
}),
|
||||
]);
|
||||
saveFeedsToFile([feed]);
|
||||
@@ -249,7 +249,7 @@ test("loadFeedsFromFile prunes over-window episodes and rewrites config.json", a
|
||||
description: "",
|
||||
audioUrl: "https://example.com/audio/old-a.mp3",
|
||||
duration: 60,
|
||||
pubDate: new Date(Date.now() - 40 * DAY).toISOString(),
|
||||
pubDate: new Date(Date.now() - 70 * DAY).toISOString(),
|
||||
},
|
||||
{
|
||||
id: "old-b",
|
||||
@@ -258,7 +258,7 @@ test("loadFeedsFromFile prunes over-window episodes and rewrites config.json", a
|
||||
description: "",
|
||||
audioUrl: "https://example.com/audio/old-b.mp3",
|
||||
duration: 60,
|
||||
pubDate: new Date(Date.now() - 40 * DAY).toISOString(),
|
||||
pubDate: new Date(Date.now() - 70 * DAY).toISOString(),
|
||||
},
|
||||
],
|
||||
visibility: "public",
|
||||
|
||||
@@ -1,19 +1,21 @@
|
||||
/**
|
||||
* Volatile in-memory episode merge + bounded cache tests.
|
||||
* Configurable episode cache + volatile merge tests.
|
||||
*
|
||||
* Two behaviors from the bounded-feed-lifecycle work:
|
||||
* 1. mergeEpisodes unions refreshed episodes with what's already in memory
|
||||
* (the fetched copy wins on id collision), so a refresh never shrinks
|
||||
* the session's visible window; the union is capped per feed at
|
||||
* MAX_EPISODES_IN_MEMORY.
|
||||
* 2. The per-feed parse cache is capped at MAX_EPISODES_IN_MEMORY, so
|
||||
* loadMoreEpisodes can never surface more than the cap and
|
||||
* hasMoreEpisodes flips false there.
|
||||
* The episode list cache (what the Feed and My Shows pages show) is bounded by
|
||||
* the user's preference: a date window (default 60 days) or a count (default
|
||||
* 25). The full parse cache holds ALL episodes; fetch-more pages beyond the
|
||||
* bound from that cache (volatile — never written back). These tests pin:
|
||||
* 1. mergeEpisodesBounded unions refreshed episodes with what's in memory
|
||||
* (fetched copy wins on id collision) and prunes by the supplied keep
|
||||
* predicate (count or date). Undated episodes are always kept.
|
||||
* 2. The store bounds the visible list by the configured mode, but the
|
||||
* full parse cache survives — fetch-more pages beyond the bound.
|
||||
* 3. Refresh merge never shrinks the in-memory list except via the bound.
|
||||
*
|
||||
* Unchanged-refresh detection compares the fetched window against the
|
||||
* corresponding PREFIX of the merged list (sameRefreshWindow) — comparing
|
||||
* full lists would bump lastUpdated on every refresh because the merged list
|
||||
* legitimately holds episodes beyond the fetched window.
|
||||
* Clock constraint: these tests run under vi.useFakeTimers, and a LARGE
|
||||
* vi.advanceTimersByTime (past ~5 days of fake time) makes every subsequent
|
||||
* network fetch hang in Bun 1.3.8's fake-timer implementation. The date
|
||||
* boundary is pinned with relative pubDates, never by moving the clock.
|
||||
*/
|
||||
|
||||
import { test, expect, beforeAll, afterAll, beforeEach, vi } from "bun:test";
|
||||
@@ -26,11 +28,16 @@ import { join } from "path";
|
||||
const configHome = mkdtempSync(join(tmpdir(), "podtui-volatile-"));
|
||||
process.env.XDG_CONFIG_HOME = configHome;
|
||||
|
||||
import { MAX_EPISODES_IN_MEMORY, useFeedStore } from "../src/stores/feed";
|
||||
import { mergeEpisodes } from "../src/utils/episode-merge";
|
||||
import { useFeedStore } from "../src/stores/feed";
|
||||
import { mergeEpisodesBounded } from "../src/utils/episode-merge";
|
||||
import { episodeInWindow } from "../src/utils/feeds-persistence";
|
||||
import { useAppStore } from "../src/stores/app";
|
||||
import type { Episode } from "../src/types/episode";
|
||||
import type { Podcast } from "../src/types/podcast";
|
||||
|
||||
const HOUR = 3600 * 1000;
|
||||
const DAY = 24 * HOUR;
|
||||
|
||||
interface ServedEpisode {
|
||||
title: string;
|
||||
date: string;
|
||||
@@ -38,13 +45,8 @@ interface ServedEpisode {
|
||||
|
||||
let server: ReturnType<typeof Bun.serve> | null = null;
|
||||
let servedEpisodes: ServedEpisode[] = [];
|
||||
// Bun runs test files in ONE process, so the store singleton is shared with
|
||||
// the other feed test files. Track the feeds we add and remove them in
|
||||
// afterAll so whichever file runs next sees a pristine store (execution
|
||||
// order between files is not guaranteed).
|
||||
const addedFeedIds: string[] = [];
|
||||
|
||||
/** XML for the current served episode list (episode ids = feedUrl#index). */
|
||||
function feedXml(episodes: ServedEpisode[], origin: string): string {
|
||||
const items = episodes
|
||||
.map(
|
||||
@@ -104,16 +106,17 @@ beforeEach(() => {
|
||||
|
||||
afterAll(() => {
|
||||
vi.useRealTimers();
|
||||
// Leave the shared singleton as we found it (see addedFeedIds note).
|
||||
const store = useFeedStore();
|
||||
for (const id of addedFeedIds) store.removeFeed(id);
|
||||
server?.stop(true);
|
||||
rmSync(configHome, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
// ── mergeEpisodes unit tests ─────────────────────────────────────────────
|
||||
// ── mergeEpisodesBounded unit tests ──────────────────────────────────────
|
||||
|
||||
test("mergeEpisodes dedupes on id collision and keeps the fetched copy", () => {
|
||||
const NOW = new Date("2026-08-10T00:00:00Z");
|
||||
|
||||
test("mergeEpisodesBounded dedupes on id collision and keeps the fetched copy", () => {
|
||||
const existing = [
|
||||
makeEpisode("a", "Old Title", new Date("2026-08-01T00:00:00Z")),
|
||||
makeEpisode("b", "Ep B", new Date("2026-08-02T00:00:00Z")),
|
||||
@@ -121,14 +124,15 @@ test("mergeEpisodes dedupes on id collision and keeps the fetched copy", () => {
|
||||
const fetched = [
|
||||
makeEpisode("a", "New Title", new Date("2026-08-01T00:00:00Z")),
|
||||
];
|
||||
const keepAll = () => true;
|
||||
|
||||
const merged = mergeEpisodes(existing, fetched, 10);
|
||||
const merged = mergeEpisodesBounded(existing, fetched, keepAll);
|
||||
|
||||
expect(merged).toHaveLength(2);
|
||||
expect(merged.find((e) => e.id === "a")!.title).toBe("New Title");
|
||||
});
|
||||
|
||||
test("mergeEpisodes unions disjoint lists sorted newest-first", () => {
|
||||
test("mergeEpisodesBounded unions disjoint lists sorted newest-first", () => {
|
||||
const existing = [
|
||||
makeEpisode("old", "Old", new Date("2026-08-01T00:00:00Z")),
|
||||
];
|
||||
@@ -136,13 +140,14 @@ test("mergeEpisodes unions disjoint lists sorted newest-first", () => {
|
||||
makeEpisode("newest", "Newest", new Date("2026-08-03T00:00:00Z")),
|
||||
makeEpisode("mid", "Mid", new Date("2026-08-02T00:00:00Z")),
|
||||
];
|
||||
const keepAll = () => true;
|
||||
|
||||
const merged = mergeEpisodes(existing, fetched, 10);
|
||||
const merged = mergeEpisodesBounded(existing, fetched, keepAll);
|
||||
|
||||
expect(merged.map((e) => e.id)).toEqual(["newest", "mid", "old"]);
|
||||
});
|
||||
|
||||
test("mergeEpisodes drops the oldest episodes past the cap", () => {
|
||||
test("mergeEpisodesBounded with count keep drops oldest beyond the count", () => {
|
||||
const existing = [
|
||||
makeEpisode("day1", "Day 1", new Date("2026-08-01T00:00:00Z")),
|
||||
];
|
||||
@@ -150,13 +155,32 @@ test("mergeEpisodes drops the oldest episodes past the cap", () => {
|
||||
makeEpisode("day3", "Day 3", new Date("2026-08-03T00:00:00Z")),
|
||||
makeEpisode("day2", "Day 2", new Date("2026-08-02T00:00:00Z")),
|
||||
];
|
||||
const keepCount2 = (_ep: Episode, i: number) => i < 2;
|
||||
|
||||
const merged = mergeEpisodes(existing, fetched, 2);
|
||||
const merged = mergeEpisodesBounded(existing, fetched, keepCount2);
|
||||
|
||||
expect(merged.map((e) => e.id)).toEqual(["day3", "day2"]);
|
||||
});
|
||||
|
||||
test("mergeEpisodes never mutates its inputs", () => {
|
||||
test("mergeEpisodesBounded with date keep drops out-of-window and keeps undated", () => {
|
||||
const existing = [
|
||||
makeEpisode("fresh", "Fresh", new Date("2026-08-09T00:00:00Z")),
|
||||
makeEpisode("stale", "Stale", new Date("2026-06-01T00:00:00Z")),
|
||||
makeEpisode("undated", "Undated", new Date(NaN)),
|
||||
];
|
||||
const fetched = [
|
||||
makeEpisode("newStale", "New Stale", new Date("2026-05-01T00:00:00Z")),
|
||||
makeEpisode("newFresh", "New Fresh", new Date("2026-08-08T00:00:00Z")),
|
||||
];
|
||||
// 30-day window from NOW (2026-08-10)
|
||||
const keepDate = (ep: Episode) => episodeInWindow(ep, NOW, 30);
|
||||
|
||||
const merged = mergeEpisodesBounded(existing, fetched, keepDate);
|
||||
|
||||
expect(merged.map((e) => e.id)).toEqual(["undated", "fresh", "newFresh"]);
|
||||
});
|
||||
|
||||
test("mergeEpisodesBounded never mutates its inputs", () => {
|
||||
const existing = [
|
||||
makeEpisode("a", "A", new Date("2026-08-01T00:00:00Z")),
|
||||
makeEpisode("b", "B", new Date("2026-08-02T00:00:00Z")),
|
||||
@@ -167,18 +191,15 @@ test("mergeEpisodes never mutates its inputs", () => {
|
||||
];
|
||||
const existingIds = existing.map((e) => e.id);
|
||||
const existingTitles = existing.map((e) => e.title);
|
||||
const fetchedIds = fetched.map((e) => e.id);
|
||||
const fetchedTitles = fetched.map((e) => e.title);
|
||||
const keepAll = () => true;
|
||||
|
||||
mergeEpisodes(existing, fetched, 10);
|
||||
mergeEpisodesBounded(existing, fetched, keepAll);
|
||||
|
||||
expect(existing.map((e) => e.id)).toEqual(existingIds);
|
||||
expect(existing.map((e) => e.title)).toEqual(existingTitles);
|
||||
expect(fetched.map((e) => e.id)).toEqual(fetchedIds);
|
||||
expect(fetched.map((e) => e.title)).toEqual(fetchedTitles);
|
||||
});
|
||||
|
||||
// ── store integration ────────────────────────────────────────────────────
|
||||
// ── store integration (default date mode, 60-day window) ─────────────────
|
||||
|
||||
test("refresh merges new episodes without removing the volatile window", async () => {
|
||||
const store = useFeedStore();
|
||||
@@ -195,8 +216,6 @@ test("refresh merges new episodes without removing the volatile window", async (
|
||||
expect(store.getFeed(id)!.episodes.length).toBe(3);
|
||||
const beforeUpdated = store.getFeed(id)!.lastUpdated.getTime();
|
||||
|
||||
// The feed now serves the same 3 episodes plus 2 newer ones (new ids at
|
||||
// item indices 3 and 4).
|
||||
servedEpisodes = [
|
||||
{ title: "Ep 3", date: "2026-08-03T00:00:00Z" },
|
||||
{ title: "Ep 2", date: "2026-08-02T00:00:00Z" },
|
||||
@@ -221,32 +240,92 @@ test("refresh merges new episodes without removing the volatile window", async (
|
||||
expect(afterSecond.lastUpdated.getTime()).toBe(afterFirst.lastUpdated.getTime());
|
||||
});
|
||||
|
||||
test("cached episodes are capped at MAX_EPISODES_IN_MEMORY", async () => {
|
||||
test("date mode: episodes outside the 60-day window never enter the list", async () => {
|
||||
const store = useFeedStore();
|
||||
const now = Date.now();
|
||||
// 600 episodes at 2h spacing span ~50 days — all inside the 60-day default
|
||||
// window, so all 600 are cached and loadable (no count ceiling).
|
||||
servedEpisodes = Array.from({ length: 600 }, (_, i) => ({
|
||||
title: `Ep ${600 - i}`,
|
||||
date: new Date(Date.UTC(2026, 0, 1 + i)).toISOString(),
|
||||
date: new Date(now - i * 2 * HOUR).toISOString(),
|
||||
}));
|
||||
const feedUrl = `http://127.0.0.1:${server!.port}/huge.xml`;
|
||||
const feedUrl = `http://127.0.0.1:${server!.port}/date-all.xml`;
|
||||
const feed = await store.addFeed(makePodcast(feedUrl), "test-source");
|
||||
expect(feed).not.toBeNull();
|
||||
const id = feed!.id;
|
||||
addedFeedIds.push(id);
|
||||
|
||||
// Subscribe window (MAX_EPISODES_SUBSCRIBE = 20) with 480 more cached.
|
||||
// Subscribe window (20) with more cached.
|
||||
expect(store.getFeed(id)!.episodes.length).toBe(20);
|
||||
|
||||
// Load in MAX_EPISODES_REFRESH chunks until the cache is exhausted.
|
||||
let maxLoaded = 0;
|
||||
// Load everything — the cache holds all 600 (date mode keeps them all).
|
||||
let iterations = 0;
|
||||
while (store.hasMoreEpisodes(id) && iterations < 20) {
|
||||
await store.loadMoreEpisodes(id);
|
||||
maxLoaded = Math.max(maxLoaded, store.getFeed(id)!.episodes.length);
|
||||
iterations++;
|
||||
}
|
||||
|
||||
expect(iterations).toBeLessThan(20);
|
||||
expect(store.hasMoreEpisodes(id)).toBe(false);
|
||||
expect(store.getFeed(id)!.episodes.length).toBe(MAX_EPISODES_IN_MEMORY);
|
||||
expect(maxLoaded).toBeLessThanOrEqual(MAX_EPISODES_IN_MEMORY);
|
||||
expect(store.getFeed(id)!.episodes.length).toBe(600);
|
||||
});
|
||||
|
||||
test("date mode boundary: 25 days in, 70 days out", async () => {
|
||||
const store = useFeedStore();
|
||||
const now = Date.now();
|
||||
servedEpisodes = [
|
||||
{ title: "In Window", date: new Date(now - 25 * DAY).toISOString() },
|
||||
{ title: "Out Window", date: new Date(now - 70 * DAY).toISOString() },
|
||||
];
|
||||
const feedUrl = `http://127.0.0.1:${server!.port}/date-boundary.xml`;
|
||||
const feed = await store.addFeed(makePodcast(feedUrl), "test-source");
|
||||
expect(feed).not.toBeNull();
|
||||
const id = feed!.id;
|
||||
addedFeedIds.push(id);
|
||||
|
||||
expect(store.getFeed(id)!.episodes.map((e) => e.title)).toEqual([
|
||||
"In Window",
|
||||
]);
|
||||
// The full cache holds both, but the visible list only shows the in-window
|
||||
// one — fetch-more surfaces the out-of-window one (volatile).
|
||||
expect(store.hasMoreEpisodes(id)).toBe(true);
|
||||
await store.loadMoreEpisodes(id);
|
||||
expect(store.getFeed(id)!.episodes.map((e) => e.title)).toEqual([
|
||||
"In Window",
|
||||
"Out Window",
|
||||
]);
|
||||
});
|
||||
|
||||
// ── count mode ────────────────────────────────────────────────────────────
|
||||
|
||||
test("count mode: only N most-recent episodes are visible, but fetch-more goes beyond", async () => {
|
||||
const store = useFeedStore();
|
||||
const app = useAppStore();
|
||||
app.updatePreferences({ episodeCacheMode: "count", episodeCacheCount: 25 });
|
||||
|
||||
const now = Date.now();
|
||||
// 50 episodes at 1h spacing — all recent, but count mode caps at 25.
|
||||
servedEpisodes = Array.from({ length: 50 }, (_, i) => ({
|
||||
title: `Ep ${50 - i}`,
|
||||
date: new Date(now - i * HOUR).toISOString(),
|
||||
}));
|
||||
const feedUrl = `http://127.0.0.1:${server!.port}/count.xml`;
|
||||
const feed = await store.addFeed(makePodcast(feedUrl), "test-source");
|
||||
expect(feed).not.toBeNull();
|
||||
const id = feed!.id;
|
||||
addedFeedIds.push(id);
|
||||
|
||||
// Subscribe window (20), but the cache holds all 50 — count mode only
|
||||
// bounds the visible list (25), but the full parse cache is unbounded.
|
||||
// The subscribe window returns min(20, 25) = 20.
|
||||
expect(store.getFeed(id)!.episodes.length).toBe(20);
|
||||
expect(store.hasMoreEpisodes(id)).toBe(true);
|
||||
|
||||
// Fetch more: the visible list grows beyond the count bound — these
|
||||
// episodes are volatile (held in feed.episodes, not extending the cache).
|
||||
while (store.hasMoreEpisodes(id)) {
|
||||
await store.loadMoreEpisodes(id);
|
||||
}
|
||||
expect(store.getFeed(id)!.episodes.length).toBe(50);
|
||||
|
||||
// Reset to date mode for subsequent tests.
|
||||
app.updatePreferences({ episodeCacheMode: "date" });
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user