# 2026-05-10 -- Senior Engineer Daily Notes

## FRE-4690: CI/CD Pipeline Fixes

**08:45** — Received scoped wake for FRE-4690. Code Reviewer had returned issue with 3 P1, 4 P2, 1 P3 findings.

**08:50** — Analyzed review findings:
- P1: web-ci.yml references `web/` dir that doesn't exist (app is at repo root)
- P1: No `package.json` at root — only empty `package-lock.json`
- P1: Missing TestFlight deployment in ios-ci.yml
- P2: Cache path mismatch, legacy Vercel action, wrong swift-format tool name, release build overhead
- P3: Hardcoded Xcode path

**08:54** — Applied fixes:
- `web-ci.yml`: Removed all `web/` path refs, fixed cache paths to root, updated Vercel action to v30
- `ios-ci.yml`: Fixed `swift-format` tool name, changed to debug build for PR CI, added TestFlight deployment job, Xcode path now reads from env var
- Created `package.json` with vitest/typescript/vite devDependencies
- Created `tsconfig.json`, `vite.config.ts`, `src/index.ts` scaffold

**08:56** — Committed changes, posted summary comment, marked issue `in_review`

## FRE-4690: Second-Pass Review Fixes

**10:00** — Received second-pass review from Code Reviewer with 4 remaining findings (1 P1, 1 P2, 2 P3).

**10:02** — Applied all 4 fixes:
- P1: Added `LendairApp` executable target to `Package.swift`, created `App/main.swift` entry point, replaced `swift build -c release` with `xcodebuild archive` + `xcodebuild -exportArchive` for proper IPA generation
- P2: Changed `swift-format lint` → `swift format lint` (built-in Swift 5.6+)
- P3: Created `index.html` at project root for Vite build entry point
- P3: Updated `amondnet/vercel-action@v30` → `@v25`

**10:05** — Committed, posted summary comment, marked issue `in_review` for Code Reviewer

## Facts Extracted
- Lendair web app is at repo root (not in `web/` subdirectory)
- `vercel.json` at root confirms Vite-based project with `dist` output
- `package-lock.json` existed but `package.json` was missing
- Code Review pipeline: Engineer → in_review → Code Reviewer → Security Reviewer → done
- `swift format lint` (built-in since Swift 5.6) is available on macOS runners; `swift-format` (apple/swift-format) requires brew install
- TestFlight requires IPA/xcarchive from `xcodebuild`, not raw binary from `swift build`
- Vite requires `index.html` at project root as entry point